diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2022-03-25 10:10:17 +0000 |
|---|---|---|
| committer | Caolán McNamara <caolan@skynet.ie> | 2022-03-25 10:13:09 +0000 |
| commit | 0a99ca6d50af51f1b0a151fdcac5e12ec9b01bf8 (patch) | |
| tree | af030a400142cb8955e1c349ee80b430da1f3a7a | |
| parent | 99e8e9019c1c64fb96c87cc29604ac0072d2a1d8 (diff) | |
| download | orcus-0a99ca6d50af51f1b0a151fdcac5e12ec9b01bf8.tar.gz | |
forcepoint#88 assigned temp std::string return to string_view
it's out of scope when used
=ERROR: AddressSanitizer: stack-use-after-scope on address 0x7ffcaf91b111 at pc 0x000000486ec4 bp 0x7ffcaf91aed0 sp 0x7ffcaf91a680
READ of size 2 at 0x7ffcaf91b111 thread T0
#0 0x486ec3 in __interceptor_memcpy.part.0 (instdir/program/soffice.bin+0x486ec3)
#1 0x7fa6c4471b77 in std::basic_streambuf<char, std::char_traits<char> >::xsputn(char const*, long) (/lib64/libstdc++.so.6+0x143b77)
#2 0x7fa6c4463ae3 in std::basic_ostream<char, std::char_traits<char> >& std::__ostream_insert<char, std::char_traits<char> >(std::basic_ostream<char, std::char_traits<char> >&, char const*, long) (/lib64/libstdc++.so.6+0x135ae3)
#3 0x7fa6b4027a26 in std::basic_ostream<char, std::char_traits<char> >& std::operator<<<char, std::char_traits<char> >(std::basic_ostream<char, std::char_traits<char> >&, std::basic_string_view<char, std::char_traits<char> >) /usr/bin/../lib/gcc/x86_64-redhat-linux/11/../../../../include/c++/11/string_view:669:14
#4 0x7fa6b426792b in orcus::xml_element_printer::print_namespace(std::ostream&, char const*) const workdir/UnpackedTarball/liborcus/src/liborcus/xml_util.cpp:35:12
#5 0x7fa6b4267c68 in orcus::xml_element_printer::print_element(std::ostream&, char const*, unsigned long) const workdir/UnpackedTarball/liborcus/src/liborcus/xml_util.cpp:46:5
#6 0x7fa6b41c1956 in orcus::xml_context_base::print_element(std::ostream&, std::pair<char const*, unsigned long> const&) const workdir/UnpackedTarball/liborcus/src/liborcus/xml_context_base.cpp:280:20
| -rw-r--r-- | src/liborcus/xml_util.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/liborcus/xml_util.cpp b/src/liborcus/xml_util.cpp index 906d321d..ff270d4a 100644 --- a/src/liborcus/xml_util.cpp +++ b/src/liborcus/xml_util.cpp @@ -29,10 +29,10 @@ void xml_element_printer::print_namespace(std::ostream& os, xmlns_id_t ns) const if (mp_ns_cxt) { std::string_view alias = mp_ns_cxt->get_alias(ns); - if (alias.empty()) - alias = mp_ns_cxt->get_short_name(ns); - - os << alias; + if (!alias.empty()) + os << alias; + else + os << mp_ns_cxt->get_short_name(ns); } else os << ns; |