summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStephan Bergmann <sbergman@redhat.com>2014-09-30 12:27:16 +0200
committerStephan Bergmann <sbergman@redhat.com>2014-09-30 12:28:52 +0200
commit381044bf28ef081a0eaf54007ed34af8c309261b (patch)
tree819d4fc7a876c5e554f12bdcee410a9e455e2c6b
parent00061554c5df8034e2dc4803bb1433b8eb074f8f (diff)
i18npool: std::auto_ptr -> std::unique_ptr
Change-Id: I084e8dfd026d59374d92d9b4cb45d63af2aea470
-rw-r--r--i18npool/inc/localedata.hxx2
1 files changed, 1 insertions, 1 deletions
diff --git a/i18npool/inc/localedata.hxx b/i18npool/inc/localedata.hxx
index 8b848221bf65..8bf9ef837cd4 100644
--- a/i18npool/inc/localedata.hxx
+++ b/i18npool/inc/localedata.hxx
@@ -124,7 +124,7 @@ public:
private :
friend bool operator ==(const com::sun::star::lang::Locale& l1, const com::sun::star::lang::Locale& l2);
- ::std::auto_ptr< LocaleDataLookupTableItem > cachedItem;
+ ::std::unique_ptr< LocaleDataLookupTableItem > cachedItem;
oslGenericFunction SAL_CALL getFunctionSymbol( const com::sun::star::lang::Locale& rLocale, const sal_Char* pFunction ) throw( com::sun::star::uno::RuntimeException );
oslGenericFunction SAL_CALL getFunctionSymbolByName( const OUString& localeName, const sal_Char* pFunction );
span title='2014-01-22 15:09:28 +0100'>2014-01-22Introduce static inline cppu::acquire(), and make use of that.Jan Holesovsky This is much better approach compared to the callback function, as it allows passing arguments to the c++ constructor directly, while still allowing some additional initialization after having acquired the instance. Change-Id: I5a0f981915dd58f1522ee6054e53a3550b29d624 2014-01-21Change _get_implementation()'s not to do initialization directly.Jan Holesovsky Many of the initalizations (in eg. framework) have to be done on an acquire()'d object, so instead of doing the initialization directly, return the initialization member function back to the createInstance() / createInstanceWithContext() / ... and perform the initialization there. As a sideeffect, I belive the calling initialize() from servicemanager is not that much a hack any more - whoever converts the implementation to be constructor-base has the choice to provide the callback, or still initialize through XInitialization, where the callback is preferred by servicemanager when it exists. Change-Id: I8a87b75c54c1441ca0f184967d31ff4902fc4081 2014-01-21Fix bogus mass-conversion equalsAsciiL -> startsWithStephan Bergmann 3af99e4d59d89c343965a928681a30f36b1007d2 "convert equalsAsciiL calls to startsWith calls" should rather have converted to oprator ==. Change-Id: Id4a8836c5d6d570e54661c40be7214632e202b21 2014-01-20Minimize the constructor functions to a bare minimum.Jan Holesovsky Most of the constructors are supposed to be only a call of new TheInstance(arguments) or an equivalent; so let's just change the constructor caller accordingly, to accept unacquired new instance. If there are exceptions that need to do more heavy lifting, they do not have to use the constructor feature, or there can be a wrapper for the real implementation, doing the additional work in their (C++) constructor. Change-Id: I035c378778aeda60d15af4e56ca3761c586d5ded 2014-01-18Unify ctor functions for component implementations.Matúš Kukan There is no need to use different styles for writing the same thing. It also makes it easier in future to use search & replace. But of course, there are also some more complicated functions. Change-Id: I773da20378af0e0d5a27689d3903df7063fb8ac0 2014-01-15Unify ctor functions to have _get_implementation suffix.Matúš Kukan Change-Id: I07fe0671d0633ef9480a4f3431df6a64c7902db8 2014-01-15Use const& arguments parameter for ctor functions.Matúš Kukan Change-Id: I19ce8bd1a23123ac9a62a7fc95cd54fea5315221 2013-12-31svx: Use constructor feature for GraphicExporter.Matúš Kukan Change-Id: I6384cce0915929b0a1249edfb72f5516ad2da3dd 2013-12-20Revert "svx: split into direct implementation getFactories"Matúš Kukan Also reverts "These services are in fact implemented in svxcore library." This reverts commit 090674dcb085cd41f4628e4f07c9a2268a18e862 and commit 4a969ac35174520f1ffeb4f919f5d7bb6d99a628. This is embarrassing; needs more work. 2013-12-20svx: split into direct implementation getFactoriesMatúš Kukan Change-Id: I888f10a923dc2b97247b2a66cc6bd116eee280a7 2013-11-20convert equalsAsciiL calls to startsWith callsNoel Grandin Convert code like: aStr.equalsAsciiL( RTL_CONSTASCII_STRINGPARAM( "ActiveConnection" ) ) to aStr.startsWith( "ActiveConnection" ) which compiles down to the same machine code. Change-Id: Id4b0c5e0f9afe716a468d3afc70374699848dc33 2013-11-19remove unnecessary use of OUString constructor when assigningNoel Grandin change code like aStr = OUString("xxxx"); to aStr = "xxxx"; Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4 2013-10-30fdo#54938: Convert svx to use cppu::supportsServiceMarcos Paulo de Souza Change-Id: I3ab178924cb1c4240511f08625f244dac54e3913 Signed-off-by: Stephan Bergmann <sbergman@redhat.com> 2013-09-05convert svx/source/unodraw/*.cxx from String to OUStringNoel Grandin Change-Id: Ief11702d496a16dfb784c31ef2c185a36fe70311 2013-09-02Resolves: #i122820# Corrected graphics creation...Armin Le Grand allow bigger limits if directly requested (cherry picked from commit 50f1445bda91cb44a1a1e8636ab0bcb6a8c4f381) Conflicts: svx/source/unodraw/UnoGraphicExporter.cxx Change-Id: I33576ef9f95b9f8a9fa0ab6f6d83c93ecec8da9f