summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMike Kaganski <mike.kaganski@collabora.com>2024-03-12 14:16:14 +0100
committerXisco Fauli <xiscofauli@libreoffice.org>2024-03-13 12:20:59 +0100
commit53b8a4c687df83a91e584fb6afa6729d9669f454 (patch)
tree57f37789175904a6e2196b375bfffa68f77ece46
parent2fa450193fbf6013144bdf436076aa4971c3a12e (diff)
tdf#160117: check bAnyCondition
Commit edbc3a09edcf58a4738b4648811a065f3f55bc7c (sc: Don't end handleConditionalFormat early, 2023-11-02) intended to allow to apply several different categories of conditions to the same cell: e.g., color scale or databar, in addition to the normal style application depending on a condition. This change fixes a regression, when the found matching condition did not stop search for the matching conditions to apply a style. Change-Id: Ia4cf1dd35a964c6ca523050dc727184ca22a8dfd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164687 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 61580fcbd10bad2e0aab663d4c8fe43c1e01f92c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164735 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
-rw-r--r--sc/source/core/data/fillinfo.cxx4
1 files changed, 2 insertions, 2 deletions
diff --git a/sc/source/core/data/fillinfo.cxx b/sc/source/core/data/fillinfo.cxx
index 4a573e1c21da..659a539799ac 100644
--- a/sc/source/core/data/fillinfo.cxx
+++ b/sc/source/core/data/fillinfo.cxx
@@ -296,7 +296,7 @@ bool handleConditionalFormat(ScConditionalFormatList& rCondFormList, const ScCon
ScCondFormatData aData = pCondForm->GetData(
pInfo->maCell, rAddr);
- if (!aData.aStyleName.isEmpty())
+ if (!bAnyCondition && !aData.aStyleName.isEmpty())
{
SfxStyleSheetBase* pStyleSheet =
pStlPool->Find( aData.aStyleName, SfxStyleFamily::Para );
@@ -337,7 +337,7 @@ bool handleConditionalFormat(ScConditionalFormatList& rCondFormList, const ScCon
pTableInfo->addIconSetInfo(std::move(aData.pIconSet));
}
- if (pInfo->mxColorScale && pInfo->pIconSet && pInfo->pDataBar)
+ if (bAnyCondition && pInfo->mxColorScale && pInfo->pIconSet && pInfo->pDataBar)
break;
}