diff options
author | Caolán McNamara <caolanm@redhat.com> | 2015-03-05 20:48:50 +0000 |
---|---|---|
committer | Caolán McNamara <caolanm@redhat.com> | 2015-03-06 09:43:38 +0000 |
commit | 3f6f21e6e7721bbca13c1e632c0247939538ba82 (patch) | |
tree | e2679ab8218fc1d405ae22c16da3780d55ce411a | |
parent | 4cd7b4ab8aeaf61f5e30e4b63e039b7bb9519e85 (diff) |
V801: Decreased performance
Change-Id: Ia58f19c7121dc8a835436bcefc7fd1e3789407db
31 files changed, 72 insertions, 100 deletions
diff --git a/include/sfx2/sidebar/IContextChangeReceiver.hxx b/include/sfx2/sidebar/IContextChangeReceiver.hxx index cf6e1590c8eb..ea5c24a61af1 100644 --- a/include/sfx2/sidebar/IContextChangeReceiver.hxx +++ b/include/sfx2/sidebar/IContextChangeReceiver.hxx @@ -31,7 +31,7 @@ class SFX2_DLLPUBLIC IContextChangeReceiver public: virtual ~IContextChangeReceiver (); - virtual void HandleContextChange (const EnumContext aContext) = 0; + virtual void HandleContextChange (const EnumContext& rContext) = 0; }; } } // end of namespace ::sd::sidebar diff --git a/sc/inc/afmtuno.hxx b/sc/inc/afmtuno.hxx index 8ebdb14e3ef3..5e1da0e50433 100644 --- a/sc/inc/afmtuno.hxx +++ b/sc/inc/afmtuno.hxx @@ -224,8 +224,7 @@ public: throw(::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; static const ::com::sun::star::uno::Sequence<sal_Int8>& getUnoTunnelId(); - static ScAutoFormatObj* getImplementation( const ::com::sun::star::uno::Reference< - ::com::sun::star::uno::XInterface> xObj ); + static ScAutoFormatObj* getImplementation(const css::uno::Reference<css::uno::XInterface>& rObj); }; class ScAutoFormatFieldObj : public ::cppu::WeakImplHelper2< diff --git a/sc/inc/cellsuno.hxx b/sc/inc/cellsuno.hxx index ba9dedbe156c..a4fc6fa6a959 100644 --- a/sc/inc/cellsuno.hxx +++ b/sc/inc/cellsuno.hxx @@ -492,8 +492,7 @@ public: throw(::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; static const com::sun::star::uno::Sequence<sal_Int8>& getUnoTunnelId(); - static ScCellRangesBase* getImplementation( const com::sun::star::uno::Reference< - com::sun::star::uno::XInterface> xObj ); + static ScCellRangesBase* getImplementation(const css::uno::Reference<css::uno::XInterface>& rObj); // XTypeProvider virtual ::com::sun::star::uno::Sequence< ::com::sun::star::uno::Type > SAL_CALL getTypes() @@ -1259,8 +1258,7 @@ public: throw(::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; static const com::sun::star::uno::Sequence<sal_Int8>& getUnoTunnelId(); - static ScTableSheetObj* getImplementation( const com::sun::star::uno::Reference< - com::sun::star::uno::XInterface> xObj ); + static ScTableSheetObj* getImplementation(const css::uno::Reference< com::sun::star::uno::XInterface>& rObj); // XTypeProvider virtual ::com::sun::star::uno::Sequence< ::com::sun::star::uno::Type > SAL_CALL getTypes() diff --git a/sc/inc/dapiuno.hxx b/sc/inc/dapiuno.hxx index ab4bfe323a44..f0347676608c 100644 --- a/sc/inc/dapiuno.hxx +++ b/sc/inc/dapiuno.hxx @@ -257,8 +257,7 @@ public: throw(::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; static const com::sun::star::uno::Sequence<sal_Int8>& getUnoTunnelId(); - SC_DLLPUBLIC static ScDataPilotDescriptorBase* getImplementation( const com::sun::star::uno::Reference< - com::sun::star::sheet::XDataPilotDescriptor> xObj ); + SC_DLLPUBLIC static ScDataPilotDescriptorBase* getImplementation(const css::uno::Reference<css::sheet::XDataPilotDescriptor>& rObj); // XTypeProvider (override in ScDataPilotTableObj) virtual ::com::sun::star::uno::Sequence< ::com::sun::star::uno::Type > SAL_CALL getTypes() diff --git a/sc/inc/datauno.hxx b/sc/inc/datauno.hxx index f9c2b1081eb0..4153340615f3 100644 --- a/sc/inc/datauno.hxx +++ b/sc/inc/datauno.hxx @@ -195,8 +195,7 @@ public: throw(::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; static const com::sun::star::uno::Sequence<sal_Int8>& getUnoTunnelId(); - static ScSubTotalDescriptorBase* getImplementation( const com::sun::star::uno::Reference< - com::sun::star::sheet::XSubTotalDescriptor> xObj ); + static ScSubTotalDescriptorBase* getImplementation(const css::uno::Reference<css::sheet::XSubTotalDescriptor>& rObj); // XServiceInfo virtual OUString SAL_CALL getImplementationName() diff --git a/sc/inc/docuno.hxx b/sc/inc/docuno.hxx index f277efc68168..7b10600144a9 100644 --- a/sc/inc/docuno.hxx +++ b/sc/inc/docuno.hxx @@ -310,8 +310,7 @@ public: throw(::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; static const com::sun::star::uno::Sequence<sal_Int8>& getUnoTunnelId(); - static ScModelObj* getImplementation( const com::sun::star::uno::Reference< - com::sun::star::uno::XInterface> xObj ); + static ScModelObj* getImplementation(const css::uno::Reference<css::uno::XInterface>& rObj); /// XTypeProvider virtual ::com::sun::star::uno::Sequence< ::com::sun::star::uno::Type > SAL_CALL getTypes() diff --git a/sc/inc/fmtuno.hxx b/sc/inc/fmtuno.hxx index 44a8989949ab..3ee15f1dd216 100644 --- a/sc/inc/fmtuno.hxx +++ b/sc/inc/fmtuno.hxx @@ -130,8 +130,7 @@ public: throw(::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; static const com::sun::star::uno::Sequence<sal_Int8>& getUnoTunnelId(); - static ScTableConditionalFormat* getImplementation( const com::sun::star::uno::Reference< - com::sun::star::sheet::XSheetConditionalEntries> xObj ); + static ScTableConditionalFormat* getImplementation(const css::uno::Reference<css::sheet::XSheetConditionalEntries>& rObj); // XServiceInfo virtual OUString SAL_CALL getImplementationName() @@ -309,8 +308,7 @@ public: throw(::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; static const com::sun::star::uno::Sequence<sal_Int8>& getUnoTunnelId(); - static ScTableValidationObj* getImplementation( const com::sun::star::uno::Reference< - com::sun::star::beans::XPropertySet> xObj ); + static ScTableValidationObj* getImplementation(const css::uno::Reference<css::beans::XPropertySet>& rObj); // XServiceInfo virtual OUString SAL_CALL getImplementationName() diff --git a/sc/inc/srchuno.hxx b/sc/inc/srchuno.hxx index c7d372162564..2a19c1b5dfc4 100644 --- a/sc/inc/srchuno.hxx +++ b/sc/inc/srchuno.hxx @@ -102,8 +102,7 @@ public: throw(::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; static const com::sun::star::uno::Sequence<sal_Int8>& getUnoTunnelId(); - static ScCellSearchObj* getImplementation( const com::sun::star::uno::Reference< - com::sun::star::util::XSearchDescriptor> xObj ); + static ScCellSearchObj* getImplementation(const css::uno::Reference<css::util::XSearchDescriptor>& rObj); // XServiceInfo virtual OUString SAL_CALL getImplementationName() diff --git a/sc/inc/styleuno.hxx b/sc/inc/styleuno.hxx index d8234d3976c6..b8abfed38bff 100644 --- a/sc/inc/styleuno.hxx +++ b/sc/inc/styleuno.hxx @@ -377,8 +377,7 @@ public: throw(::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; static const ::com::sun::star::uno::Sequence<sal_Int8>& getUnoTunnelId(); - static ScStyleObj* getImplementation( const ::com::sun::star::uno::Reference< - ::com::sun::star::uno::XInterface> xObj ); + static ScStyleObj* getImplementation(const css::uno::Reference<css::uno::XInterface>& rObj); }; diff --git a/sc/inc/textuno.hxx b/sc/inc/textuno.hxx index 303abfc2b136..cfa4d3a07804 100644 --- a/sc/inc/textuno.hxx +++ b/sc/inc/textuno.hxx @@ -94,8 +94,7 @@ public: throw(::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; static const com::sun::star::uno::Sequence<sal_Int8>& getUnoTunnelId(); - static rtl::Reference<ScHeaderFooterContentObj> getImplementation( const com::sun::star::uno::Reference< - com::sun::star::sheet::XHeaderFooterContent> xObj ); + static rtl::Reference<ScHeaderFooterContentObj> getImplementation(const css::uno::Reference<css::sheet::XHeaderFooterContent>& rObj); // XServiceInfo virtual OUString SAL_CALL getImplementationName() @@ -264,8 +263,7 @@ public: throw(::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; static const com::sun::star::uno::Sequence<sal_Int8>& getUnoTunnelId(); - static ScCellTextCursor* getImplementation( const com::sun::star::uno::Reference< - com::sun::star::uno::XInterface> xObj ); + static ScCellTextCursor* getImplementation(const css::uno::Reference< css::uno::XInterface>& rObj); }; class ScHeaderFooterTextCursor : public SvxUnoTextCursor @@ -292,8 +290,7 @@ public: throw(::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; static const com::sun::star::uno::Sequence<sal_Int8>& getUnoTunnelId(); - static ScHeaderFooterTextCursor* getImplementation( const com::sun::star::uno::Reference< - com::sun::star::uno::XInterface> xObj ); + static ScHeaderFooterTextCursor* getImplementation(const css::uno::Reference<css::uno::XInterface>& rObj); }; class ScDrawTextCursor : public SvxUnoTextCursor @@ -322,8 +319,7 @@ public: throw(::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; static const com::sun::star::uno::Sequence<sal_Int8>& getUnoTunnelId(); - static ScDrawTextCursor* getImplementation( const com::sun::star::uno::Reference< - com::sun::star::uno::XInterface> xObj ); + static ScDrawTextCursor* getImplementation(const css::uno::Reference<css::uno::XInterface>& rObj); }; // ScAnnotationTextCursor isn't needed anymore - SvxUnoTextCursor is used instead diff --git a/sc/source/ui/sidebar/AlignmentPropertyPanel.cxx b/sc/source/ui/sidebar/AlignmentPropertyPanel.cxx index 10b1385100d1..e10b53830ffb 100644 --- a/sc/source/ui/sidebar/AlignmentPropertyPanel.cxx +++ b/sc/source/ui/sidebar/AlignmentPropertyPanel.cxx @@ -229,17 +229,15 @@ void AlignmentPropertyPanel::DataChanged( } void AlignmentPropertyPanel::HandleContextChange( - const ::sfx2::sidebar::EnumContext aContext) + const ::sfx2::sidebar::EnumContext& rContext) { - if(maContext == aContext) + if (maContext == rContext) { // Nothing to do. return; } - maContext = aContext; - - // todo + maContext = rContext; } void AlignmentPropertyPanel::NotifyItemUpdate( diff --git a/sc/source/ui/sidebar/AlignmentPropertyPanel.hxx b/sc/source/ui/sidebar/AlignmentPropertyPanel.hxx index 32c705ba2c02..050c79d48b63 100644 --- a/sc/source/ui/sidebar/AlignmentPropertyPanel.hxx +++ b/sc/source/ui/sidebar/AlignmentPropertyPanel.hxx @@ -48,7 +48,7 @@ public: const DataChangedEvent& rEvent) SAL_OVERRIDE; virtual void HandleContextChange( - const ::sfx2::sidebar::EnumContext aContext) SAL_OVERRIDE; + const ::sfx2::sidebar::EnumContext& rContext) SAL_OVERRIDE; virtual void NotifyItemUpdate( const sal_uInt16 nSId, diff --git a/sc/source/ui/sidebar/CellAppearancePropertyPanel.cxx b/sc/source/ui/sidebar/CellAppearancePropertyPanel.cxx index bf4e1b3e2740..322ceb53a83f 100644 --- a/sc/source/ui/sidebar/CellAppearancePropertyPanel.cxx +++ b/sc/source/ui/sidebar/CellAppearancePropertyPanel.cxx @@ -249,18 +249,15 @@ void CellAppearancePropertyPanel::DataChanged( (void)rEvent; } -void CellAppearancePropertyPanel::HandleContextChange( - const ::sfx2::sidebar::EnumContext aContext) +void CellAppearancePropertyPanel::HandleContextChange(const ::sfx2::sidebar::EnumContext& rContext) { - if(maContext == aContext) + if (maContext == rContext) { // Nothing to do. return; } - maContext = aContext; - - // todo + maContext = rContext; } void CellAppearancePropertyPanel::NotifyItemUpdate( diff --git a/sc/source/ui/sidebar/CellAppearancePropertyPanel.hxx b/sc/source/ui/sidebar/CellAppearancePropertyPanel.hxx index 60c2a5ba4998..f8da7a59bfb9 100644 --- a/sc/source/ui/sidebar/CellAppearancePropertyPanel.hxx +++ b/sc/source/ui/sidebar/CellAppearancePropertyPanel.hxx @@ -59,7 +59,7 @@ public: const DataChangedEvent& rEvent) SAL_OVERRIDE; virtual void HandleContextChange( - const ::sfx2::sidebar::EnumContext aContext) SAL_OVERRIDE; + const ::sfx2::sidebar::EnumContext& rContext) SAL_OVERRIDE; virtual void NotifyItemUpdate( const sal_uInt16 nSId, diff --git a/sc/source/ui/sidebar/NumberFormatPropertyPanel.cxx b/sc/source/ui/sidebar/NumberFormatPropertyPanel.cxx index b9d5fdce94dc..c37fc116b58b 100644 --- a/sc/source/ui/sidebar/NumberFormatPropertyPanel.cxx +++ b/sc/source/ui/sidebar/NumberFormatPropertyPanel.cxx @@ -191,17 +191,15 @@ void NumberFormatPropertyPanel::DataChanged( } void NumberFormatPropertyPanel::HandleContextChange( - const ::sfx2::sidebar::EnumContext aContext) + const ::sfx2::sidebar::EnumContext& rContext) { - if(maContext == aContext) + if(maContext == rContext) { // Nothing to do. return; } - maContext = aContext; - - // todo + maContext = rContext; } void NumberFormatPropertyPanel::NotifyItemUpdate( diff --git a/sc/source/ui/sidebar/NumberFormatPropertyPanel.hxx b/sc/source/ui/sidebar/NumberFormatPropertyPanel.hxx index 984257e92256..5fe5df1aeb63 100644 --- a/sc/source/ui/sidebar/NumberFormatPropertyPanel.hxx +++ b/sc/source/ui/sidebar/NumberFormatPropertyPanel.hxx @@ -46,7 +46,7 @@ public: const DataChangedEvent& rEvent) SAL_OVERRIDE; virtual void HandleContextChange( - const ::sfx2::sidebar::EnumContext aContext) SAL_OVERRIDE; + const ::sfx2::sidebar::EnumContext& rContext) SAL_OVERRIDE; virtual void NotifyItemUpdate( const sal_uInt16 nSId, diff --git a/sc/source/ui/unoobj/afmtuno.cxx b/sc/source/ui/unoobj/afmtuno.cxx index d518965ee6cc..865449f27718 100644 --- a/sc/source/ui/unoobj/afmtuno.cxx +++ b/sc/source/ui/unoobj/afmtuno.cxx @@ -433,11 +433,10 @@ const uno::Sequence<sal_Int8>& ScAutoFormatObj::getUnoTunnelId() return theScAutoFormatObjUnoTunnelId::get().getSeq(); } -ScAutoFormatObj* ScAutoFormatObj::getImplementation( - const uno::Reference<uno::XInterface> xObj ) +ScAutoFormatObj* ScAutoFormatObj::getImplementation(const uno::Reference<uno::XInterface>& rObj) { ScAutoFormatObj* pRet = NULL; - uno::Reference<lang::XUnoTunnel> xUT( xObj, uno::UNO_QUERY ); + uno::Reference<lang::XUnoTunnel> xUT(rObj, uno::UNO_QUERY); if (xUT.is()) pRet = reinterpret_cast<ScAutoFormatObj*>(sal::static_int_cast<sal_IntPtr>(xUT->getSomething(getUnoTunnelId()))); return pRet; diff --git a/sc/source/ui/unoobj/cellsuno.cxx b/sc/source/ui/unoobj/cellsuno.cxx index 7fa1c76c76c8..4dcb1f74275b 100644 --- a/sc/source/ui/unoobj/cellsuno.cxx +++ b/sc/source/ui/unoobj/cellsuno.cxx @@ -4140,10 +4140,10 @@ const uno::Sequence<sal_Int8>& ScCellRangesBase::getUnoTunnelId() return theScCellRangesBaseUnoTunnelId::get().getSeq(); } -ScCellRangesBase* ScCellRangesBase::getImplementation( const uno::Reference<uno::XInterface> xObj ) +ScCellRangesBase* ScCellRangesBase::getImplementation(const uno::Reference<uno::XInterface>& rObj) { ScCellRangesBase* pRet = NULL; - uno::Reference<lang::XUnoTunnel> xUT( xObj, uno::UNO_QUERY ); + uno::Reference<lang::XUnoTunnel> xUT(rObj, uno::UNO_QUERY); if (xUT.is()) pRet = reinterpret_cast<ScCellRangesBase*>(sal::static_int_cast<sal_IntPtr>(xUT->getSomething(getUnoTunnelId()))); return pRet; @@ -8658,10 +8658,10 @@ const uno::Sequence<sal_Int8>& ScTableSheetObj::getUnoTunnelId() return theScTableSheetObjUnoTunnelId::get().getSeq(); } -ScTableSheetObj* ScTableSheetObj::getImplementation( const uno::Reference<uno::XInterface> xObj ) +ScTableSheetObj* ScTableSheetObj::getImplementation(const uno::Reference<uno::XInterface>& rObj) { ScTableSheetObj* pRet = NULL; - uno::Reference<lang::XUnoTunnel> xUT( xObj, uno::UNO_QUERY ); + uno::Reference<lang::XUnoTunnel> xUT(rObj, uno::UNO_QUERY); if (xUT.is()) pRet = reinterpret_cast<ScTableSheetObj*>(sal::static_int_cast<sal_IntPtr>(xUT->getSomething(getUnoTunnelId()))); return pRet; diff --git a/sc/source/ui/unoobj/dapiuno.cxx b/sc/source/ui/unoobj/dapiuno.cxx index 5dba25001b4f..abdec8b54a49 100644 --- a/sc/source/ui/unoobj/dapiuno.cxx +++ b/sc/source/ui/unoobj/dapiuno.cxx @@ -352,11 +352,11 @@ Reference<XDataPilotDescriptor> SAL_CALL ScDataPilotTablesObj::createDataPilotDe return NULL; } -static bool lcl_IsDuplicated( const Reference<XPropertySet> xDimProps ) +static bool lcl_IsDuplicated(const Reference<XPropertySet>& rDimProps) { try { - Any aAny = xDimProps->getPropertyValue( OUString( SC_UNO_DP_ORIGINAL ) ); + Any aAny = rDimProps->getPropertyValue( OUString( SC_UNO_DP_ORIGINAL ) ); Reference< XNamed > xOriginal( aAny, UNO_QUERY ); return xOriginal.is(); } @@ -366,11 +366,11 @@ static bool lcl_IsDuplicated( const Reference<XPropertySet> xDimProps ) return false; } -static OUString lcl_GetOriginalName( const Reference< XNamed > xDim ) +static OUString lcl_GetOriginalName(const Reference< XNamed >& rDim) { Reference< XNamed > xOriginal; - Reference< XPropertySet > xDimProps( xDim, UNO_QUERY ); + Reference< XPropertySet > xDimProps(rDim, UNO_QUERY); if ( xDimProps.is() ) { try @@ -384,7 +384,7 @@ static OUString lcl_GetOriginalName( const Reference< XNamed > xDim ) } if ( !xOriginal.is() ) - xOriginal = xDim; + xOriginal = rDim; return xOriginal->getName(); } @@ -1073,11 +1073,10 @@ const Sequence<sal_Int8>& ScDataPilotDescriptorBase::getUnoTunnelId() return theScDataPilotDescriptorBaseUnoTunnelId::get().getSeq(); } -ScDataPilotDescriptorBase* ScDataPilotDescriptorBase::getImplementation( - const Reference<XDataPilotDescriptor> xObj ) +ScDataPilotDescriptorBase* ScDataPilotDescriptorBase::getImplementation(const Reference<XDataPilotDescriptor>& rObj ) { ScDataPilotDescriptorBase* pRet = NULL; - Reference<lang::XUnoTunnel> xUT( xObj, UNO_QUERY ); + Reference<lang::XUnoTunnel> xUT(rObj, UNO_QUERY); if (xUT.is()) pRet = reinterpret_cast<ScDataPilotDescriptorBase*>(sal::static_int_cast<sal_IntPtr>(xUT->getSomething(getUnoTunnelId()))); return pRet; diff --git a/sc/source/ui/unoobj/datauno.cxx b/sc/source/ui/unoobj/datauno.cxx index 4eb4dbcf5cb4..6b32203094e3 100644 --- a/sc/source/ui/unoobj/datauno.cxx +++ b/sc/source/ui/unoobj/datauno.cxx @@ -791,11 +791,10 @@ const uno::Sequence<sal_Int8>& ScSubTotalDescriptorBase::getUnoTunnelId() return theScSubTotalDescriptorBaseUnoTunnelId::get().getSeq(); } -ScSubTotalDescriptorBase* ScSubTotalDescriptorBase::getImplementation( - const uno::Reference<sheet::XSubTotalDescriptor> xObj ) +ScSubTotalDescriptorBase* ScSubTotalDescriptorBase::getImplementation(const uno::Reference<sheet::XSubTotalDescriptor>& rObj) { ScSubTotalDescriptorBase* pRet = NULL; - uno::Reference<lang::XUnoTunnel> xUT( xObj, uno::UNO_QUERY ); + uno::Reference<lang::XUnoTunnel> xUT(rObj, uno::UNO_QUERY); if (xUT.is()) pRet = reinterpret_cast<ScSubTotalDescriptorBase*>(sal::static_int_cast<sal_IntPtr>(xUT->getSomething(getUnoTunnelId()))); return pRet; diff --git a/sc/source/ui/unoobj/docuno.cxx b/sc/source/ui/unoobj/docuno.cxx index d8697d4831ca..daa8f4976527 100644 --- a/sc/source/ui/unoobj/docuno.cxx +++ b/sc/source/ui/unoobj/docuno.cxx @@ -2196,10 +2196,10 @@ const uno::Sequence<sal_Int8>& ScModelObj::getUnoTunnelId() return theScModelObjUnoTunnelId::get().getSeq(); } -ScModelObj* ScModelObj::getImplementation( const uno::Reference<uno::XInterface> xObj ) +ScModelObj* ScModelObj::getImplementation(const uno::Reference<uno::XInterface>& rObj) { ScModelObj* pRet = NULL; - uno::Reference<lang::XUnoTunnel> xUT( xObj, uno::UNO_QUERY ); + uno::Reference<lang::XUnoTunnel> xUT(rObj, uno::UNO_QUERY); if (xUT.is()) pRet = reinterpret_cast<ScModelObj*>(sal::static_int_cast<sal_IntPtr>(xUT->getSomething(getUnoTunnelId()))); return pRet; diff --git a/sc/source/ui/unoobj/fmtuno.cxx b/sc/source/ui/unoobj/fmtuno.cxx index aa99980bf2e0..32b7c733a772 100644 --- a/sc/source/ui/unoobj/fmtuno.cxx +++ b/sc/source/ui/unoobj/fmtuno.cxx @@ -490,11 +490,10 @@ const uno::Sequence<sal_Int8>& ScTableConditionalFormat::getUnoTunnelId() return theScTableConditionalFormatUnoTunnelId::get().getSeq(); } -ScTableConditionalFormat* ScTableConditionalFormat::getImplementation( - const uno::Reference<sheet::XSheetConditionalEntries> xObj ) +ScTableConditionalFormat* ScTableConditionalFormat::getImplementation(const uno::Reference<sheet::XSheetConditionalEntries>& rObj) { ScTableConditionalFormat* pRet = NULL; - uno::Reference<lang::XUnoTunnel> xUT( xObj, uno::UNO_QUERY ); + uno::Reference<lang::XUnoTunnel> xUT(rObj, uno::UNO_QUERY); if (xUT.is()) pRet = reinterpret_cast<ScTableConditionalFormat*>(sal::static_int_cast<sal_IntPtr>(xUT->getSomething(getUnoTunnelId()))); return pRet; @@ -1016,11 +1015,10 @@ const uno::Sequence<sal_Int8>& ScTableValidationObj::getUnoTunnelId() return theScTableValidationObjUnoTunnelId::get().getSeq(); } -ScTableValidationObj* ScTableValidationObj::getImplementation( - const uno::Reference<beans::XPropertySet> xObj ) +ScTableValidationObj* ScTableValidationObj::getImplementation(const uno::Reference<beans::XPropertySet>& rObj) { ScTableValidationObj* pRet = NULL; - uno::Reference<lang::XUnoTunnel> xUT( xObj, uno::UNO_QUERY ); + uno::Reference<lang::XUnoTunnel> xUT(rObj, uno::UNO_QUERY); if (xUT.is()) pRet = reinterpret_cast<ScTableValidationObj*>(sal::static_int_cast<sal_IntPtr>(xUT->getSomething(getUnoTunnelId()))); return pRet; diff --git a/sc/source/ui/unoobj/srchuno.cxx b/sc/source/ui/unoobj/srchuno.cxx index c0ad6a198b47..d750899be3d9 100644 --- a/sc/source/ui/unoobj/srchuno.cxx +++ b/sc/source/ui/unoobj/srchuno.cxx @@ -231,11 +231,10 @@ const uno::Sequence<sal_Int8>& ScCellSearchObj::getUnoTunnelId() return theScCellSearchObjUnoTunnelId::get().getSeq(); } -ScCellSearchObj* ScCellSearchObj::getImplementation( - const uno::Reference<util::XSearchDescriptor> xObj ) +ScCellSearchObj* ScCellSearchObj::getImplementation(const uno::Reference<util::XSearchDescriptor>& rObj) { ScCellSearchObj* pRet = NULL; - uno::Reference<lang::XUnoTunnel> xUT( xObj, uno::UNO_QUERY ); + uno::Reference<lang::XUnoTunnel> xUT(rObj, uno::UNO_QUERY); if (xUT.is()) pRet = reinterpret_cast<ScCellSearchObj*>(sal::static_int_cast<sal_IntPtr>(xUT->getSomething(getUnoTunnelId()))); return pRet; diff --git a/sc/source/ui/unoobj/styleuno.cxx b/sc/source/ui/unoobj/styleuno.cxx index 421658bb71ef..c9c79636d63a 100644 --- a/sc/source/ui/unoobj/styleuno.cxx +++ b/sc/source/ui/unoobj/styleuno.cxx @@ -1009,11 +1009,10 @@ const uno::Sequence<sal_Int8>& ScStyleObj::getUnoTunnelId() return theScStyleObjUnoTunnelId::get().getSeq(); } -ScStyleObj* ScStyleObj::getImplementation( - const uno::Reference<uno::XInterface> xObj ) +ScStyleObj* ScStyleObj::getImplementation(const uno::Reference<uno::XInterface>& rObj) { ScStyleObj* pRet = NULL; - uno::Reference<lang::XUnoTunnel> xUT( xObj, uno::UNO_QUERY ); + uno::Reference<lang::XUnoTunnel> xUT(rObj, uno::UNO_QUERY); if (xUT.is()) pRet = reinterpret_cast<ScStyleObj*>(sal::static_int_cast<sal_IntPtr>(xUT->getSomething(getUnoTunnelId()))); return pRet; diff --git a/sc/source/ui/unoobj/textuno.cxx b/sc/source/ui/unoobj/textuno.cxx index 180752c9a695..ac01ca7d63cf 100644 --- a/sc/source/ui/unoobj/textuno.cxx +++ b/sc/source/ui/unoobj/textuno.cxx @@ -165,10 +165,10 @@ const uno::Sequence<sal_Int8>& ScHeaderFooterContentObj::getUnoTunnelId() } rtl::Reference<ScHeaderFooterContentObj> ScHeaderFooterContentObj::getImplementation( - const uno::Reference<sheet::XHeaderFooterContent> xObj ) + const uno::Reference<sheet::XHeaderFooterContent>& rObj) { rtl::Reference<ScHeaderFooterContentObj> pRet; - uno::Reference<lang::XUnoTunnel> xUT( xObj, uno::UNO_QUERY ); + uno::Reference<lang::XUnoTunnel> xUT(rObj, uno::UNO_QUERY); if (xUT.is()) pRet = reinterpret_cast<ScHeaderFooterContentObj*>(sal::static_int_cast<sal_IntPtr>(xUT->getSomething(getUnoTunnelId()))); return pRet; @@ -647,10 +647,10 @@ const uno::Sequence<sal_Int8>& ScCellTextCursor::getUnoTunnelId() return theScCellTextCursorUnoTunnelId::get().getSeq(); } -ScCellTextCursor* ScCellTextCursor::getImplementation( const uno::Reference<uno::XInterface> xObj ) +ScCellTextCursor* ScCellTextCursor::getImplementation(const uno::Reference<uno::XInterface>& rObj) { ScCellTextCursor* pRet = NULL; - uno::Reference<lang::XUnoTunnel> xUT( xObj, uno::UNO_QUERY ); + uno::Reference<lang::XUnoTunnel> xUT(rObj, uno::UNO_QUERY); if (xUT.is()) pRet = reinterpret_cast<ScCellTextCursor*>(sal::static_int_cast<sal_IntPtr>(xUT->getSomething(getUnoTunnelId()))); return pRet; @@ -742,10 +742,10 @@ const uno::Sequence<sal_Int8>& ScHeaderFooterTextCursor::getUnoTunnelId() } ScHeaderFooterTextCursor* ScHeaderFooterTextCursor::getImplementation( - const uno::Reference<uno::XInterface> xObj ) + const uno::Reference<uno::XInterface>& rObj) { ScHeaderFooterTextCursor* pRet = NULL; - uno::Reference<lang::XUnoTunnel> xUT( xObj, uno::UNO_QUERY ); + uno::Reference<lang::XUnoTunnel> xUT(rObj, uno::UNO_QUERY); if (xUT.is()) pRet = reinterpret_cast<ScHeaderFooterTextCursor*>(sal::static_int_cast<sal_IntPtr>(xUT->getSomething(getUnoTunnelId()))); return pRet; @@ -835,10 +835,10 @@ const uno::Sequence<sal_Int8>& ScDrawTextCursor::getUnoTunnelId() return theScDrawTextCursorUnoTunnelId::get().getSeq(); } -ScDrawTextCursor* ScDrawTextCursor::getImplementation( const uno::Reference<uno::XInterface> xObj ) +ScDrawTextCursor* ScDrawTextCursor::getImplementation(const uno::Reference<uno::XInterface>& rObj) { ScDrawTextCursor* pRet = NULL; - uno::Reference<lang::XUnoTunnel> xUT( xObj, uno::UNO_QUERY ); + uno::Reference<lang::XUnoTunnel> xUT(rObj, uno::UNO_QUERY); if (xUT.is()) pRet = reinterpret_cast<ScDrawTextCursor*>(sal::static_int_cast<sal_IntPtr>(xUT->getSomething(getUnoTunnelId()))); return pRet; diff --git a/svx/source/sidebar/paragraph/ParaPropertyPanel.cxx b/svx/source/sidebar/paragraph/ParaPropertyPanel.cxx index 5a426d5b5e20..632ef57ed3f4 100644 --- a/svx/source/sidebar/paragraph/ParaPropertyPanel.cxx +++ b/svx/source/sidebar/paragraph/ParaPropertyPanel.cxx @@ -76,15 +76,15 @@ ParaPropertyPanel* ParaPropertyPanel::Create ( } void ParaPropertyPanel::HandleContextChange ( - const ::sfx2::sidebar::EnumContext aContext) + const ::sfx2::sidebar::EnumContext& rContext) { - if (maContext == aContext) + if (maContext == rContext) { // Nothing to do. return; } - maContext = aContext; + maContext = rContext; switch (maContext.GetCombinedContext_DI()) { case CombinedEnumContext(Application_Calc, Context_DrawText): diff --git a/svx/source/sidebar/paragraph/ParaPropertyPanel.hxx b/svx/source/sidebar/paragraph/ParaPropertyPanel.hxx index c61c1c89be94..a6b3f74cf6d5 100644 --- a/svx/source/sidebar/paragraph/ParaPropertyPanel.hxx +++ b/svx/source/sidebar/paragraph/ParaPropertyPanel.hxx @@ -53,7 +53,7 @@ public: SfxBindings* GetBindings() { return mpBindings;} virtual void HandleContextChange ( - const ::sfx2::sidebar::EnumContext aContext) SAL_OVERRIDE; + const ::sfx2::sidebar::EnumContext& rContext) SAL_OVERRIDE; virtual void NotifyItemUpdate( const sal_uInt16 nSId, diff --git a/svx/source/sidebar/possize/PosSizePropertyPanel.cxx b/svx/source/sidebar/possize/PosSizePropertyPanel.cxx index 6f6dceb6a62b..d4011d67c0dc 100644 --- a/svx/source/sidebar/possize/PosSizePropertyPanel.cxx +++ b/svx/source/sidebar/possize/PosSizePropertyPanel.cxx @@ -244,15 +244,15 @@ void PosSizePropertyPanel::DataChanged( } void PosSizePropertyPanel::HandleContextChange( - const ::sfx2::sidebar::EnumContext aContext) + const ::sfx2::sidebar::EnumContext& rContext) { - if(maContext == aContext) + if (maContext == rContext) { // Nothing to do. return; } - maContext = aContext; + maContext = rContext; sal_Int32 nLayoutMode (0); switch (maContext.GetCombinedContext_DI()) diff --git a/svx/source/sidebar/possize/PosSizePropertyPanel.hxx b/svx/source/sidebar/possize/PosSizePropertyPanel.hxx index a0b39cd2c5e1..e9d665673773 100644 --- a/svx/source/sidebar/possize/PosSizePropertyPanel.hxx +++ b/svx/source/sidebar/possize/PosSizePropertyPanel.hxx @@ -60,7 +60,7 @@ public: const DataChangedEvent& rEvent) SAL_OVERRIDE; virtual void HandleContextChange( - const ::sfx2::sidebar::EnumContext aContext) SAL_OVERRIDE; + const ::sfx2::sidebar::EnumContext& rContext) SAL_OVERRIDE; virtual void NotifyItemUpdate( const sal_uInt16 nSId, diff --git a/svx/source/sidebar/text/TextPropertyPanel.cxx b/svx/source/sidebar/text/TextPropertyPanel.cxx index 44d8a2cb65b3..5744f0a1449c 100644 --- a/svx/source/sidebar/text/TextPropertyPanel.cxx +++ b/svx/source/sidebar/text/TextPropertyPanel.cxx @@ -119,12 +119,12 @@ TextPropertyPanel::~TextPropertyPanel (void) } void TextPropertyPanel::HandleContextChange ( - const ::sfx2::sidebar::EnumContext aContext) + const ::sfx2::sidebar::EnumContext& rContext) { - if (maContext == aContext) + if (maContext == rContext) return; - maContext = aContext; + maContext = rContext; mpToolBoxIncDec->Show(maContext.GetApplication_DI() != sfx2::sidebar::EnumContext::Application_Calc); bool bWriterText = false; diff --git a/svx/source/sidebar/text/TextPropertyPanel.hxx b/svx/source/sidebar/text/TextPropertyPanel.hxx index 9385dcc17d61..f0734dab09a7 100644 --- a/svx/source/sidebar/text/TextPropertyPanel.hxx +++ b/svx/source/sidebar/text/TextPropertyPanel.hxx @@ -62,7 +62,7 @@ public: virtual void HandleContextChange ( - const ::sfx2::sidebar::EnumContext aContext) SAL_OVERRIDE; + const ::sfx2::sidebar::EnumContext& rContext) SAL_OVERRIDE; virtual void NotifyItemUpdate( |