summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPaul Trojahn <paul.trojahn@gmail.com>2017-06-24 13:46:46 +0200
committerJan Holesovsky <kendy@collabora.com>2017-09-06 19:30:05 +0200
commite36e716e877c707c991db7bad87724c4a20af27c (patch)
treedd48f35f3ae515314cb30da64e73889f731e5e07
parent24f04330cd789349ced8e7beeb6b007ec0d2d834 (diff)
Fix PageShape export to pptx
The export code is not called, because the PageShape is actually of type presentation.PageShape and not drawing.PageShape. A PageShape has no text at all, which results in an empty p:txBody element that fails validation, so it needs to be checked first if the shape actually has text. Change-Id: I559f15c2396739c74d5c4f36eb952754bc040ce8 Reviewed-on: https://gerrit.libreoffice.org/38574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-on: https://gerrit.libreoffice.org/42002 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 9d43654080fcc5942610f57cbfec9827b9da2102) Reviewed-on: https://gerrit.libreoffice.org/42018
-rw-r--r--oox/source/export/shapes.cxx3
1 files changed, 2 insertions, 1 deletions
diff --git a/oox/source/export/shapes.cxx b/oox/source/export/shapes.cxx
index 7bd85a8cd39f..1d4f4a20a217 100644
--- a/oox/source/export/shapes.cxx
+++ b/oox/source/export/shapes.cxx
@@ -1448,7 +1448,8 @@ ShapeExport& ShapeExport::WriteTextBox( const Reference< XInterface >& xIface, s
}
}
- if( NonEmptyText( xIface ) )
+ Reference< XText > xXText( xIface, UNO_QUERY );
+ if( NonEmptyText( xIface ) && xXText.is() )
{
FSHelperPtr pFS = GetFS();