Consistently let SetDesingMode functions take bool argument

...to avoid "warning C4805: '!=' : unsafe mix of type 'bool' and type 'sal_Bool'
in opertaion" style errors.  Additionally, mark those functions that are virtual
overrides as such.

Change-Id: I64f919f7e2d8f6224303f9bac67f6270d58de014

15 files changed, 17 insertions, 17 deletions

diff --git a/include/svx/fmgridcl.hxx b/include/svx/fmgridcl.hxx
index 306023cce240..62ef3aede68e 100644
--- a/include/svx/fmgridcl.hxx
+++ b/include/svx/fmgridcl.hxx
@@ -159,7 +159,7 @@ protected:
     virtual void ColumnResized(sal_uInt16 nId);
     virtual void ColumnMoved(sal_uInt16 nId);
     virtual void DeleteSelectedRows();
-    virtual void SetDesignMode(sal_Bool bMode);
+    virtual void SetDesignMode(bool bMode) SAL_OVERRIDE;
     virtual void CellModified();
     virtual void HideColumn(sal_uInt16 nId);
     virtual void ShowColumn(sal_uInt16 nId);
diff --git a/include/svx/fmshell.hxx b/include/svx/fmshell.hxx
index 42d204d888ad..f0e7eb52abf3 100644
--- a/include/svx/fmshell.hxx
+++ b/include/svx/fmshell.hxx
@@ -162,7 +162,7 @@ public:
             ) const;
 
     sal_Bool    IsDesignMode() const { return m_bDesignMode; }
-    void        SetDesignMode( sal_Bool _bDesignMode );
+    void        SetDesignMode( bool _bDesignMode );
 
 protected:
     void GetFormState(SfxItemSet &rSet, sal_uInt16 nWhich);
diff --git a/include/svx/gridctrl.hxx b/include/svx/gridctrl.hxx
index 673f60442a57..9c457b8ec818 100644
--- a/include/svx/gridctrl.hxx
+++ b/include/svx/gridctrl.hxx
@@ -419,7 +419,7 @@ public:
     sal_uInt16 GetColumnIdFromViewPos( sal_uInt16 nPos ) const { return GetColumnId(nPos + 1); }
     sal_uInt16 GetColumnIdFromModelPos( sal_uInt16 nPos ) const;
 
-    virtual void SetDesignMode(sal_Bool bMode);
+    virtual void SetDesignMode(bool bMode);
     sal_Bool IsDesignMode() const {return m_bDesignMode;}
     sal_Bool IsOpen() const {return m_pSeekCursor != NULL;}
 
diff --git a/include/svx/svdmrkv.hxx b/include/svx/svdmrkv.hxx
index e53bf1060215..30d589279594 100644
--- a/include/svx/svdmrkv.hxx
+++ b/include/svx/svdmrkv.hxx
@@ -222,7 +222,7 @@ public:
     void SetGluePointEditMode(sal_Bool bOn=sal_True) { SetEditMode(bOn?SDREDITMODE_GLUEPOINTEDIT:eEditMode0); }
     sal_Bool IsGluePointEditMode() const { return eEditMode==SDREDITMODE_GLUEPOINTEDIT; }
 
-    void SetDesignMode(sal_Bool bOn=sal_True);
+    void SetDesignMode(bool bOn = true);
     sal_Bool IsDesignMode() const { return bDesignMode; }
 
     void SetFrameDragSingles(sal_Bool bOn=sal_True) { SetFrameHandles(bOn); }
diff --git a/sc/source/ui/view/tabview5.cxx b/sc/source/ui/view/tabview5.cxx
index 681fcc62d68e..87933b426ba3 100644
--- a/sc/source/ui/view/tabview5.cxx
+++ b/sc/source/ui/view/tabview5.cxx
@@ -222,7 +222,7 @@ void ScTabView::MakeDrawView( sal_uInt8 nForceDesignMode )
         //  used when switching back from page preview: restore saved design mode state
         //  (otherwise, keep the default from the draw view ctor)
         if ( nForceDesignMode != SC_FORCEMODE_NONE )
-            pDrawView->SetDesignMode( (sal_Bool)nForceDesignMode );
+            pDrawView->SetDesignMode( nForceDesignMode );
 
         //  an der FormShell anmelden
         FmFormShell* pFormSh = aViewData.GetViewShell()->GetFormShell();
diff --git a/svx/source/fmcomp/fmgridcl.cxx b/svx/source/fmcomp/fmgridcl.cxx
index ac04ace27d1b..27b657c53a93 100644
--- a/svx/source/fmcomp/fmgridcl.cxx
+++ b/svx/source/fmcomp/fmgridcl.cxx
@@ -1068,7 +1068,7 @@ void FmGridControl::propertyChange(const ::com::sun::star::beans::PropertyChange
     }
 }
 
-void FmGridControl::SetDesignMode(sal_Bool bMode)
+void FmGridControl::SetDesignMode(bool bMode)
 {
     sal_Bool bOldMode = IsDesignMode();
     DbGridControl::SetDesignMode(bMode);
diff --git a/svx/source/fmcomp/gridctrl.cxx b/svx/source/fmcomp/gridctrl.cxx
index 4c7641bf98c8..07a41bee36dc 100644
--- a/svx/source/fmcomp/gridctrl.cxx
+++ b/svx/source/fmcomp/gridctrl.cxx
@@ -2537,7 +2537,7 @@ void DbGridControl::AppendNew()
         MoveToPosition(nNewRow - 1);
 }
 
-void DbGridControl::SetDesignMode(sal_Bool bMode)
+void DbGridControl::SetDesignMode(bool bMode)
 {
     if (IsDesignMode() != bMode)
     {
diff --git a/svx/source/form/fmshell.cxx b/svx/source/form/fmshell.cxx
index 40e1ba2e2bce..dcf8ce4bf0a0 100644
--- a/svx/source/form/fmshell.cxx
+++ b/svx/source/form/fmshell.cxx
@@ -1450,7 +1450,7 @@ Reference< runtime::XFormController > FmFormShell::GetFormController( const Refe
 }
 
 //------------------------------------------------------------------------
-void FmFormShell::SetDesignMode( sal_Bool _bDesignMode )
+void FmFormShell::SetDesignMode( bool _bDesignMode )
 {
     if ( _bDesignMode == m_bDesignMode )
         return;
diff --git a/svx/source/form/fmshimp.cxx b/svx/source/form/fmshimp.cxx
index 94d4c2e8fad7..1a8794d5f438 100644
--- a/svx/source/form/fmshimp.cxx
+++ b/svx/source/form/fmshimp.cxx
@@ -2799,7 +2799,7 @@ public:
 };
 
 //------------------------------------------------------------------------------
-void FmXFormShell::SetDesignMode(sal_Bool bDesign)
+void FmXFormShell::SetDesignMode(bool bDesign)
 {
     if ( impl_checkDisposed() )
         return;
diff --git a/svx/source/inc/fmshimp.hxx b/svx/source/inc/fmshimp.hxx
index 2eb41e98b962..e2036e719092 100644
--- a/svx/source/inc/fmshimp.hxx
+++ b/svx/source/inc/fmshimp.hxx
@@ -412,7 +412,7 @@ public:
     void SetSelection(const SdrMarkList& rMarkList);
     void SetSelectionDelayed();
 
-    void SetDesignMode(sal_Bool bDesign);
+    void SetDesignMode(bool bDesign);
 
     sal_Bool    GetWizardUsing() const { return m_bUseWizards; }
     void        SetWizardUsing(sal_Bool _bUseThem);
diff --git a/svx/source/svdraw/svdmrkv.cxx b/svx/source/svdraw/svdmrkv.cxx
index 4d24c6636e93..2124482569be 100644
--- a/svx/source/svdraw/svdmrkv.cxx
+++ b/svx/source/svdraw/svdmrkv.cxx
@@ -2117,7 +2117,7 @@ void SdrMarkView::SetMoveOutside(sal_Bool bOn)
     aHdl.SetMoveOutside(bOn);
 }
 
-void SdrMarkView::SetDesignMode( sal_Bool _bOn )
+void SdrMarkView::SetDesignMode( bool _bOn )
 {
     if ( bDesignMode != _bOn )
     {
diff --git a/svx/source/unodraw/unopage.cxx b/svx/source/unodraw/unopage.cxx
index 771f8e80b115..fbda90a097a7 100644
--- a/svx/source/unodraw/unopage.cxx
+++ b/svx/source/unodraw/unopage.cxx
@@ -75,7 +75,7 @@ SvxDrawPage::SvxDrawPage( SdrPage* pInPage ) throw()
     // Erzeugen der (hidden) ::com::sun::star::sdbcx::View
     mpView = new SdrView( mpModel );
     if( mpView )
-        mpView->SetDesignMode(sal_True);
+        mpView->SetDesignMode(true);
 }
 
 SvxDrawPage::~SvxDrawPage() throw()
@@ -848,7 +848,7 @@ void SvxDrawPage::ChangeModel( SdrModel* pNewModel )
             delete mpView;
             mpView = new SdrView( mpModel );
             if( mpView )
-                mpView->SetDesignMode(sal_True);
+                mpView->SetDesignMode(true);
         }
     }
 }
diff --git a/sw/source/core/frmedt/fecopy.cxx b/sw/source/core/frmedt/fecopy.cxx
index af1dc822f312..b9d5a65fb7c2 100644
--- a/sw/source/core/frmedt/fecopy.cxx
+++ b/sw/source/core/frmedt/fecopy.cxx
@@ -1504,7 +1504,7 @@ void SwFEShell::Paste( SvStream& rStrm, sal_uInt16 nAction, const Point* pPt )
 
         sal_Bool bDesignMode = pView->IsDesignMode();
         if( !bDesignMode )
-            pView->SetDesignMode( sal_True );
+            pView->SetDesignMode( true );
 
         // #i50824#
         // method <lcl_RemoveOleObjsFromSdrModel> replaced by <lcl_ConvertSdrOle2ObjsToSdrGrafObjs>
@@ -1537,7 +1537,7 @@ void SwFEShell::Paste( SvStream& rStrm, sal_uInt16 nAction, const Point* pPt )
             pView->MoveMarkedObj( aDiff );
             ImpEndCreate();
             if( !bDesignMode )
-                pView->SetDesignMode( sal_False );
+                pView->SetDesignMode( false );
         }
     }
     EndUndo();
diff --git a/sw/source/ui/ribbar/conform.cxx b/sw/source/ui/ribbar/conform.cxx
index d74065da9208..2b15f5f8e9e4 100644
--- a/sw/source/ui/ribbar/conform.cxx
+++ b/sw/source/ui/ribbar/conform.cxx
@@ -101,7 +101,7 @@ void ConstFormControl::CreateDefaultObject()
         m_pSh->MakeDrawView();
 
     SdrView *pSdrView = m_pSh->GetDrawView();
-    pSdrView->SetDesignMode(sal_True);
+    pSdrView->SetDesignMode(true);
     m_pSh->BeginCreate( static_cast< sal_uInt16 >(m_pWin->GetSdrDrawMode()), FmFormInventor, aStartPos);
     m_pSh->MoveCreate(aEndPos);
     m_pSh->EndCreate(SDRCREATE_FORCEEND);
diff --git a/sw/source/ui/shells/textdrw.cxx b/sw/source/ui/shells/textdrw.cxx
index 5b49b0e4597f..b99cadb63f7e 100644
--- a/sw/source/ui/shells/textdrw.cxx
+++ b/sw/source/ui/shells/textdrw.cxx
@@ -50,7 +50,7 @@ void SwBaseShell::InsertURLButton(const OUString& rURL, const OUString& rTarget,
     SdrView *pSdrView = rSh.GetDrawView();
 
     // OBJ_FM_BUTTON
-    pSdrView->SetDesignMode(sal_True);
+    pSdrView->SetDesignMode(true);
     pSdrView->SetCurrentObj(OBJ_FM_BUTTON);
     pSdrView->SetEditMode(sal_False);