diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-04-13 09:58:07 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-04-16 08:23:05 +0200 |
| commit | 96e5d09224d46641278d995dc5fd463fac3dfa75 (patch) | |
| tree | 23a7b2e92e39a699d206303f6c241da98f77d271 | |
| parent | 1e9101e7bd2d423416fcf1cb1c1b15a140aa12e6 (diff) | |
loplugin:useuniqueptr in ImplBorderWindow
Change-Id: Iabff2048cd3f990fe359b8a281a1eb3af2bb9c32
Reviewed-on: https://gerrit.libreoffice.org/52890
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
| -rw-r--r-- | vcl/inc/brdwin.hxx | 2 | ||||
| -rw-r--r-- | vcl/source/window/brdwin.cxx | 15 |
2 files changed, 8 insertions, 9 deletions
diff --git a/vcl/inc/brdwin.hxx b/vcl/inc/brdwin.hxx index 36292b21e963..8e3846a07c74 100644 --- a/vcl/inc/brdwin.hxx +++ b/vcl/inc/brdwin.hxx @@ -82,7 +82,7 @@ class ImplBorderWindow : public vcl::Window friend class ImplStdBorderWindowView; private: - ImplBorderWindowView* mpBorderView; + std::unique_ptr<ImplBorderWindowView> mpBorderView; VclPtr<vcl::Window> mpMenuBarWindow; VclPtr<NotebookBar> mpNotebookBar; long mnMinWidth; diff --git a/vcl/source/window/brdwin.cxx b/vcl/source/window/brdwin.cxx index 0b027196db8f..594b7471d038 100644 --- a/vcl/source/window/brdwin.cxx +++ b/vcl/source/window/brdwin.cxx @@ -1666,8 +1666,7 @@ ImplBorderWindow::~ImplBorderWindow() void ImplBorderWindow::dispose() { - delete mpBorderView; - mpBorderView = nullptr; + mpBorderView.reset(); mpMenuBarWindow.clear(); mpNotebookBar.disposeAndClear(); vcl::Window::dispose(); @@ -1834,18 +1833,18 @@ void ImplBorderWindow::DataChanged( const DataChangedEvent& rDCEvt ) void ImplBorderWindow::InitView() { if ( mbSmallOutBorder ) - mpBorderView = new ImplSmallBorderWindowView( this ); + mpBorderView.reset(new ImplSmallBorderWindowView( this )); else if ( mpWindowImpl->mbFrame ) { if( mbFrameBorder ) - mpBorderView = new ImplStdBorderWindowView( this ); + mpBorderView.reset(new ImplStdBorderWindowView( this )); else - mpBorderView = new ImplNoBorderWindowView; + mpBorderView.reset(new ImplNoBorderWindowView); } else if ( !mbFrameBorder ) - mpBorderView = new ImplSmallBorderWindowView( this ); + mpBorderView.reset(new ImplSmallBorderWindowView( this )); else - mpBorderView = new ImplStdBorderWindowView( this ); + mpBorderView.reset(new ImplStdBorderWindowView( this )); Size aSize = GetOutputSizePixel(); mpBorderView->Init( this, aSize.Width(), aSize.Height() ); } @@ -1861,7 +1860,7 @@ void ImplBorderWindow::UpdateView( bool bNewView, const Size& rNewOutSize ) if ( bNewView ) { - delete mpBorderView; + mpBorderView.reset(); InitView(); } else |