diff options
| author | Takeshi Abe <tabe@fixedpoint.jp> | 2018-04-05 00:39:05 +0900 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-04-06 06:35:02 +0200 |
| commit | 786a1c8ef1d182e63a7ae8cfd526ae101bad232b (patch) | |
| tree | 291867a65d2342f0d73316377a7b14c758463b91 | |
| parent | 8d6e498a11024ca3cf70864250a757e0d5a7b166 (diff) | |
fflush() followed by fclose() is redundant
Change-Id: Iacb9332635cb6afa90ec1a72e96388b3b5b7b56c
Reviewed-on: https://gerrit.libreoffice.org/52420
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
| -rw-r--r-- | idlc/source/idlccompile.cxx | 3 | ||||
| -rw-r--r-- | sal/osl/unx/backtrace.c | 3 | ||||
| -rw-r--r-- | xmlscript/test/imexp.cxx | 1 |
3 files changed, 1 insertions, 6 deletions
diff --git a/idlc/source/idlccompile.cxx b/idlc/source/idlccompile.cxx index c7e69362ec8a..ca6a8ebeb10a 100644 --- a/idlc/source/idlccompile.cxx +++ b/idlc/source/idlccompile.cxx @@ -202,9 +202,8 @@ bool copyFile(const OString* source, const OString& target) if (source != nullptr) { fclose(pSource); } - if ( fflush(pTarget) ) + if ( fclose(pTarget) ) bRet = false; - fclose(pTarget); return bRet; } diff --git a/sal/osl/unx/backtrace.c b/sal/osl/unx/backtrace.c index f70031d0b4a9..a3aeb3dae3f8 100644 --- a/sal/osl/unx/backtrace.c +++ b/sal/osl/unx/backtrace.c @@ -129,7 +129,6 @@ void backtrace_symbols_fd( void **buffer, int size, int fd ) fprintf( fp, "[%p]\n", *pFramePtr ); } - fflush( fp ); fclose( fp ); } } @@ -209,7 +208,6 @@ void backtrace_symbols_fd( void **buffer, int size, int fd ) } fprintf( fp, "[%p]\n", *pFramePtr ); } - fflush( fp ); fclose( fp ); } } @@ -277,7 +275,6 @@ void backtrace_symbols_fd( void **buffer, int size, int fd ) fprintf( fp, "[%p]\n", *pFramePtr ); } - fflush( fp ); fclose( fp ); } } diff --git a/xmlscript/test/imexp.cxx b/xmlscript/test/imexp.cxx index e275179beef1..0e4a80b516d5 100644 --- a/xmlscript/test/imexp.cxx +++ b/xmlscript/test/imexp.cxx @@ -131,7 +131,6 @@ void exportToFile( FILE * f = ::fopen( fname, "w" ); ::fwrite( bytes.getConstArray(), 1, bytes.getLength(), f ); - ::fflush( f ); ::fclose( f ); } |