summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNoel Grandin <noel@peralex.com>2016-04-13 14:42:54 +0200
committerNoel Grandin <noel@peralex.com>2016-04-14 09:21:39 +0200
commit868444c803a3ba197068d487d3507089cc1e9afa (patch)
tree1510bdac1c102d152b444ea582c4870708dc2b45
parentf34cc90df9e6e7bc7d58a4ed4be71a63f0ec5ae4 (diff)
loplugin:passstuffbyref in xmloff
Change-Id: I5995510c5c0686e5e69e8853d81dcba83ae96211
-rw-r--r--include/xmloff/XMLTextMasterPageContext.hxx2
-rw-r--r--include/xmloff/shapeexport.hxx4
-rw-r--r--include/xmloff/table/XMLTableImport.hxx6
-rw-r--r--include/xmloff/txtparae.hxx14
-rw-r--r--include/xmloff/xmlexp.hxx6
-rw-r--r--include/xmloff/xmlimp.hxx2
-rw-r--r--xmloff/inc/txtfldi.hxx2
-rw-r--r--xmloff/inc/txtvfldi.hxx2
-rw-r--r--xmloff/source/chart/SchXMLExport.cxx4
-rw-r--r--xmloff/source/draw/sdxmlimp_impl.hxx2
-rw-r--r--xmloff/source/transform/PersAttrListTContext.hxx2
-rw-r--r--xmloff/source/xforms/XFormsModelContext.hxx2
12 files changed, 24 insertions, 24 deletions
diff --git a/include/xmloff/XMLTextMasterPageContext.hxx b/include/xmloff/XMLTextMasterPageContext.hxx
index 56d099eec9c1..562174f0f8ac 100644
--- a/include/xmloff/XMLTextMasterPageContext.hxx
+++ b/include/xmloff/XMLTextMasterPageContext.hxx
@@ -53,7 +53,7 @@ class XMLOFF_DLLPUBLIC XMLTextMasterPageContext : public SvXMLStyleContext
SAL_DLLPRIVATE css::uno::Reference< css::style::XStyle > Create();
protected:
- css::uno::Reference< css::style::XStyle > GetStyle() { return xStyle; }
+ const css::uno::Reference< css::style::XStyle >& GetStyle() { return xStyle; }
public:
diff --git a/include/xmloff/shapeexport.hxx b/include/xmloff/shapeexport.hxx
index 97699b86ca14..70cc92378100 100644
--- a/include/xmloff/shapeexport.hxx
+++ b/include/xmloff/shapeexport.hxx
@@ -180,7 +180,7 @@ protected:
const SvXMLExport& GetExport() const { return mrExport; }
private:
- SAL_DLLPRIVATE rtl::Reference< SvXMLExportPropertyMapper > GetPropertySetMapper() const { return mxPropertySetMapper; }
+ SAL_DLLPRIVATE const rtl::Reference< SvXMLExportPropertyMapper >& GetPropertySetMapper() const { return mxPropertySetMapper; }
const OUString msZIndex;
const OUString msPrintable;
@@ -291,7 +291,7 @@ public:
void setAnimationsExporter( rtl::Reference< XMLAnimationsExporter > xAnimExport ) { mxAnimationsExporter = xAnimExport; }
/** returns the last set XMLAnimationExport */
- rtl::Reference< XMLAnimationsExporter > getAnimationsExporter() const { return mxAnimationsExporter; }
+ const rtl::Reference< XMLAnimationsExporter >& getAnimationsExporter() const { return mxAnimationsExporter; }
/// returns the export property mapper for external chaining
static SvXMLExportPropertyMapper* CreateShapePropMapper( SvXMLExport& rExport );
diff --git a/include/xmloff/table/XMLTableImport.hxx b/include/xmloff/table/XMLTableImport.hxx
index 81052c7c58c7..7f8a56851890 100644
--- a/include/xmloff/table/XMLTableImport.hxx
+++ b/include/xmloff/table/XMLTableImport.hxx
@@ -51,9 +51,9 @@ public:
SvXMLStyleContext* CreateTableTemplateContext( sal_uInt16 nPrfx, const OUString& rLName, const css::uno::Reference< css::xml::sax::XAttributeList >& xAttrList );
- rtl::Reference< SvXMLImportPropertyMapper > GetCellImportPropertySetMapper() const { return mxCellImportPropertySetMapper; }
- rtl::Reference< SvXMLImportPropertyMapper > GetRowImportPropertySetMapper() const { return mxRowImportPropertySetMapper; }
- rtl::Reference< SvXMLImportPropertyMapper > GetColumnImportPropertySetMapper() const { return mxColumnImportPropertySetMapper; }
+ const rtl::Reference< SvXMLImportPropertyMapper >& GetCellImportPropertySetMapper() const { return mxCellImportPropertySetMapper; }
+ const rtl::Reference< SvXMLImportPropertyMapper >& GetRowImportPropertySetMapper() const { return mxRowImportPropertySetMapper; }
+ const rtl::Reference< SvXMLImportPropertyMapper >& GetColumnImportPropertySetMapper() const { return mxColumnImportPropertySetMapper; }
void addTableTemplate( const OUString& rsStyleName, XMLTableTemplate& xTableTemplate );
void finishStyles();
diff --git a/include/xmloff/txtparae.hxx b/include/xmloff/txtparae.hxx
index 5d1cfcf54162..5e445bd0da09 100644
--- a/include/xmloff/txtparae.hxx
+++ b/include/xmloff/txtparae.hxx
@@ -208,29 +208,29 @@ protected:
const SvXMLAutoStylePoolP& GetAutoStylePool() const { return rAutoStylePool; }
public:
- rtl::Reference < SvXMLExportPropertyMapper > GetParaPropMapper() const
+ const rtl::Reference < SvXMLExportPropertyMapper >& GetParaPropMapper() const
{
return xParaPropMapper;
}
- rtl::Reference < SvXMLExportPropertyMapper > GetTextPropMapper() const
+ const rtl::Reference < SvXMLExportPropertyMapper >& GetTextPropMapper() const
{
return xTextPropMapper;
}
- rtl::Reference < SvXMLExportPropertyMapper > GetFramePropMapper() const
+ const rtl::Reference < SvXMLExportPropertyMapper >& GetFramePropMapper() const
{
return xFramePropMapper;
}
- rtl::Reference < SvXMLExportPropertyMapper > GetAutoFramePropMapper() const
+ const rtl::Reference < SvXMLExportPropertyMapper >& GetAutoFramePropMapper() const
{
return xAutoFramePropMapper;
}
- rtl::Reference < SvXMLExportPropertyMapper > GetSectionPropMapper() const
+ const rtl::Reference < SvXMLExportPropertyMapper >& GetSectionPropMapper() const
{
return xSectionPropMapper;
}
- rtl::Reference < SvXMLExportPropertyMapper > GetRubyPropMapper() const
+ const rtl::Reference < SvXMLExportPropertyMapper >& GetRubyPropMapper() const
{
return xRubyPropMapper;
}
@@ -565,7 +565,7 @@ public:
bool IsBlockMode() const { return bBlock; }
- rtl::Reference < SvXMLExportPropertyMapper > GetParagraphPropertyMapper() const
+ const rtl::Reference < SvXMLExportPropertyMapper >& GetParagraphPropertyMapper() const
{
return xParaPropMapper;
}
diff --git a/include/xmloff/xmlexp.hxx b/include/xmloff/xmlexp.hxx
index 6240cb7a9f3d..41e8ddd8d417 100644
--- a/include/xmloff/xmlexp.hxx
+++ b/include/xmloff/xmlexp.hxx
@@ -455,9 +455,9 @@ public:
inline bool HasFormExport();
// get XPropertySet with export information
- inline css::uno::Reference< css::beans::XPropertySet > getExportInfo() const { return mxExportInfo; }
+ const css::uno::Reference< css::beans::XPropertySet >& getExportInfo() const { return mxExportInfo; }
- css::uno::Reference< css::task::XStatusIndicator > GetStatusIndicator() { return mxStatusIndicator; }
+ const css::uno::Reference< css::task::XStatusIndicator >& GetStatusIndicator() { return mxStatusIndicator; }
/// get Event export, with handlers for script types "None" and
/// "StarBasic" already registered; other handlers may be registered, too.
@@ -530,7 +530,7 @@ public:
::comphelper::UnoInterfaceToUniqueIdentifierMapper& getInterfaceToIdentifierMapper();
- css::uno::Reference< css::uno::XComponentContext > getComponentContext() { return m_xContext;}
+ const css::uno::Reference< css::uno::XComponentContext >& getComponentContext() { return m_xContext;}
// Shapes in Writer cannot be named via context menu (#i51726#)
SvtModuleOptions::EFactory GetModelType() const
diff --git a/include/xmloff/xmlimp.hxx b/include/xmloff/xmlimp.hxx
index 5eda0d44bb5a..2261e4759d67 100644
--- a/include/xmloff/xmlimp.hxx
+++ b/include/xmloff/xmlimp.hxx
@@ -310,7 +310,7 @@ public:
inline rtl::Reference< ::xmloff::OFormLayerXMLImport > GetFormImport();
// get XPropertySet with import information
- inline css::uno::Reference< css::beans::XPropertySet > getImportInfo() const { return mxImportInfo; }
+ const css::uno::Reference< css::beans::XPropertySet >& getImportInfo() const { return mxImportInfo; }
// get import helper for events
XMLEventImportHelper& GetEventImport();
diff --git a/xmloff/inc/txtfldi.hxx b/xmloff/inc/txtfldi.hxx
index 4b3554103e0c..670e6d6c356c 100644
--- a/xmloff/inc/txtfldi.hxx
+++ b/xmloff/inc/txtfldi.hxx
@@ -157,7 +157,7 @@ protected:
/// get helper
inline XMLTextImportHelper& GetImportHelper() { return rTextImportHelper; }
- inline OUString GetServiceName() { return sServiceName; }
+ const OUString& GetServiceName() { return sServiceName; }
inline void SetServiceName(const OUString& sStr) { sServiceName = sStr; }
OUString GetContent();
diff --git a/xmloff/inc/txtvfldi.hxx b/xmloff/inc/txtvfldi.hxx
index 1d3807980b4c..a92f6bc53980 100644
--- a/xmloff/inc/txtvfldi.hxx
+++ b/xmloff/inc/txtvfldi.hxx
@@ -188,7 +188,7 @@ protected:
css::beans::XPropertySet> & xPropertySet) override;
// various accessor methods:
- inline OUString GetName() { return sName; }
+ const OUString& GetName() { return sName; }
inline bool IsStringValue() { return aValueHelper.IsStringValue();}
};
diff --git a/xmloff/source/chart/SchXMLExport.cxx b/xmloff/source/chart/SchXMLExport.cxx
index c64ef59e6488..a45784ff2fcf 100644
--- a/xmloff/source/chart/SchXMLExport.cxx
+++ b/xmloff/source/chart/SchXMLExport.cxx
@@ -155,7 +155,7 @@ public:
void exportChart( css::uno::Reference< css::chart::XChartDocument > rChartDoc,
bool bIncludeTable );
- rtl::Reference<XMLPropertySetMapper> GetPropertySetMapper() const;
+ const rtl::Reference<XMLPropertySetMapper>& GetPropertySetMapper() const;
void SetChartRangeAddress( const OUString& rAddress )
{ msChartAddress = rAddress; }
@@ -993,7 +993,7 @@ void SchXMLExportHelper::SetDestinationShellID( const OUString& rShellID )
m_pImpl->maDestShellID = rShellID;
}
-rtl::Reference< XMLPropertySetMapper > SchXMLExportHelper_Impl::GetPropertySetMapper() const
+const rtl::Reference< XMLPropertySetMapper >& SchXMLExportHelper_Impl::GetPropertySetMapper() const
{
return mxPropertySetMapper;
}
diff --git a/xmloff/source/draw/sdxmlimp_impl.hxx b/xmloff/source/draw/sdxmlimp_impl.hxx
index ccda6f1099db..7250eb6ec250 100644
--- a/xmloff/source/draw/sdxmlimp_impl.hxx
+++ b/xmloff/source/draw/sdxmlimp_impl.hxx
@@ -260,7 +260,7 @@ public:
sal_Int32 GetNewMasterPageCount() const { return mnNewMasterPageCount; }
void IncrementNewMasterPageCount() { mnNewMasterPageCount++; }
- css::uno::Reference< css::container::XNameAccess > getPageLayouts() const { return mxPageLayouts; }
+ const css::uno::Reference< css::container::XNameAccess >& getPageLayouts() const { return mxPageLayouts; }
bool IsDraw() const { return mbIsDraw; }
bool IsImpress() const { return !mbIsDraw; }
diff --git a/xmloff/source/transform/PersAttrListTContext.hxx b/xmloff/source/transform/PersAttrListTContext.hxx
index e47fb3377491..d93455ff0069 100644
--- a/xmloff/source/transform/PersAttrListTContext.hxx
+++ b/xmloff/source/transform/PersAttrListTContext.hxx
@@ -102,7 +102,7 @@ public:
::xmloff::token::XMLTokenEnum eAToken,
const OUString & rValue );
- css::uno::Reference< css::xml::sax::XAttributeList >
+ const css::uno::Reference< css::xml::sax::XAttributeList >&
GetAttrList() const { return m_xAttrList; }
};
diff --git a/xmloff/source/xforms/XFormsModelContext.hxx b/xmloff/source/xforms/XFormsModelContext.hxx
index 2ec6bcb0e878..b71baad466c6 100644
--- a/xmloff/source/xforms/XFormsModelContext.hxx
+++ b/xmloff/source/xforms/XFormsModelContext.hxx
@@ -43,7 +43,7 @@ public:
const OUString& rLName );
virtual ~XFormsModelContext();
- css::uno::Reference<css::xforms::XModel2> getModel() { return mxModel;}
+ const css::uno::Reference<css::xforms::XModel2>& getModel() { return mxModel;}
// implement SvXMLImportContext & TokenContext methods: