loplugin:constantparam in vcl

Change-Id: I1618280494ff10d884a3285501303c6a74ef3542
Reviewed-on: https://gerrit.libreoffice.org/50951
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

21 files changed, 38 insertions, 102 deletions

diff --git a/filter/source/pdf/impdialog.cxx b/filter/source/pdf/impdialog.cxx
index 1f65e3bad4b5..65579a7fd87c 100644
--- a/filter/source/pdf/impdialog.cxx
+++ b/filter/source/pdf/impdialog.cxx
@@ -1345,7 +1345,7 @@ IMPL_LINK_NOARG(ImpPDFTabSecurityPage, ClickmaPbSetPwdHdl, Button*, void)
         mbHaveUserPassword = !aUserPW.isEmpty();
         mbHaveOwnerPassword = !aOwnerPW.isEmpty();
 
-        mxPreparedPasswords = vcl::PDFWriter::InitEncryption( aOwnerPW, aUserPW, true );
+        mxPreparedPasswords = vcl::PDFWriter::InitEncryption( aOwnerPW, aUserPW );
 
         if( mbHaveOwnerPassword )
         {
diff --git a/filter/source/pdf/pdfexport.cxx b/filter/source/pdf/pdfexport.cxx
index ab7457350f85..f6e87b717178 100644
--- a/filter/source/pdf/pdfexport.cxx
+++ b/filter/source/pdf/pdfexport.cxx
@@ -697,7 +697,7 @@ bool PDFExport::Export( const OUString& rFile, const Sequence< PropertyValue >&
                 aContext.Encryption.CanCopyOrExtract                = mbCanCopyOrExtract;
                 aContext.Encryption.CanExtractForAccessibility  = mbCanExtractForAccessibility;
                 if( mbEncrypt && ! xEnc.is() )
-                    xEnc = vcl::PDFWriter::InitEncryption( aPermissionPassword, aOpenPassword, true/*bSecurity128bit*/ );
+                    xEnc = vcl::PDFWriter::InitEncryption( aPermissionPassword, aOpenPassword );
                 if( mbEncrypt && !aPermissionPassword.isEmpty() && ! aPreparedPermissionPassword.getLength() )
                     aPreparedPermissionPassword = comphelper::OStorageHelper::CreatePackageEncryptionData( aPermissionPassword );
             }
diff --git a/include/vcl/bitmapex.hxx b/include/vcl/bitmapex.hxx
index ce45c0a6891f..c596a71a17a3 100644
--- a/include/vcl/bitmapex.hxx
+++ b/include/vcl/bitmapex.hxx
@@ -302,8 +302,7 @@ public:
     void                Replace(
                             const Color* pSearchColors,
                             const Color* pReplaceColors,
-                            sal_uLong nColorCount,
-                            const sal_uInt8* pTols = nullptr );
+                            sal_uLong nColorCount );
 
     /** Change various global color characteristics
 
diff --git a/include/vcl/dibtools.hxx b/include/vcl/dibtools.hxx
index f56ee96bd4e4..02c356b5cca8 100644
--- a/include/vcl/dibtools.hxx
+++ b/include/vcl/dibtools.hxx
@@ -60,11 +60,10 @@ bool VCL_DLLPUBLIC WriteDIB( // WriteDIB(rBitmap, rOStm, false, true);
     bool bCompressed,
     bool bFileHeader);
 
+// compressed, with file header
 bool VCL_DLLPUBLIC WriteDIB( // WriteDIB(rBitmap, rOStm, false, true);
     const BitmapEx& rSource,
-    SvStream& rOStm,
-    bool bCompressed,
-    bool bFileHeader);
+    SvStream& rOStm);
 
 bool VCL_DLLPUBLIC WriteDIBBitmapEx(
     const BitmapEx& rSource,
diff --git a/include/vcl/opengl/OpenGLHelper.hxx b/include/vcl/opengl/OpenGLHelper.hxx
index 23b9b79a361c..ab3eca6d3acf 100644
--- a/include/vcl/opengl/OpenGLHelper.hxx
+++ b/include/vcl/opengl/OpenGLHelper.hxx
@@ -56,10 +56,8 @@ public:
     /**
      * The caller is responsible for allocate the memory for the RGBA buffer, before call
      * this method. RGBA buffer size is assumed to be 4*width*height.
-     * Since OpenGL uses textures flipped relative to BitmapEx storage this method
-     * also adds the possibility to mirror the bitmap vertically at the same time.
     **/
-    static void ConvertBitmapExToRGBATextureBuffer(const BitmapEx& rBitmapEx, sal_uInt8* o_pRGBABuffer, const bool bFlip = false);
+    static void ConvertBitmapExToRGBATextureBuffer(const BitmapEx& rBitmapEx, sal_uInt8* o_pRGBABuffer);
     static BitmapEx ConvertBGRABufferToBitmapEx(const sal_uInt8* const pBuffer, long nWidth, long nHeight);
     static void renderToFile(long nWidth, long nHeight, const OUString& rFileName);
 
diff --git a/include/vcl/pdfwriter.hxx b/include/vcl/pdfwriter.hxx
index 1db80a5b6da1..758acdb1f08d 100644
--- a/include/vcl/pdfwriter.hxx
+++ b/include/vcl/pdfwriter.hxx
@@ -723,10 +723,10 @@ The following structure describes the permissions used in PDF security
      */
     std::set< ErrorCode > const & GetErrors();
 
+    // uses 128bit encryption
     static css::uno::Reference< css::beans::XMaterialHolder >
            InitEncryption( const OUString& i_rOwnerPassword,
-                           const OUString& i_rUserPassword,
-                           bool b128Bit
+                           const OUString& i_rUserPassword
                          );
 
     /* functions for graphics state */
diff --git a/include/vcl/svapp.hxx b/include/vcl/svapp.hxx
index d9daba3154a8..98c123e217b5 100644
--- a/include/vcl/svapp.hxx
+++ b/include/vcl/svapp.hxx
@@ -716,13 +716,12 @@ public:
 
     /** Send event to all VCL application event listeners
 
-     @param     nEvent          Event ID
      @param     pWin            Pointer to window to send event
      @param     pData           Pointer to data to send with event
 
      @see ImplCallEventListeners(VclSimpleEvent* pEvent)
     */
-    static void                 ImplCallEventListeners( VclEventId nEvent, void* pData );
+    static void                 ImplCallEventListenersApplicationDataChanged( void* pData );
 
     /** Send event to all VCL application event listeners
 
diff --git a/lotuswordpro/source/filter/lwpbackgroundstuff.cxx b/lotuswordpro/source/filter/lwpbackgroundstuff.cxx
index 3120e3927bb7..4bce3d669545 100644
--- a/lotuswordpro/source/filter/lwpbackgroundstuff.cxx
+++ b/lotuswordpro/source/filter/lwpbackgroundstuff.cxx
@@ -145,7 +145,7 @@ std::unique_ptr<XFBGImage> LwpBackgroundStuff::GetFillPattern()
     // transfer image data from XOBitmap->SvStream->BYTE-Array
     SvMemoryStream aPicMemStream;
     aXOBitmap.Array2Bitmap();
-    WriteDIB(aXOBitmap.GetBitmap(), aPicMemStream, true, true);
+    WriteDIB(aXOBitmap.GetBitmap(), aPicMemStream);
     sal_uInt32 nSize = aPicMemStream.GetEndOfData();
     sal_uInt8* pImageBuff = new sal_uInt8 [nSize];
     memcpy(pImageBuff, aPicMemStream.GetData(), nSize);
diff --git a/vcl/inc/sft.hxx b/vcl/inc/sft.hxx
index e184ff164291..1888f8bf79f6 100644
--- a/vcl/inc/sft.hxx
+++ b/vcl/inc/sft.hxx
@@ -339,9 +339,6 @@ namespace vcl
  *                    the glyphID glyphArray[i]. Character code 0 usually points to a default
  *                    glyph (glyphID 0)
  * @param nGlyphs     number of glyph IDs in glyphArray and encoding values in encoding
- * @param nNameRecs   number of NameRecords for the font, if 0 the name table from the
- *                    original font will be used
- * @param nr          array of NameRecords
  * @param flags       or'ed TTCreationFlags
  * @return            return the value of SFErrCodes enum
  * @see               SFErrCodes
@@ -352,9 +349,7 @@ namespace vcl
                               const char    *fname,
                               sal_uInt16 const *glyphArray,
                               sal_uInt8 const *encoding,
-                              int            nGlyphs,
-                              int            nNameRecs,
-                              NameRecord const *nr);
+                              int            nGlyphs);
 
 /**
  * Generates a new PostScript Type42 font and dumps it to <b>outf</b> file.
diff --git a/vcl/quartz/salgdicommon.cxx b/vcl/quartz/salgdicommon.cxx
index bbac31eb1f65..76644b4f0a11 100644
--- a/vcl/quartz/salgdicommon.cxx
+++ b/vcl/quartz/salgdicommon.cxx
@@ -318,7 +318,7 @@ bool AquaSalGraphics::CreateFontSubset( const OUString& rToFile,
 
     // write subset into destination file
     nRC = ::CreateTTFromTTGlyphs( pSftFont, aToFile.getStr(), aShortIDs,
-                                  aTempEncs, nGlyphCount, 0, nullptr );
+                                  aTempEncs, nGlyphCount );
     ::CloseTTFont(pSftFont);
     return (nRC == SF_OK);
 }
diff --git a/vcl/source/app/svapp.cxx b/vcl/source/app/svapp.cxx
index 4543b6835fb7..10d4326228cc 100644
--- a/vcl/source/app/svapp.cxx
+++ b/vcl/source/app/svapp.cxx
@@ -660,7 +660,7 @@ void Application::SetSettings( const AllSettings& rSettings )
             DataChangedEvent aDCEvt( DataChangedEventType::SETTINGS, &aOldSettings, nChangeFlags );
 
             // notify data change handler
-            ImplCallEventListeners( VclEventId::ApplicationDataChanged, &aDCEvt);
+            ImplCallEventListenersApplicationDataChanged( &aDCEvt);
 
             // Update all windows
             vcl::Window* pFirstFrame = pSVData->maWinData.mpFirstFrame;
@@ -775,10 +775,10 @@ void Application::NotifyAllWindows( DataChangedEvent& rDCEvt )
     }
 }
 
-void Application::ImplCallEventListeners( VclEventId nEvent, void* pData )
+void Application::ImplCallEventListenersApplicationDataChanged( void* pData )
 {
     ImplSVData* pSVData = ImplGetSVData();
-    VclWindowEvent aEvent( nullptr, nEvent, pData );
+    VclWindowEvent aEvent( nullptr, VclEventId::ApplicationDataChanged, pData );
 
     if ( pSVData->maAppData.mpEventListeners )
         pSVData->maAppData.mpEventListeners->Call( aEvent );
diff --git a/vcl/source/fontsubset/sft.cxx b/vcl/source/fontsubset/sft.cxx
index 7449725b4ac1..bcb1ba251132 100644
--- a/vcl/source/fontsubset/sft.cxx
+++ b/vcl/source/fontsubset/sft.cxx
@@ -1911,9 +1911,7 @@ int  CreateTTFromTTGlyphs(TrueTypeFont  *ttf,
                           const char    *fname,
                           sal_uInt16 const *glyphArray,
                           sal_uInt8 const *encoding,
-                          int            nGlyphs,
-                          int            nNameRecs,
-                          NameRecord const *nr)
+                          int            nGlyphs)
 {
     TrueTypeCreator *ttcr;
     TrueTypeTable *head=nullptr, *hhea=nullptr, *maxp=nullptr, *cvt=nullptr, *prep=nullptr, *glyf=nullptr, *fpgm=nullptr, *cmap=nullptr, *name=nullptr, *post = nullptr, *os2 = nullptr;
@@ -1924,14 +1922,10 @@ int  CreateTTFromTTGlyphs(TrueTypeFont  *ttf,
 
     /**                       name                         **/
 
-    if (nNameRecs == 0) {
-        NameRecord *names;
-        int n = GetTTNameRecords(ttf, &names);
-        name = TrueTypeTableNew_name(n, names);
-        DisposeNameRecords(names, n);
-    } else {
-        name = TrueTypeTableNew_name(nNameRecs, nr);
-    }
+    NameRecord *names;
+    int n = GetTTNameRecords(ttf, &names);
+    name = TrueTypeTableNew_name(n, names);
+    DisposeNameRecords(names, n);
 
     /**                       maxp                         **/
     maxp = TrueTypeTableNew_maxp(getTable(ttf, O_maxp), getTableSize(ttf, O_maxp));
diff --git a/vcl/source/gdi/bitmapex.cxx b/vcl/source/gdi/bitmapex.cxx
index ea883d0be6eb..83cf57c8083b 100644
--- a/vcl/source/gdi/bitmapex.cxx
+++ b/vcl/source/gdi/bitmapex.cxx
@@ -615,10 +615,10 @@ void BitmapEx::Replace( const Color& rSearchColor, const Color& rReplaceColor )
         aBitmap.Replace( rSearchColor, rReplaceColor );
 }
 
-void BitmapEx::Replace( const Color* pSearchColors, const Color* pReplaceColors, sal_uLong nColorCount, const sal_uInt8* pTols )
+void BitmapEx::Replace( const Color* pSearchColors, const Color* pReplaceColors, sal_uLong nColorCount )
 {
     if (!!aBitmap)
-        aBitmap.Replace( pSearchColors, pReplaceColors, nColorCount, pTols );
+        aBitmap.Replace( pSearchColors, pReplaceColors, nColorCount, /*pTols*/nullptr );
 }
 
 bool BitmapEx::Adjust( short nLuminancePercent, short nContrastPercent,
diff --git a/vcl/source/gdi/dibtools.cxx b/vcl/source/gdi/dibtools.cxx
index 95c07b589d8d..810fa381b4d5 100644
--- a/vcl/source/gdi/dibtools.cxx
+++ b/vcl/source/gdi/dibtools.cxx
@@ -1608,10 +1608,10 @@ bool ImplWriteDIBBody(const Bitmap& rBitmap, SvStream& rOStm, BitmapReadAccess c
     return bRet;
 }
 
-bool ImplWriteDIBFileHeader(SvStream& rOStm, BitmapReadAccess const & rAcc, bool bUseDIBV5)
+bool ImplWriteDIBFileHeader(SvStream& rOStm, BitmapReadAccess const & rAcc)
 {
     const sal_uInt32 nPalCount((rAcc.HasPalette() ? rAcc.GetPaletteEntryCount() : isBitfieldCompression(rAcc.GetScanlineFormat()) ? 3UL : 0UL));
-    const sal_uInt32 nOffset(14 + (bUseDIBV5 ? DIBV5HEADERSIZE : DIBINFOHEADERSIZE) + nPalCount * 4UL);
+    const sal_uInt32 nOffset(14 + DIBINFOHEADERSIZE + nPalCount * 4UL);
 
     rOStm.WriteUInt16( 0x4D42 ); // 'MB' from BITMAPFILEHEADER
     rOStm.WriteUInt32( nOffset + (rAcc.Height() * rAcc.GetScanlineSize()) );
@@ -1686,7 +1686,7 @@ bool ImplWriteDIB(
         {
             if(bFileHeader)
             {
-                if(ImplWriteDIBFileHeader(rOStm, *pAcc, false))
+                if(ImplWriteDIBFileHeader(rOStm, *pAcc))
                 {
                     bRet = ImplWriteDIBBody(rSource, rOStm, *pAcc, pAccAlpha.get(), bCompressed);
                 }
@@ -1829,11 +1829,9 @@ bool WriteDIB(
 
 bool WriteDIB(
     const BitmapEx& rSource,
-    SvStream& rOStm,
-    bool bCompressed,
-    bool bFileHeader)
+    SvStream& rOStm)
 {
-    return ImplWriteDIB(rSource.GetBitmapRef(), rOStm, bCompressed, bFileHeader);
+    return ImplWriteDIB(rSource.GetBitmapRef(), rOStm, /*bCompressed*/true, /*bFileHeader*/true);
 }
 
 bool WriteDIBBitmapEx(
diff --git a/vcl/source/gdi/gdimtf.cxx b/vcl/source/gdi/gdimtf.cxx
index 42bad03edd9e..84c0586da8e3 100644
--- a/vcl/source/gdi/gdimtf.cxx
+++ b/vcl/source/gdi/gdimtf.cxx
@@ -1814,7 +1814,7 @@ BitmapEx GDIMetaFile::ImplBmpReplaceFnc( const BitmapEx& rBmpEx, const void* pBm
     const ImplBmpReplaceParam*  p = static_cast<const ImplBmpReplaceParam*>(pBmpParam);
     BitmapEx                    aRet( rBmpEx );
 
-    aRet.Replace( p->pSrcCols, p->pDstCols, p->nCount, nullptr );
+    aRet.Replace( p->pSrcCols, p->pDstCols, p->nCount );
 
     return aRet;
 }
diff --git a/vcl/source/gdi/pdfwriter.cxx b/vcl/source/gdi/pdfwriter.cxx
index 3b9dc7f65c99..e5899449d82f 100644
--- a/vcl/source/gdi/pdfwriter.cxx
+++ b/vcl/source/gdi/pdfwriter.cxx
@@ -464,11 +464,10 @@ std::set< PDFWriter::ErrorCode > const & PDFWriter::GetErrors()
 
 css::uno::Reference< css::beans::XMaterialHolder >
 PDFWriter::InitEncryption( const OUString& i_rOwnerPassword,
-                           const OUString& i_rUserPassword,
-                           bool b128Bit
+                           const OUString& i_rUserPassword
                           )
 {
-    return PDFWriterImpl::initEncryption( i_rOwnerPassword, i_rUserPassword, b128Bit );
+    return PDFWriterImpl::initEncryption( i_rOwnerPassword, i_rUserPassword, /*b128Bit*/true );
 }
 
 void PDFWriter::PlayMetafile( const GDIMetaFile& i_rMTF, const vcl::PDFWriter::PlayMetafileContext& i_rPlayContext, PDFExtOutDevData* i_pData )
diff --git a/vcl/source/opengl/OpenGLHelper.cxx b/vcl/source/opengl/OpenGLHelper.cxx
index a25a0b1e781e..43038867f7e5 100644
--- a/vcl/source/opengl/OpenGLHelper.cxx
+++ b/vcl/source/opengl/OpenGLHelper.cxx
@@ -533,7 +533,7 @@ GLint OpenGLHelper::LoadShaders(const OUString& rVertexShaderName,
     return LoadShaders(rVertexShaderName, rFragmentShaderName, OUString(), "", "");
 }
 
-void OpenGLHelper::ConvertBitmapExToRGBATextureBuffer(const BitmapEx& rBitmapEx, sal_uInt8* o_pRGBABuffer, const bool bFlip)
+void OpenGLHelper::ConvertBitmapExToRGBATextureBuffer(const BitmapEx& rBitmapEx, sal_uInt8* o_pRGBABuffer)
 {
     long nBmpWidth = rBitmapEx.GetSizePixel().Width();
     long nBmpHeight = rBitmapEx.GetSizePixel().Height();
@@ -543,7 +543,7 @@ void OpenGLHelper::ConvertBitmapExToRGBATextureBuffer(const BitmapEx& rBitmapEx,
     Bitmap::ScopedReadAccess pReadAccces( aBitmap );
     AlphaMask::ScopedReadAccess pAlphaReadAccess( aAlpha );
     size_t i = 0;
-    for (long ny = (bFlip ? nBmpHeight - 1 : 0); (bFlip ? ny >= 0 : ny < nBmpHeight); (bFlip ? ny-- : ny++))
+    for (long ny = 0; ny < nBmpHeight; ny++)
     {
         Scanline pAScan = pAlphaReadAccess ? pAlphaReadAccess->GetScanline(ny) : nullptr;
         for(long nx = 0; nx < nBmpWidth; nx++)
diff --git a/vcl/unx/generic/app/gensys.cxx b/vcl/unx/generic/app/gensys.cxx
index 3f2dfef56685..b512123f768e 100644
--- a/vcl/unx/generic/app/gensys.cxx
+++ b/vcl/unx/generic/app/gensys.cxx
@@ -40,48 +40,6 @@
 
 using namespace com::sun::star;
 
-namespace {
-
-OUString GetNativeMessageBoxButtonText( StandardButtonType nButtonId, bool bUseResources )
-{
-    OUString aText;
-    if( bUseResources )
-    {
-        aText = Button::GetStandardText( nButtonId );
-    }
-    if( aText.isEmpty() )
-    {
-        switch( nButtonId )
-        {
-        case StandardButtonType::OK:
-            aText = "OK";
-            break;
-        case StandardButtonType::Cancel:
-            aText = "Cancel";
-            break;
-        case StandardButtonType::Abort:
-            aText = "Abort";
-            break;
-        case StandardButtonType::Retry:
-            aText = "Retry";
-            break;
-        case StandardButtonType::Ignore:
-            aText = "Ignore";
-            break;
-        case StandardButtonType::Yes:
-            aText = "Yes";
-            break;
-        case StandardButtonType::No:
-            aText = "No";
-            break;
-        default: break;
-        }
-    }
-    return aText;
-}
-
-}
-
 SalGenericSystem::SalGenericSystem()
 {
 }
@@ -97,7 +55,7 @@ int SalGenericSystem::ShowNativeMessageBox( const OUString& rTitle, const OUStri
 
     ImplHideSplash();
 
-    aButtons.push_back( GetNativeMessageBoxButtonText( StandardButtonType::OK, false/*bUseResources*/ ) );
+    aButtons.push_back( "OK" );
     nButtonIds[nBut++] = SALSYSTEM_SHOWNATIVEMSGBOX_BTN_OK;
     int nResult = ShowNativeDialog( rTitle, rMessage, aButtons );
 
diff --git a/vcl/unx/generic/fontmanager/fontmanager.cxx b/vcl/unx/generic/fontmanager/fontmanager.cxx
index 5288fead1298..a66aee353449 100644
--- a/vcl/unx/generic/fontmanager/fontmanager.cxx
+++ b/vcl/unx/generic/fontmanager/fontmanager.cxx
@@ -1111,9 +1111,7 @@ bool PrintFontManager::createFontSubset(
                                                      aToFile.getStr(),
                                                      pGID,
                                                      pEnc,
-                                                     nGlyphs,
-                                                     0,
-                                                     nullptr ) );
+                                                     nGlyphs ) );
     CloseTTFont( pTTFont );
 
     return bSuccess;
diff --git a/vcl/unx/generic/printer/ppdparser.cxx b/vcl/unx/generic/printer/ppdparser.cxx
index e4c4a8be33cf..a6109af7f289 100644
--- a/vcl/unx/generic/printer/ppdparser.cxx
+++ b/vcl/unx/generic/printer/ppdparser.cxx
@@ -127,12 +127,11 @@ namespace psp
     };
 
     static css::lang::Locale normalizeInputLocale(
-        const css::lang::Locale& i_rLocale,
-        bool bInsertDefault
+        const css::lang::Locale& i_rLocale
         )
     {
         css::lang::Locale aLoc( i_rLocale );
-        if( bInsertDefault && aLoc.Language.isEmpty() )
+        if( aLoc.Language.isEmpty() )
         {
             // empty locale requested, fill in application UI locale
             aLoc = Application::GetSettings().GetUILanguageTag().getLocale();
@@ -214,7 +213,7 @@ namespace psp
             {
                 const translation_map& rMap( it->second );
 
-                css::lang::Locale aLoc( normalizeInputLocale( css::lang::Locale(), true ) );
+                css::lang::Locale aLoc( normalizeInputLocale( css::lang::Locale() ) );
                 /* FIXME-BCP47: use LanguageTag::getFallbackStrings()? */
                 for( int nTry = 0; nTry < 4; nTry++ )
                 {
diff --git a/vcl/win/gdi/salfont.cxx b/vcl/win/gdi/salfont.cxx
index 35fb6a3fb3d4..a6e050be9328 100644
--- a/vcl/win/gdi/salfont.cxx
+++ b/vcl/win/gdi/salfont.cxx
@@ -1709,7 +1709,7 @@ bool WinSalGraphics::CreateFontSubset( const OUString& rToFile,
 
     // write subset into destination file
     nRC = ::CreateTTFromTTGlyphs( aSftTTF.get(), aToFile.getStr(), aShortIDs,
-            aTempEncs, nGlyphCount, 0, nullptr );
+            aTempEncs, nGlyphCount );
     return (nRC == SF_OK);
 }