diff options
| author | Mike Kaganski <mike.kaganski@collabora.com> | 2020-04-16 17:35:57 +0300 |
|---|---|---|
| committer | Mike Kaganski <mike.kaganski@collabora.com> | 2020-04-16 20:18:29 +0200 |
| commit | de1dadd591862e38242cc2de7a4a658a9a8b67ac (patch) | |
| tree | db1cd7b73766432b91637d292c719483e0f85b51 | |
| parent | 38e7e6f348df5d6b37d7e0051fd3b8c227db69e6 (diff) | |
tdf#132147: formula may be empty
"Regression" after commit ab285c743afa1c8769581871d7b56374fd8c49f1
author Noel Grandin <noel.grandin@collabora.co.uk> Sat Nov 02 18:59:49 2019 +0200
committer Noel Grandin <noel.grandin@collabora.co.uk> Sun Nov 03 17:11:14 2019 +0100
loplugin:stringadd
tweak the plugin to be more permissive, then validate by hand
afterwards
which replaced strFor.replaceAt(0,1,"") with strFor.copy(1). Both methods
are illegal on empty string, but the former asserted, then silently corrected
wrong count; while the latter returns "br0ken". So the change actually
revealed a pre-existing bug.
Change-Id: Ic32b69d46e852f26e6c6ba819eed08bb79dce7a9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92301
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
| -rw-r--r-- | sc/source/ui/Accessibility/AccessibleCell.cxx | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/sc/source/ui/Accessibility/AccessibleCell.cxx b/sc/source/ui/Accessibility/AccessibleCell.cxx index ff0b52423d79..b26e2b33b6a2 100644 --- a/sc/source/ui/Accessibility/AccessibleCell.cxx +++ b/sc/source/ui/Accessibility/AccessibleCell.cxx @@ -491,8 +491,11 @@ uno::Any SAL_CALL ScAccessibleCell::getExtendedAttributes() if (mpViewShell) { OUString strFor = mpViewShell->GetFormula(maCellAddress) ; - strFor = strFor.copy(1); - strFor = ReplaceFourChar(strFor); + if (!strFor.isEmpty()) + { + strFor = strFor.copy(1); + strFor = ReplaceFourChar(strFor); + } strFor = "Formula:" + strFor + ";Note:" + ReplaceFourChar(GetAllDisplayNote()) + ";" + |