diff options
| author | Julien Nabet <serval2412@yahoo.fr> | 2014-05-17 09:36:18 +0200 |
|---|---|---|
| committer | Julien Nabet <serval2412@yahoo.fr> | 2014-05-17 09:37:35 +0200 |
| commit | f62de9113a4866f7152acbe0e8221c594b7a7b68 (patch) | |
| tree | e0faf400134d56e305be642dad2471e6a0c871b6 | |
| parent | bc5c5365599672c7e5b57e31fe1c0b62764d24b2 (diff) | |
Comment why it's not a copy paste error
See http://nabble.documentfoundation.org/Question-unoType-for-getXmlToken-dbaccess-reportdesign-module-td4109071.html
Thank you Lionel!
Change-Id: I999bad0d6de0327bea7ba04a6c61a497d45f53a0
| -rw-r--r-- | dbaccess/source/filter/xml/xmlDataSourceSetting.cxx | 1 | ||||
| -rw-r--r-- | reportdesign/source/filter/xml/xmlControlProperty.cxx | 1 | ||||
| -rw-r--r-- | xmloff/source/forms/propertyimport.cxx | 5 |
3 files changed, 7 insertions, 0 deletions
diff --git a/dbaccess/source/filter/xml/xmlDataSourceSetting.cxx b/dbaccess/source/filter/xml/xmlDataSourceSetting.cxx index 5618378666a1..6c6bacf9b425 100644 --- a/dbaccess/source/filter/xml/xmlDataSourceSetting.cxx +++ b/dbaccess/source/filter/xml/xmlDataSourceSetting.cxx @@ -74,6 +74,7 @@ OXMLDataSourceSetting::OXMLDataSourceSetting( ODBFilter& rImport if (s_aTypeNameMap.empty()) { s_aTypeNameMap[GetXMLToken( XML_BOOLEAN)] = ::getBooleanCppuType(); + // Not a copy paste error, see comment xmloff/source/forms/propertyimport.cxx lines 244-248 s_aTypeNameMap[GetXMLToken( XML_FLOAT)] = ::cppu::UnoType<double>::get(); s_aTypeNameMap[GetXMLToken( XML_DOUBLE)] = ::cppu::UnoType<double>::get(); s_aTypeNameMap[GetXMLToken( XML_STRING)] = ::cppu::UnoType<OUString>::get(); diff --git a/reportdesign/source/filter/xml/xmlControlProperty.cxx b/reportdesign/source/filter/xml/xmlControlProperty.cxx index 5545bb26c6eb..942cf3ff59e4 100644 --- a/reportdesign/source/filter/xml/xmlControlProperty.cxx +++ b/reportdesign/source/filter/xml/xmlControlProperty.cxx @@ -85,6 +85,7 @@ OXMLControlProperty::OXMLControlProperty( ORptFilter& rImport if (s_aTypeNameMap.empty()) { s_aTypeNameMap[GetXMLToken( XML_BOOLEAN)] = ::getBooleanCppuType(); + // Not a copy paste error, see comment xmloff/source/forms/propertyimport.cxx lines 244-248 s_aTypeNameMap[GetXMLToken( XML_FLOAT)] = cppu::UnoType<double>::get(); s_aTypeNameMap[GetXMLToken( XML_DOUBLE)] = cppu::UnoType<double>::get(); s_aTypeNameMap[GetXMLToken( XML_STRING)] = cppu::UnoType<OUString>::get(); diff --git a/xmloff/source/forms/propertyimport.cxx b/xmloff/source/forms/propertyimport.cxx index 1b47bf3be147..c992b6f52073 100644 --- a/xmloff/source/forms/propertyimport.cxx +++ b/xmloff/source/forms/propertyimport.cxx @@ -241,6 +241,11 @@ Type PropertyConversion::xmlTypeToUnoType( const OUString& _rType ) if ( s_aTypeNameMap.empty() ) { s_aTypeNameMap[ token::GetXMLToken( token::XML_BOOLEAN ) ] = ::getBooleanCppuType(); + // Not a copy paste error, quotation from: + // http://nabble.documentfoundation.org/Question-unoType-for-getXmlToken-dbaccess-reportdesign-module-tp4109071p4109116.html + // all numeric types (including the UNO double) + // consistently map to XML_FLOAT, so taking the extra precision from the + // C++ type "float" to "double" makes absolute sense s_aTypeNameMap[ token::GetXMLToken( token::XML_FLOAT ) ] = ::cppu::UnoType<double>::get(); s_aTypeNameMap[ token::GetXMLToken( token::XML_STRING ) ] = ::cppu::UnoType<OUString>::get(); s_aTypeNameMap[ token::GetXMLToken( token::XML_VOID ) ] = ::getVoidCppuType(); |