tdf#145538 Change common loops to range based in ScanlineToolsTest.cxx

Just convert some loops to range based and fix strange loop logic
at 216 line.

Upd: rename *iterators* as Mike Kaganski adviced

Change-Id: Idf33b65f9c4466aa49c8f3bc13a12ad072dce7b6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137929
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins

1 files changed, 6 insertions, 6 deletions

diff --git a/vcl/qa/cppunit/ScanlineToolsTest.cxx b/vcl/qa/cppunit/ScanlineToolsTest.cxx
index c6751b827ca1..8b8a9088a1ea 100644
--- a/vcl/qa/cppunit/ScanlineToolsTest.cxx
+++ b/vcl/qa/cppunit/ScanlineToolsTest.cxx
@@ -122,10 +122,10 @@ void ScanlineToolsTest::ScanlineTransformer_8bit_Palette()
 
     pScanlineTransformer->startLine(aScanLine.data());
 
-    for (size_t i = 0; i < aColors.size(); ++i)
+    for (Color const& rColor : aColors)
     {
         Color aColor = pScanlineTransformer->readPixel();
-        CPPUNIT_ASSERT_EQUAL(aColors[i], aColor);
+        CPPUNIT_ASSERT_EQUAL(rColor, aColor);
     }
 }
 
@@ -162,10 +162,10 @@ void ScanlineToolsTest::ScanlineTransformer_4bit_Palette()
 
     pScanlineTransformer->startLine(aScanLine.data());
 
-    for (size_t i = 0; i < aColors.size(); ++i)
+    for (Color const& rColor : aColors)
     {
         Color aColor = pScanlineTransformer->readPixel();
-        CPPUNIT_ASSERT_EQUAL(aColors[i], aColor);
+        CPPUNIT_ASSERT_EQUAL(rColor, aColor);
     }
 }
 
@@ -213,10 +213,10 @@ void ScanlineToolsTest::ScanlineTransformer_1bit_Palette()
         Color(110, 150, 70),
     };
 
-    for (size_t i = 0; i < aColors.size(); ++i)
+    for (Color const& rColor : aColorsExpected)
     {
         Color aColor = pScanlineTransformer->readPixel();
-        CPPUNIT_ASSERT_EQUAL(aColorsExpected[i], aColor);
+        CPPUNIT_ASSERT_EQUAL(rColor, aColor);
     }
 }