diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-08-15 14:42:48 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-08-16 09:00:21 +0200 |
| commit | b9df8ad95e56493d6868c8b820b899f27218d105 (patch) | |
| tree | 638782307a459f02a5abb7aa1c1ba3e66589c6c4 | |
| parent | c135f51b050dfa7ef095fe8a5b73cde37219a8dd (diff) | |
loplugin:returnconstant in XclImpChangeTrack
Change-Id: Ib7670dd3595af4a4aafa2502a5e3b2ed4ad7fe11
Reviewed-on: https://gerrit.libreoffice.org/59135
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
| -rw-r--r-- | sc/source/filter/inc/XclImpChangeTrack.hxx | 2 | ||||
| -rw-r--r-- | sc/source/filter/xcl97/XclImpChangeTrack.cxx | 6 |
2 files changed, 4 insertions, 4 deletions
diff --git a/sc/source/filter/inc/XclImpChangeTrack.hxx b/sc/source/filter/inc/XclImpChangeTrack.hxx index 1305f2064fee..8d9e8293f7a4 100644 --- a/sc/source/filter/inc/XclImpChangeTrack.hxx +++ b/sc/source/filter/inc/XclImpChangeTrack.hxx @@ -102,7 +102,7 @@ public: // reads extended 3D ref info following the formulas, returns sc tab nums // ( called by XclImpChTrFmlConverter::Read3DTabReference() ) - bool Read3DTabRefInfo( SCTAB& rFirstTab, SCTAB& rLastTab, ExcelToSc8::ExternalTabInfo& rExtInfo ); + void Read3DTabRefInfo( SCTAB& rFirstTab, SCTAB& rLastTab, ExcelToSc8::ExternalTabInfo& rExtInfo ); void Apply(); }; diff --git a/sc/source/filter/xcl97/XclImpChangeTrack.cxx b/sc/source/filter/xcl97/XclImpChangeTrack.cxx index 4b234b6d2753..f4876dff3e77 100644 --- a/sc/source/filter/xcl97/XclImpChangeTrack.cxx +++ b/sc/source/filter/xcl97/XclImpChangeTrack.cxx @@ -146,7 +146,7 @@ bool XclImpChangeTrack::CheckRecord( sal_uInt16 nOpCode ) return aRecHeader.nIndex != 0; } -bool XclImpChangeTrack::Read3DTabRefInfo( SCTAB& rFirstTab, SCTAB& rLastTab, ExcelToSc8::ExternalTabInfo& rExtInfo ) +void XclImpChangeTrack::Read3DTabRefInfo( SCTAB& rFirstTab, SCTAB& rLastTab, ExcelToSc8::ExternalTabInfo& rExtInfo ) { if( LookAtuInt8() == 0x01 ) { @@ -178,7 +178,6 @@ bool XclImpChangeTrack::Read3DTabRefInfo( SCTAB& rFirstTab, SCTAB& rLastTab, Exc rExtInfo.maTabName = aTabName; rFirstTab = rLastTab = 0; } - return true; } void XclImpChangeTrack::ReadFormula( ScTokenArray*& rpTokenArray, const ScAddress& rPosition ) @@ -515,7 +514,8 @@ XclImpChTrFmlConverter::~XclImpChTrFmlConverter() bool XclImpChTrFmlConverter::Read3DTabReference( sal_uInt16 /*nIxti*/, SCTAB& rFirstTab, SCTAB& rLastTab, ExternalTabInfo& rExtInfo ) { - return rChangeTrack.Read3DTabRefInfo( rFirstTab, rLastTab, rExtInfo ); + rChangeTrack.Read3DTabRefInfo( rFirstTab, rLastTab, rExtInfo ); + return true; } /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ |