summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2019-09-26 14:11:14 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2019-09-28 17:56:57 +0200
commit664f8632b1f4720475e6cb7176a08d3d204affd5 (patch)
tree7fa38edfc5afb8ea064007ef09ed6b9bc5a37bed
parentef98596d62304d64d89b04de04c2bebff76286a0 (diff)
loplugin:virtualdead in basegfx
Change-Id: I8b3f7810eb08b5217df30b7be27aafadeeed247a Reviewed-on: https://gerrit.libreoffice.org/79647 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-rw-r--r--basegfx/source/tools/systemdependentdata.cxx8
-rw-r--r--compilerplugins/clang/virtualdead.results6
-rw-r--r--include/basegfx/utils/systemdependentdata.hxx6
3 files changed, 1 insertions, 19 deletions
diff --git a/basegfx/source/tools/systemdependentdata.cxx b/basegfx/source/tools/systemdependentdata.cxx
index 2c1c173eff96..6f1e789d16c8 100644
--- a/basegfx/source/tools/systemdependentdata.cxx
+++ b/basegfx/source/tools/systemdependentdata.cxx
@@ -77,7 +77,7 @@ namespace basegfx
if(0 == mnCalculatedCycles)
{
const sal_Int64 nBytes(estimateUsageInBytes());
- const sal_uInt32 nSeconds(getHoldCyclesInSeconds());
+ const sal_uInt32 nSeconds = 60; // HoldCyclesInSeconds
// default is Seconds (minimal is one)
sal_uInt32 nResult(0 == nSeconds ? 1 : nSeconds);
@@ -115,12 +115,6 @@ namespace basegfx
return mnCalculatedCycles;
}
- sal_uInt32 SystemDependentData::getHoldCyclesInSeconds() const
- {
- // default implementation returns 60(s)
- return 60;
- }
-
sal_Int64 SystemDependentData::estimateUsageInBytes() const
{
// default implementation has no idea
diff --git a/compilerplugins/clang/virtualdead.results b/compilerplugins/clang/virtualdead.results
index f7a6ff3dce54..70b36c5e14a9 100644
--- a/compilerplugins/clang/virtualdead.results
+++ b/compilerplugins/clang/virtualdead.results
@@ -31,12 +31,6 @@ Gui/qaccessible.h:613
Gui/qaccessible.h:619
void QAccessibleTableInterface::modelChange(class QAccessibleTableModelChangeEvent *,)
empty
-include/basegfx/utils/systemdependentdata.hxx:122
- unsigned int basegfx::SystemDependentData::getHoldCyclesInSeconds()const
- 60
-include/basegfx/utils/unopolypolygon.hxx:97
- void basegfx::unotools::UnoPolyPolygon::modifying()const
- empty
include/canvas/base/bitmapcanvasbase.hxx:80
unsigned char canvas::BitmapCanvasBase::hasAlpha()
1
diff --git a/include/basegfx/utils/systemdependentdata.hxx b/include/basegfx/utils/systemdependentdata.hxx
index 32f02bea6fa2..f3befe06085f 100644
--- a/include/basegfx/utils/systemdependentdata.hxx
+++ b/include/basegfx/utils/systemdependentdata.hxx
@@ -115,12 +115,6 @@ namespace basegfx
// mnCalculatedCycles
sal_uInt32 calculateCombinedHoldCyclesInSeconds() const;
- // Number of cycles a SystemDependentDataManager should/might
- // hold this instance in seconds - does not have to be used,
- // but should be. Default implementation returns 60(s). Override to
- // offer useful data if you want to have better caching.
- virtual sal_uInt32 getHoldCyclesInSeconds() const;
-
// Size estimation of the entry in bytes - does not have to
// be used, but should be. Default returns zero what
// means there is no size estimation available. Override to