diff options
| author | Michael Stahl <mstahl@redhat.com> | 2014-06-30 23:22:10 +0200 |
|---|---|---|
| committer | Miklos Vajna <vmiklos@collabora.co.uk> | 2014-07-01 11:24:15 +0000 |
| commit | 841fe2a12ea24c5f1ed61e48e15939b3b05acc5d (patch) | |
| tree | 8518db81f87ce4edc743c30a1880e282e1515d2d | |
| parent | 971cecc1953dd152da8d759b71a9189e00c56f32 (diff) | |
fdo#80663: sw: fix crash on Undo of table row/column delete
The _FndBox appears to handle an empty table lines vector, but evidently
it does not check its indexes properly in this case, which crashes with
STL containers.
(regression from bc0c939270a45469b8f22008288b5e4a4d9c9861)
Change-Id: Id864ea12bc97e61c5251f470e446b6b8f69cb054
(cherry picked from commit 2c157249207552e193e52f5ab7fad5b37ae0a748)
Reviewed-on: https://gerrit.libreoffice.org/9999
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
| -rw-r--r-- | sw/source/core/frmedt/tblsel.cxx | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/sw/source/core/frmedt/tblsel.cxx b/sw/source/core/frmedt/tblsel.cxx index c0ec660acf97..362d4759cf36 100644 --- a/sw/source/core/frmedt/tblsel.cxx +++ b/sw/source/core/frmedt/tblsel.cxx @@ -2110,7 +2110,7 @@ void _FndBox::SetTableLines( const SwSelBoxes &rBoxes, const SwTable &rTable ) if( nEndPos < nPos ) nEndPos = nPos; } - if ( nStPos > 1 ) + if (USHRT_MAX != nStPos && nStPos > 1) pLineBefore = rTable.GetTabLines()[nStPos - 2]; if ( nEndPos < rTable.GetTabLines().size() ) pLineBehind = rTable.GetTabLines()[nEndPos]; @@ -2173,7 +2173,8 @@ void _FndBox::DelFrms( SwTable &rTable, bool bAccTableDispose ) nEndPos = rTable.GetTabLines().GetPos( (const SwTableLine*&)pLineBehind ); OSL_ENSURE( nEndPos != USHRT_MAX, "The fox stole the line!" ); - --nEndPos; + if (nEndPos != 0) + --nEndPos; } for ( sal_uInt16 i = nStPos; i <= nEndPos; ++i) |