diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2015-10-13 20:50:53 +0100 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2015-10-13 22:38:34 +0100 |
| commit | 216297f06ba0153017382eed7bfe2cc571ea67a1 (patch) | |
| tree | fdc3d25dccc65b8f30ba367ac4ba678d8c1dc8db | |
| parent | 432fe1f30c1c28b0fb51022533e4b93276c640ce (diff) | |
coverity#1326250 Unchecked dynamic_cast
Change-Id: I0c2cf72d7e4f736e2e2c3b8b5def920ee79747fe
| -rw-r--r-- | sw/source/filter/xml/xmlimpit.cxx | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/sw/source/filter/xml/xmlimpit.cxx b/sw/source/filter/xml/xmlimpit.cxx index 61e93022fe46..d68c979c0a2b 100644 --- a/sw/source/filter/xml/xmlimpit.cxx +++ b/sw/source/filter/xml/xmlimpit.cxx @@ -590,9 +590,7 @@ bool SvXMLImportItemMapper::PutXMLValue( case RES_BREAK: { - SvxFormatBreakItem* pFormatBreak = dynamic_cast<SvxFormatBreakItem*>( &rItem ); - OSL_ENSURE( pFormatBreak != NULL, "Wrong Which-ID" ); - + SvxFormatBreakItem& rFormatBreak = dynamic_cast<SvxFormatBreakItem&>(rItem); sal_uInt16 eEnum; if( !SvXMLUnitConverter::convertEnum( eEnum, rValue, psXML_BreakType ) ) @@ -600,7 +598,7 @@ bool SvXMLImportItemMapper::PutXMLValue( if( eEnum == 0 ) { - pFormatBreak->SetValue( SVX_BREAK_NONE ); + rFormatBreak.SetValue( SVX_BREAK_NONE ); bOk = true; } else @@ -608,12 +606,12 @@ bool SvXMLImportItemMapper::PutXMLValue( switch( nMemberId ) { case MID_BREAK_BEFORE: - pFormatBreak->SetValue( static_cast< sal_uInt16 >((eEnum == 1) ? + rFormatBreak.SetValue( static_cast< sal_uInt16 >((eEnum == 1) ? SVX_BREAK_COLUMN_BEFORE : SVX_BREAK_PAGE_BEFORE) ); break; case MID_BREAK_AFTER: - pFormatBreak->SetValue( static_cast< sal_uInt16 >((eEnum == 1) ? + rFormatBreak.SetValue( static_cast< sal_uInt16 >((eEnum == 1) ? SVX_BREAK_COLUMN_AFTER : SVX_BREAK_PAGE_AFTER) ); break; |