diff options
author | Caolán McNamara <caolanm@redhat.com> | 2016-09-04 15:34:30 +0100 |
---|---|---|
committer | Caolán McNamara <caolanm@redhat.com> | 2016-09-04 16:53:19 +0100 |
commit | c233b1b63750a995fcc0547459fae4cf3ec9e735 (patch) | |
tree | c354d2bcf91de7f3696a158c71dde95f00df7a44 | |
parent | c5653039412114a14eb0b53e6e1ca26efaf468cd (diff) |
coverity#1371177 default assign is good enough
and
coverity#1371311
coverity#1371240
Change-Id: I1f792b9a8e3e386633d4026d8b073ab615d243f3
-rw-r--r-- | reportdesign/inc/reportformula.hxx | 2 | ||||
-rw-r--r-- | reportdesign/source/core/misc/reportformula.cxx | 9 | ||||
-rw-r--r-- | sc/inc/docoptio.hxx | 25 | ||||
-rw-r--r-- | sd/inc/OutlinerIterator.hxx | 10 | ||||
-rw-r--r-- | sd/source/ui/view/OutlinerIterator.cxx | 14 |
5 files changed, 0 insertions, 60 deletions
diff --git a/reportdesign/inc/reportformula.hxx b/reportdesign/inc/reportformula.hxx index 1e591b8644b1..4e41ae2d164f 100644 --- a/reportdesign/inc/reportformula.hxx +++ b/reportdesign/inc/reportformula.hxx @@ -56,8 +56,6 @@ namespace rptui ReportFormula( const BindType _eType, const OUString& _rFieldOrExpression ); ~ReportFormula(); - ReportFormula& operator=(class ReportFormula const &); - /// returns whether the object denotes a valid formula bool isValid() const; diff --git a/reportdesign/source/core/misc/reportformula.cxx b/reportdesign/source/core/misc/reportformula.cxx index d491791e0088..bdecbc69cd46 100644 --- a/reportdesign/source/core/misc/reportformula.cxx +++ b/reportdesign/source/core/misc/reportformula.cxx @@ -124,15 +124,6 @@ namespace rptui } bool ReportFormula::isValid() const { return getType() != Invalid; } - ReportFormula& ReportFormula::operator=(class ReportFormula const & _rHd) - { - if ( this == &_rHd ) - return *this; - m_eType = _rHd.m_eType; - m_sCompleteFormula = _rHd.m_sCompleteFormula; - m_sUndecoratedContent = _rHd.m_sUndecoratedContent; - return *this; - } OUString ReportFormula::getEqualUndecoratedContent() const { diff --git a/sc/inc/docoptio.hxx b/sc/inc/docoptio.hxx index 5c0c28b5fbb2..8e4ebb58b749 100644 --- a/sc/inc/docoptio.hxx +++ b/sc/inc/docoptio.hxx @@ -82,7 +82,6 @@ public: void ResetDocOptions(); - inline const ScDocOptions& operator=( const ScDocOptions& rOpt ); inline bool operator==( const ScDocOptions& rOpt ) const; inline bool operator!=( const ScDocOptions& rOpt ) const; @@ -112,30 +111,6 @@ public: bool IsWriteCalcConfig() const { return bWriteCalcConfig; } }; -inline const ScDocOptions& ScDocOptions::operator=( const ScDocOptions& rCpy ) -{ - bIsIgnoreCase = rCpy.bIsIgnoreCase; - bIsIter = rCpy.bIsIter; - nIterCount = rCpy.nIterCount; - fIterEps = rCpy.fIterEps; - nPrecStandardFormat = rCpy.nPrecStandardFormat; - nDay = rCpy.nDay; - nMonth = rCpy.nMonth; - nYear = rCpy.nYear; - nYear2000 = rCpy.nYear2000; - nTabDistance = rCpy.nTabDistance; - bCalcAsShown = rCpy.bCalcAsShown; - bMatchWholeCell = rCpy.bMatchWholeCell; - bDoAutoSpell = rCpy.bDoAutoSpell; - bLookUpColRowNames = rCpy.bLookUpColRowNames; - bFormulaRegexEnabled= rCpy.bFormulaRegexEnabled; - bFormulaWildcardsEnabled = rCpy.bFormulaWildcardsEnabled; - eFormulaSearchType = rCpy.eFormulaSearchType; - bWriteCalcConfig = rCpy.bWriteCalcConfig; - - return *this; -} - inline bool ScDocOptions::operator==( const ScDocOptions& rOpt ) const { return ( diff --git a/sd/inc/OutlinerIterator.hxx b/sd/inc/OutlinerIterator.hxx index d5a4392dbcea..c4a1308dca43 100644 --- a/sd/inc/OutlinerIterator.hxx +++ b/sd/inc/OutlinerIterator.hxx @@ -303,16 +303,6 @@ public: */ IteratorPosition (const IteratorPosition& aPosition); - /// The destructor is a no-op at the moment. - ~IteratorPosition(); - /** Assign the content of the given position to this one. - @param aPosition - This is the position object from which to take the values of all - data members. - @return - Returns a reference to this object. - */ - IteratorPosition& operator= (const IteratorPosition& aPosition); /** Compare two positions for equality. @return <TRUE/> is returned only when all data members have the same diff --git a/sd/source/ui/view/OutlinerIterator.cxx b/sd/source/ui/view/OutlinerIterator.cxx index 1eb3351f8a4d..36cdb32310f1 100644 --- a/sd/source/ui/view/OutlinerIterator.cxx +++ b/sd/source/ui/view/OutlinerIterator.cxx @@ -53,20 +53,6 @@ IteratorPosition::IteratorPosition (const IteratorPosition& aPosition) { } -IteratorPosition::~IteratorPosition() -{ -} - -IteratorPosition& IteratorPosition::operator= (const IteratorPosition& aPosition) -{ - mxObject = aPosition.mxObject; - mnText = aPosition.mnText; - mnPageIndex = aPosition.mnPageIndex; - mePageKind = aPosition.mePageKind; - meEditMode = aPosition.meEditMode; - return *this; -} - bool IteratorPosition::operator== (const IteratorPosition& aPosition) const { return mxObject.get() == aPosition.mxObject.get() |