diff options
author | Stephan Bergmann <sbergman@redhat.com> | 2017-07-13 11:47:16 +0200 |
---|---|---|
committer | Stephan Bergmann <sbergman@redhat.com> | 2017-07-13 11:47:16 +0200 |
commit | ad4e4c7834c576189e2a4b230baa1f12207718ec (patch) | |
tree | 6bd33d0e0f0b9522ad1fd3b35b63652f06dc9799 | |
parent | c946de5ef0b40d3b6ddd1c101f7d59a5a9d3a6bd (diff) |
loplugin:oncevar: empty strings: chart2
Change-Id: If564ba545fbd1504127ff5116fb776ef60d6ab60
3 files changed, 4 insertions, 6 deletions
diff --git a/chart2/source/controller/chartapiwrapper/WrappedAxisAndGridExistenceProperties.cxx b/chart2/source/controller/chartapiwrapper/WrappedAxisAndGridExistenceProperties.cxx index 8654699304fe..f7214e3e2946 100644 --- a/chart2/source/controller/chartapiwrapper/WrappedAxisAndGridExistenceProperties.cxx +++ b/chart2/source/controller/chartapiwrapper/WrappedAxisAndGridExistenceProperties.cxx @@ -260,8 +260,7 @@ void WrappedAxisTitleExistenceProperty::setPropertyValue( const Any& rOuterValue if( bNewValue ) { - OUString aTitleText; - TitleHelper::createTitle( m_eTitleType, aTitleText + TitleHelper::createTitle( m_eTitleType, OUString() , m_spChart2ModelContact->getChartModel(), m_spChart2ModelContact->m_xContext ); } else diff --git a/chart2/source/controller/main/ChartController_Properties.cxx b/chart2/source/controller/main/ChartController_Properties.cxx index a0b82a4d74ff..6da7736eea60 100644 --- a/chart2/source/controller/main/ChartController_Properties.cxx +++ b/chart2/source/controller/main/ChartController_Properties.cxx @@ -440,7 +440,6 @@ OUString lcl_getErrorCIDForCommand( const ObjectType eDispatchType, const Object OUString lcl_getObjectCIDForCommand( const OString& rDispatchCommand, const uno::Reference< XChartDocument > & xChartDocument, const OUString& rSelectedCID ) { ObjectType eObjectType = OBJECTTYPE_UNKNOWN; - OUString aParticleID; uno::Reference< frame::XModel > xChartModel( xChartDocument, uno::UNO_QUERY ); const ObjectType eSelectedType = ObjectIdentifier::getObjectType( rSelectedCID ); @@ -649,7 +648,8 @@ OUString lcl_getObjectCIDForCommand( const OString& rDispatchCommand, const uno: } return ObjectIdentifier::createClassifiedIdentifier( - eObjectType, aParticleID ); + eObjectType, + OUString() ); // aParticleID } } diff --git a/chart2/source/view/main/ChartView.cxx b/chart2/source/view/main/ChartView.cxx index 4d69b1cc6247..c93e7d8480a9 100644 --- a/chart2/source/view/main/ChartView.cxx +++ b/chart2/source/view/main/ChartView.cxx @@ -1713,7 +1713,6 @@ awt::Rectangle ChartView::impl_createDiagramAndContent( const CreateShapeParam2D for( std::unique_ptr<VSeriesPlotter>& aPlotter : rSeriesPlotterList ) { VSeriesPlotter* pSeriesPlotter = aPlotter.get(); - OUString aCID; //III uno::Reference< drawing::XShapes > xSeriesTarget(nullptr); if( pSeriesPlotter->WantToPlotInFrontOfAxisLine() ) xSeriesTarget = xSeriesTargetInFrontOfAxis; @@ -1722,7 +1721,7 @@ awt::Rectangle ChartView::impl_createDiagramAndContent( const CreateShapeParam2D xSeriesTarget = xSeriesTargetBehindAxis; OSL_ENSURE( !bIsPieOrDonut, "not implemented yet! - during a complete recreation this shape is destroyed so no series can be created anymore" ); } - pSeriesPlotter->initPlotter( xSeriesTarget,xTextTargetShapes,m_xShapeFactory,aCID ); + pSeriesPlotter->initPlotter( xSeriesTarget,xTextTargetShapes,m_xShapeFactory,OUString() ); pSeriesPlotter->setPageReferenceSize( rPageSize ); VCoordinateSystem* pVCooSys = lcl_getCooSysForPlotter( rVCooSysList, pSeriesPlotter ); if(nDimensionCount==2) |