diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2017-11-15 17:03:52 +0000 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2017-11-16 09:57:02 +0100 |
| commit | 0b3ed6c8e9179068954fa5daf7f4cbfbf01ea47e (patch) | |
| tree | 4499a3b86d63498bee8b3b25884fb56fd82b06d8 | |
| parent | ec1e5e9573e09ef56cf311fe0531f84c5b75abe4 (diff) | |
coverity#1421095 Useless call
and
coverity#1421110 Useless call
coverity#1421127 Useless call
coverity#1421082 Useless call
just returns aDocument member, so this isn't testing anything
Change-Id: I556d84c89128bbc652b0cc417e60a1a77ad0dfc9
Reviewed-on: https://gerrit.libreoffice.org/44775
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
| -rw-r--r-- | sc/qa/unit/filters-test.cxx | 3 | ||||
| -rw-r--r-- | sc/qa/unit/subsequent_filters-test.cxx | 3 |
2 files changed, 2 insertions, 4 deletions
diff --git a/sc/qa/unit/filters-test.cxx b/sc/qa/unit/filters-test.cxx index 2d5b1261bda5..24250db69aed 100644 --- a/sc/qa/unit/filters-test.cxx +++ b/sc/qa/unit/filters-test.cxx @@ -305,7 +305,8 @@ void ScFiltersTest::testContentDIF() { ScDocShellRef xDocSh = loadDoc("universal-content.", FORMAT_DIF); - xDocSh->GetDocument(); + CPPUNIT_ASSERT_MESSAGE("Failed to load universal-content.dif", xDocSh.is()); + xDocSh->DoClose(); } diff --git a/sc/qa/unit/subsequent_filters-test.cxx b/sc/qa/unit/subsequent_filters-test.cxx index f97b0f463ad4..f29fd6937e84 100644 --- a/sc/qa/unit/subsequent_filters-test.cxx +++ b/sc/qa/unit/subsequent_filters-test.cxx @@ -1126,7 +1126,6 @@ void ScFiltersTest::testBugFixesXLS() CPPUNIT_ASSERT_MESSAGE("Failed to load bugFixes.xls", xDocSh.is()); xDocSh->DoHardRecalc(); - xDocSh->GetDocument(); xDocSh->DoClose(); } @@ -1136,7 +1135,6 @@ void ScFiltersTest::testBugFixesXLSX() CPPUNIT_ASSERT_MESSAGE("Failed to load bugFixes.xls", xDocSh.is()); xDocSh->DoHardRecalc(); - xDocSh->GetDocument(); xDocSh->DoClose(); } @@ -1572,7 +1570,6 @@ void ScFiltersTest::testPassword_Impl(const OUString& aFileNameBase) } CPPUNIT_ASSERT_MESSAGE("Failed to load password.ods", xDocSh.is()); - xDocSh->GetDocument(); xDocSh->DoClose(); } |