summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2022-08-06 15:35:29 +0100
committerAron Budea <aron.budea@collabora.com>2023-08-23 18:54:12 +0200
commit8902243c9691096184cc6d058a7687735398c42a (patch)
treef0bf08be223cb96bfc8ea72e5b30ff73ee4e1e34
parent86eb55db6378309097f0bcee201177694fefe018 (diff)
crashtesting: keep a reference to the passed in LibXSLTTransformer
otherwise, as seen with: soffice --headless --convert-to docx forum-mso-de-42789.docx and error will notify the other thread that the load has ended and the other thread will destroy the passed in LibXSLTTransformer early while this thread assumes it continues to exist Change-Id: Ieea9ecc3439ea73cd0433e5e12b87811906c49aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137819 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit fafe00bb7d72d6d4bec663b40a4cd92e50f33f0f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156013 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Aron Budea <aron.budea@collabora.com>
-rw-r--r--filter/source/xsltfilter/LibXSLTTransformer.hxx2
1 files changed, 1 insertions, 1 deletions
diff --git a/filter/source/xsltfilter/LibXSLTTransformer.hxx b/filter/source/xsltfilter/LibXSLTTransformer.hxx
index 266fa2c559e1..84c8e5a0fdbd 100644
--- a/filter/source/xsltfilter/LibXSLTTransformer.hxx
+++ b/filter/source/xsltfilter/LibXSLTTransformer.hxx
@@ -67,7 +67,7 @@ namespace XSLT
static const sal_Int32 OUTPUT_BUFFER_SIZE;
static const sal_Int32 INPUT_BUFFER_SIZE;
- LibXSLTTransformer* m_transformer;
+ rtl::Reference<LibXSLTTransformer> m_transformer;
Sequence<sal_Int8> m_readBuf;
Sequence<sal_Int8> m_writeBuf;