summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Weghorn <m.weghorn@posteo.de>2021-03-18 13:59:14 +0100
committerMichael Weghorn <m.weghorn@posteo.de>2021-03-18 16:13:53 +0100
commit6b15b6d5e80f15a15838cdbde979f5b8319e090a (patch)
tree3fdb89af8924b3ea23e367746b8e6317d4d7ce81
parente2d2c38d06dc514ee417ed006ed0f13173d186d6 (diff)
tdf#125318 android: Allow copying with editing disabled
Don't make the possibility to select and copy text depending on editing being enabled, i.e. experimental mode being enabled in Android Viewer. In a quick test, this worked just fine in read-only mode as well, so tapping on text in a document now shows two cursors around the tapped word, and allows adapting the selection using these and copying to the clipboard by using the corresponding toolbar entry. Change-Id: Icbd9d055a6cc700b78711df178f594c7a9c5cfbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112673 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 88f4b76270c26ab1d99c14f68cdcbea4b6ee9031) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112627 Tested-by: Michael Weghorn <m.weghorn@posteo.de>
-rw-r--r--android/source/src/java/org/libreoffice/LOKitThread.java2
1 files changed, 1 insertions, 1 deletions
diff --git a/android/source/src/java/org/libreoffice/LOKitThread.java b/android/source/src/java/org/libreoffice/LOKitThread.java
index e554f0800cf0..03b7070e783a 100644
--- a/android/source/src/java/org/libreoffice/LOKitThread.java
+++ b/android/source/src/java/org/libreoffice/LOKitThread.java
@@ -448,7 +448,7 @@ class LOKitThread extends Thread {
boolean editing = LOKitShell.isEditingEnabled();
float zoomFactor = mViewportMetrics.getZoomFactor();
- if (touchType.equals("LongPress") && editing) {
+ if (touchType.equals("LongPress")) {
mInvalidationHandler.changeStateTo(InvalidationHandler.OverlayState.TRANSITION);
mTileProvider.mouseButtonDown(documentCoordinate, 1, zoomFactor);
mTileProvider.mouseButtonUp(documentCoordinate, 1, zoomFactor);