diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2018-08-17 08:47:19 +0100 |
|---|---|---|
| committer | Miklos Vajna <vmiklos@collabora.com> | 2020-03-19 13:38:17 +0100 |
| commit | a878015aebafa5d23c147e3641ed2ded2ac2a6bb (patch) | |
| tree | 5fdbb1e8aec5e30226a3ecf7b81b86c980e93b25 | |
| parent | 37740148ab1ed98ef321bd8f785baa6ec592c749 (diff) | |
ofz#9934 null deref
Reviewed-on: https://gerrit.libreoffice.org/59249
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
(cherry picked from commit 4fb7390956a193e00c1b599129b89933c41f98ae)
Change-Id: I6833ad8a556b561a37e468da8845914cabfac4c5
| -rw-r--r-- | sw/qa/core/data/ooxml/fail/ofz9934-1.docx | bin | 0 -> 6722 bytes | |||
| -rw-r--r-- | writerfilter/source/dmapper/DomainMapper_Impl.cxx | 5 |
2 files changed, 3 insertions, 2 deletions
diff --git a/sw/qa/core/data/ooxml/fail/ofz9934-1.docx b/sw/qa/core/data/ooxml/fail/ofz9934-1.docx Binary files differnew file mode 100644 index 000000000000..b97afaee8d3f --- /dev/null +++ b/sw/qa/core/data/ooxml/fail/ofz9934-1.docx diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx b/writerfilter/source/dmapper/DomainMapper_Impl.cxx index 1645e447fabb..fa8d662ea5a0 100644 --- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx +++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx @@ -1489,8 +1489,9 @@ void DomainMapper_Impl::appendOLE( const OUString& rStreamName, const OLEHandler if (!m_aAnchoredStack.empty()) m_aAnchoredStack.top( ).bToRemove = true; RemoveLastParagraph(); - m_aTextAppendStack.pop(); - + SAL_WARN_IF(m_aTextAppendStack.empty(), "writerfilter.dmapper", "no text stack"); + if (!m_aTextAppendStack.empty()) + m_aTextAppendStack.pop(); appendTextContent( xOLE, uno::Sequence< beans::PropertyValue >() ); |