diff options
| author | Eike Rathke <erack@redhat.com> | 2014-10-15 02:03:09 +0200 |
|---|---|---|
| committer | Eike Rathke <erack@redhat.com> | 2014-10-15 02:20:13 +0200 |
| commit | defa080e585fb351bc4049b2f280d2e7e5256f6e (patch) | |
| tree | d35dbce1f304bc4a229e0a1d08532c5f02b7addd | |
| parent | 94efc482d514bf9c6c4edb149f86084d672b724f (diff) | |
remove duplicated call to mpChildrenShapes->SelectionChanged()
Found when investigating performance bottlenecks of fdo#75486, after the
selection is completed ScTabViewObj::getSelection() is called multiple
times, each creating a ScCellRangesObj of the range list of filtered
ranges, which then is used for
ScChildrenShapes::FindSelectedShapesChanges()
The duplicated call was introduced with
b41332475783c31136673fb44cf4c411bb0148f8
but IMHO does not make any sense at all unless it has obscure side
effects, it only slows down things even more.
Change-Id: I3cee2e3e62c24ad72efb8cc2021e74d0afc70b69
| -rw-r--r-- | sc/source/ui/Accessibility/AccessibleDocument.cxx | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/sc/source/ui/Accessibility/AccessibleDocument.cxx b/sc/source/ui/Accessibility/AccessibleDocument.cxx index 975dfc7ab344..751a9fed3e49 100644 --- a/sc/source/ui/Accessibility/AccessibleDocument.cxx +++ b/sc/source/ui/Accessibility/AccessibleDocument.cxx @@ -1691,10 +1691,6 @@ void SAL_CALL ScAccessibleDocument::selectionChanged( const lang::EventObject& / CommitChange(aEvent); } - if(mpChildrenShapes ) - { - mpChildrenShapes->SelectionChanged(); - } } //===== XInterface ===================================================== |