summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2019-07-20 15:51:02 +0100
committerCaolán McNamara <caolanm@redhat.com>2019-07-20 21:13:49 +0200
commit73b322a581b98a74c9d1868aca6d8ae05696697c (patch)
treefb9e0e5a6a216d632cb4da35b66192954f78fe59
parent74ce2c90ecc6f6375ff6743efdd0b84358ebd6a3 (diff)
cid#1448363 Unchecked dynamic_cast sw
Change-Id: Id01e96db2df7fb5425b8ab86e66a9fd7577a107d Reviewed-on: https://gerrit.libreoffice.org/76022 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-rw-r--r--sw/source/uibase/shells/textsh1.cxx8
1 files changed, 4 insertions, 4 deletions
diff --git a/sw/source/uibase/shells/textsh1.cxx b/sw/source/uibase/shells/textsh1.cxx
index b5acb1ee9ce2..9a92fc9f438b 100644
--- a/sw/source/uibase/shells/textsh1.cxx
+++ b/sw/source/uibase/shells/textsh1.cxx
@@ -1377,15 +1377,15 @@ void SwTextShell::Execute(SfxRequest &rReq)
else if ( pFieldBM && pFieldBM->GetFieldname() == ODF_FORMDATE )
{
SwAbstractDialogFactory* pFact = SwAbstractDialogFactory::Create();
- sw::mark::DateFieldmark* pDateField = dynamic_cast<sw::mark::DateFieldmark*>(pFieldBM);
- ScopedVclPtr<VclAbstractDialog> pDlg(pFact->CreateDateFormFieldDialog(rWrtSh.GetView().GetFrameWeld(), pDateField, GetView().GetDocShell()->GetDoc()));
+ sw::mark::DateFieldmark& rDateField = dynamic_cast<sw::mark::DateFieldmark&>(*pFieldBM);
+ ScopedVclPtr<VclAbstractDialog> pDlg(pFact->CreateDateFormFieldDialog(rWrtSh.GetView().GetFrameWeld(), &rDateField, GetView().GetDocShell()->GetDoc()));
if (pDlg->Execute() == RET_OK)
{
- pFieldBM->Invalidate();
+ rDateField.Invalidate();
rWrtSh.InvalidateWindows( rWrtSh.GetView().GetVisArea() );
rWrtSh.UpdateCursor(); // cursor position might be invalid
// Hide the button here and make it visible later, to make transparent background work with SAL_USE_VCLPLUGIN=gen
- dynamic_cast<::sw::mark::DateFieldmark*>(pFieldBM)->HideButton();
+ rDateField.HideButton();
}
}
else