summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2016-10-01 09:59:28 +0100
committerCaolán McNamara <caolanm@redhat.com>2016-10-01 10:27:56 +0100
commit450c15a1181ef9aee0bdaa01bae06dd91c86acba (patch)
tree288aeeb33c34f6fad92412296c74438d02633563
parentfa3d4fea73c7c9d5f8790e8b4708776ef3eaab21 (diff)
avoid coverity#1371264 Missing move assignment operator
Change-Id: I5085b0a04cf24b8d4678165371e44dc3556300e3
-rw-r--r--sc/source/ui/StatisticsDialogs/MatrixComparisonGenerator.cxx9
-rw-r--r--sc/source/ui/view/gridwin.cxx4
2 files changed, 4 insertions, 9 deletions
diff --git a/sc/source/ui/StatisticsDialogs/MatrixComparisonGenerator.cxx b/sc/source/ui/StatisticsDialogs/MatrixComparisonGenerator.cxx
index 6bef1fd8030d..3d4945d892a9 100644
--- a/sc/source/ui/StatisticsDialogs/MatrixComparisonGenerator.cxx
+++ b/sc/source/ui/StatisticsDialogs/MatrixComparisonGenerator.cxx
@@ -74,12 +74,9 @@ ScRange ScMatrixComparisonGenerator::ApplyOutput(ScDocShell* pDocShell)
SCTAB inTab = mInputRange.aStart.Tab();
- ScRangeList aRangeList;
-
- if (mGroupedBy == BY_COLUMN)
- aRangeList = MakeColumnRangeList(inTab, mInputRange.aStart, mInputRange.aEnd);
- else
- aRangeList = MakeRowRangeList(inTab, mInputRange.aStart, mInputRange.aEnd);
+ ScRangeList aRangeList = (mGroupedBy == BY_COLUMN) ?
+ MakeColumnRangeList(inTab, mInputRange.aStart, mInputRange.aEnd) :
+ MakeRowRangeList(inTab, mInputRange.aStart, mInputRange.aEnd);
// labels
output.writeString(getLabel());
diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 34a491409d08..f58f500e666a 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -5515,9 +5515,7 @@ bool ScGridWindow::ContinueOnlineSpelling()
ScHorizontalCellIterator aIter(
pDoc, nTab, maVisibleRange.mnCol1, mpSpellCheckCxt->maPos.mnRow, maVisibleRange.mnCol2, maVisibleRange.mnRow2);
- ScRangeList aPivotRanges;
- if (pDPs)
- aPivotRanges = pDPs->GetAllTableRanges(nTab);
+ ScRangeList aPivotRanges = pDPs ? pDPs->GetAllTableRanges(nTab) : ScRangeList();
SCCOL nCol;
SCROW nRow;