diff options
| author | Mike Kaganski <mike.kaganski@collabora.com> | 2016-06-27 23:44:34 +1000 |
|---|---|---|
| committer | Mike Kaganski <mike.kaganski@collabora.com> | 2016-06-28 15:31:42 +0000 |
| commit | 429f4e294e87e1172a925f164ad9e3ef125019a3 (patch) | |
| tree | 35e4cb0c1de19070a30d590746715798e90ea6ec | |
| parent | 67188d0e552c9dc50905f7f693d2bb24751a11c5 (diff) | |
Don't call a function when its result is already stored in variable
const bExternalModel was already set to xModel.is(), and xModel
hasn't been modified since then.
Change-Id: I8cc6e6776e633287cc755b0489458cadbf1ae664
Reviewed-on: https://gerrit.libreoffice.org/26716
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
| -rw-r--r-- | sfx2/source/view/frmload.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sfx2/source/view/frmload.cxx b/sfx2/source/view/frmload.cxx index da63bd9cb5e3..4077e9dbc0fe 100644 --- a/sfx2/source/view/frmload.cxx +++ b/sfx2/source/view/frmload.cxx @@ -668,7 +668,7 @@ sal_Bool SAL_CALL SfxFrameLoader_Impl::load( const Sequence< PropertyValue >& rA ::comphelper::NamedValueCollection aViewCreationArgs( impl_extractViewCreationArgs( aDescriptor ) ); // no model passed from outside? => create one from scratch - if ( !xModel.is() ) + if ( !bExternalModel ) { bool bInternalFilter = aDescriptor.getOrDefault<OUString>("FilterProvider", OUString()).isEmpty(); |