loplugin:constmethod in editeng

Change-Id: I07e22d880940ea6df928565942dac268f4b94fea
Reviewed-on: https://gerrit.libreoffice.org/78399
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

22 files changed, 49 insertions, 49 deletions

diff --git a/editeng/inc/editdoc.hxx b/editeng/inc/editdoc.hxx
index 089addc59c07..2924a0e20c45 100644
--- a/editeng/inc/editdoc.hxx
+++ b/editeng/inc/editdoc.hxx
@@ -764,7 +764,7 @@ public:
     void            SetModifyHdl( const Link<LinkParamNone*,void>& rLink ) { aModifyHdl = rLink; }
 
     void            CreateDefFont( bool bUseStyles );
-    const SvxFont&  GetDefFont() { return aDefFont; }
+    const SvxFont&  GetDefFont() const { return aDefFont; }
 
     void            SetDefTab( sal_uInt16 nTab )    { nDefTab = nTab ? nTab : DEFTAB; }
     sal_uInt16      GetDefTab() const           { return nDefTab; }
diff --git a/editeng/inc/eerdll2.hxx b/editeng/inc/eerdll2.hxx
index 2ce9c120b81c..87a2670bafd4 100644
--- a/editeng/inc/eerdll2.hxx
+++ b/editeng/inc/eerdll2.hxx
@@ -37,7 +37,7 @@ namespace editeng
         public:
             SharedVclResources();
             ~SharedVclResources();
-            VclPtr<VirtualDevice> const & GetVirtualDevice();
+            VclPtr<VirtualDevice> const & GetVirtualDevice() const;
     };
 }
 
diff --git a/editeng/source/accessibility/AccessibleContextBase.cxx b/editeng/source/accessibility/AccessibleContextBase.cxx
index 8dc73b04f8ca..e0312f1e074b 100644
--- a/editeng/source/accessibility/AccessibleContextBase.cxx
+++ b/editeng/source/accessibility/AccessibleContextBase.cxx
@@ -518,7 +518,7 @@ void AccessibleContextBase::ThrowIfDisposed()
 }
 
 
-bool AccessibleContextBase::IsDisposed()
+bool AccessibleContextBase::IsDisposed() const
 {
     return (rBHelper.bDisposed || rBHelper.bInDispose);
 }
diff --git a/editeng/source/editeng/editeng.cxx b/editeng/source/editeng/editeng.cxx
index 9dbf8a285cfa..ef821184ec7b 100644
--- a/editeng/source/editeng/editeng.cxx
+++ b/editeng/source/editeng/editeng.cxx
@@ -110,12 +110,12 @@ void EditEngine::EnableUndo( bool bEnable )
     pImpEditEngine->EnableUndo( bEnable );
 }
 
-bool EditEngine::IsUndoEnabled()
+bool EditEngine::IsUndoEnabled() const
 {
     return pImpEditEngine->IsUndoEnabled();
 }
 
-bool EditEngine::IsInUndo()
+bool EditEngine::IsInUndo() const
 {
     return pImpEditEngine->IsInUndo();
 }
@@ -169,7 +169,7 @@ void EditEngine::SetRefMapMode( const MapMode& rMapMode )
     pImpEditEngine->SetRefMapMode( rMapMode );
 }
 
-MapMode const & EditEngine::GetRefMapMode()
+MapMode const & EditEngine::GetRefMapMode() const
 {
     return pImpEditEngine->GetRefMapMode();
 }
diff --git a/editeng/source/editeng/editobj.cxx b/editeng/source/editeng/editobj.cxx
index a0112468af5b..be4f1d920c92 100644
--- a/editeng/source/editeng/editobj.cxx
+++ b/editeng/source/editeng/editobj.cxx
@@ -326,7 +326,7 @@ void EditTextObject::ChangeStyleSheetName(
     mpImpl->ChangeStyleSheetName(eFamily, rOldName, rNewName);
 }
 
-editeng::FieldUpdater EditTextObject::GetFieldUpdater()
+editeng::FieldUpdater EditTextObject::GetFieldUpdater() const
 {
     return mpImpl->GetFieldUpdater();
 }
diff --git a/editeng/source/editeng/editobj2.hxx b/editeng/source/editeng/editobj2.hxx
index f3436930c484..e2a1fefc1535 100644
--- a/editeng/source/editeng/editobj2.hxx
+++ b/editeng/source/editeng/editobj2.hxx
@@ -253,7 +253,7 @@ public:
         const OUString& rOldName, SfxStyleFamily eOldFamily, const OUString& rNewName, SfxStyleFamily eNewFamily);
     void ChangeStyleSheetName(SfxStyleFamily eFamily, const OUString& rOldName, const OUString& rNewName);
 
-    editeng::FieldUpdater GetFieldUpdater() { return editeng::FieldUpdater(*mpFront);}
+    editeng::FieldUpdater GetFieldUpdater() const { return editeng::FieldUpdater(*mpFront);}
 
     bool HasMetric() const { return nMetric != 0xFFFF; }
     sal_uInt16                  GetMetric() const           { return nMetric; }
diff --git a/editeng/source/editeng/editview.cxx b/editeng/source/editeng/editview.cxx
index 654f5f34077f..23deae365db8 100644
--- a/editeng/source/editeng/editview.cxx
+++ b/editeng/source/editeng/editview.cxx
@@ -596,7 +596,7 @@ void EditView::Cut()
     pImpEditView->CutCopy( aClipBoard, true );
 }
 
-css::uno::Reference< css::datatransfer::XTransferable > EditView::GetTransferable()
+css::uno::Reference< css::datatransfer::XTransferable > EditView::GetTransferable() const
 {
     uno::Reference< datatransfer::XTransferable > xData =
         GetEditEngine()->CreateTransferable( pImpEditView->GetEditSelection() );
@@ -632,7 +632,7 @@ void EditView::SetSelectionMode( EESelectionMode eMode )
     pImpEditView->SetSelectionMode( eMode );
 }
 
-OUString EditView::GetSelected()
+OUString EditView::GetSelected() const
 {
     return pImpEditView->pEditEngine->pImpEditEngine->GetSelected( pImpEditView->GetEditSelection() );
 }
@@ -1250,7 +1250,7 @@ void EditView::SelectFieldAtCursor()
     }
 }
 
-const SvxFieldData* EditView::GetFieldAtCursor()
+const SvxFieldData* EditView::GetFieldAtCursor() const
 {
     const SvxFieldItem* pFieldItem = GetFieldUnderMousePointer();
     if (!pFieldItem)
diff --git a/editeng/source/editeng/eerdll.cxx b/editeng/source/editeng/eerdll.cxx
index 63b6cde77566..48bc52ed6485 100644
--- a/editeng/source/editeng/eerdll.cxx
+++ b/editeng/source/editeng/eerdll.cxx
@@ -212,7 +212,7 @@ editeng::SharedVclResources::SharedVclResources()
 editeng::SharedVclResources::~SharedVclResources()
     { m_pVirDev.disposeAndClear(); }
 
-VclPtr<VirtualDevice> const & editeng::SharedVclResources::GetVirtualDevice()
+VclPtr<VirtualDevice> const & editeng::SharedVclResources::GetVirtualDevice() const
     { return m_pVirDev; }
 
 std::shared_ptr<editeng::SharedVclResources> EditDLL::GetSharedVclResources()
diff --git a/editeng/source/editeng/impedit.cxx b/editeng/source/editeng/impedit.cxx
index a827c87d8d4b..45192712de69 100644
--- a/editeng/source/editeng/impedit.cxx
+++ b/editeng/source/editeng/impedit.cxx
@@ -1278,14 +1278,14 @@ Pair ImpEditView::Scroll( long ndX, long ndY, ScrollRangeCheck nRangeCheck )
     return Pair( nRealDiffX, nRealDiffY );
 }
 
-Reference<css::datatransfer::clipboard::XClipboard> ImpEditView::GetClipboard()
+Reference<css::datatransfer::clipboard::XClipboard> ImpEditView::GetClipboard() const
 {
     if (vcl::Window* pWindow = GetWindow())
         return pWindow->GetClipboard();
     return GetSystemClipboard();
 }
 
-Reference<css::datatransfer::clipboard::XClipboard> ImpEditView::GetSelection()
+Reference<css::datatransfer::clipboard::XClipboard> ImpEditView::GetSelection() const
 {
     if (vcl::Window* pWindow = GetWindow())
         return pWindow->GetPrimarySelection();
diff --git a/editeng/source/editeng/impedit.hxx b/editeng/source/editeng/impedit.hxx
index 0ef1130322c0..6e065352ee68 100644
--- a/editeng/source/editeng/impedit.hxx
+++ b/editeng/source/editeng/impedit.hxx
@@ -282,8 +282,8 @@ private:
 
     void InvalidateAtWindow(const tools::Rectangle& rRect);
 
-    css::uno::Reference<css::datatransfer::clipboard::XClipboard> GetClipboard();
-    css::uno::Reference<css::datatransfer::clipboard::XClipboard> GetSelection();
+    css::uno::Reference<css::datatransfer::clipboard::XClipboard> GetClipboard() const;
+    css::uno::Reference<css::datatransfer::clipboard::XClipboard> GetSelection() const;
 
 protected:
 
@@ -342,7 +342,7 @@ public:
     long            GetVisDocBottom() const { return aVisDocStartPos.Y() + ( !IsVertical() ? aOutArea.GetHeight() : aOutArea.GetWidth() ); }
     tools::Rectangle       GetVisDocArea() const;
 
-    const EditSelection&  GetEditSelection()          { return aEditSelection; }
+    const EditSelection&  GetEditSelection() const { return aEditSelection; }
     void            SetEditSelection( const EditSelection& rEditSelection );
     bool            HasSelection() const { return aEditSelection.HasRange(); }
 
@@ -791,9 +791,9 @@ public:
     void                    UpdateSelections();
 
     void                EnableUndo( bool bEnable );
-    bool                IsUndoEnabled()         { return bUndoEnabled; }
+    bool                IsUndoEnabled() const   { return bUndoEnabled; }
     void                SetUndoMode( bool b )   { bIsInUndo = b; }
-    bool                IsInUndo()              { return bIsInUndo; }
+    bool                IsInUndo() const        { return bIsInUndo; }
 
     void                SetCallParaInsertedOrDeleted( bool b ) { bCallParaInsertedOrDeleted = b; }
     bool                IsCallParaInsertedOrDeleted() const { return bCallParaInsertedOrDeleted; }
@@ -864,7 +864,7 @@ public:
     void            SetModifyHdl( const Link<LinkParamNone*,void>& rLink ) { aModifyHdl = rLink; }
     const Link<LinkParamNone*,void>& GetModifyHdl() const { return aModifyHdl; }
 
-    bool            IsInSelectionMode() { return bInSelection; }
+    bool            IsInSelectionMode() const { return bInSelection; }
 
 //  For Undo/Redo
     void            Undo( EditView* pView );
@@ -908,7 +908,7 @@ public:
     OutputDevice*       GetRefDevice() const { return pRefDev.get(); }
     void                SetRefDevice( OutputDevice* pRefDef );
 
-    const MapMode&      GetRefMapMode() { return pRefDev->GetMapMode(); }
+    const MapMode&      GetRefMapMode() const { return pRefDev->GetMapMode(); }
     void                SetRefMapMode( const MapMode& rMapMode );
 
     InternalEditStatus& GetStatus() { return aStatus; }
diff --git a/editeng/source/misc/urlfieldhelper.cxx b/editeng/source/misc/urlfieldhelper.cxx
index ea1a4f02336f..6df7171e14c0 100644
--- a/editeng/source/misc/urlfieldhelper.cxx
+++ b/editeng/source/misc/urlfieldhelper.cxx
@@ -12,7 +12,7 @@
 #include <editeng/flditem.hxx>
 #include <editeng/editview.hxx>
 
-void URLFieldHelper::RemoveURLField(Outliner* pOutl, OutlinerView* pOLV)
+void URLFieldHelper::RemoveURLField(Outliner* pOutl, const OutlinerView* pOLV)
 {
     if (!pOutl || !pOLV)
         return;
@@ -26,7 +26,7 @@ void URLFieldHelper::RemoveURLField(Outliner* pOutl, OutlinerView* pOLV)
     }
 }
 
-bool URLFieldHelper::IsCursorAtURLField(OutlinerView* pOLV)
+bool URLFieldHelper::IsCursorAtURLField(const OutlinerView* pOLV)
 {
     if (!pOLV)
         return false;
diff --git a/editeng/source/outliner/outleeng.cxx b/editeng/source/outliner/outleeng.cxx
index 87144b6f4938..eb9881e89efd 100644
--- a/editeng/source/outliner/outleeng.cxx
+++ b/editeng/source/outliner/outleeng.cxx
@@ -91,7 +91,7 @@ void OutlinerEditEng::ParagraphDeleted( sal_Int32 nDeletedParagraph )
 
 void OutlinerEditEng::ParagraphConnected( sal_Int32 /*nLeftParagraph*/, sal_Int32 nRightParagraph )
 {
-    if( pOwner && pOwner->IsUndoEnabled() && !const_cast<EditEngine&>(pOwner->GetEditEngine()).IsInUndo() )
+    if( pOwner && pOwner->IsUndoEnabled() && !pOwner->GetEditEngine().IsInUndo() )
     {
         Paragraph* pPara = pOwner->GetParagraph( nRightParagraph );
         if( pPara && Outliner::HasParaFlag( pPara, ParaFlag::ISPAGE ) )
diff --git a/editeng/source/outliner/outlin2.cxx b/editeng/source/outliner/outlin2.cxx
index 2e3e495a6c97..8718c00a3b59 100644
--- a/editeng/source/outliner/outlin2.cxx
+++ b/editeng/source/outliner/outlin2.cxx
@@ -313,7 +313,7 @@ void Outliner::InsertUndo( std::unique_ptr<EditUndo> pUndo )
     pEditEngine->GetUndoManager().AddUndoAction( std::move(pUndo) );
 }
 
-bool Outliner::IsInUndo()
+bool Outliner::IsInUndo() const
 {
     return pEditEngine->IsInUndo();
 }
diff --git a/editeng/source/outliner/outlvw.cxx b/editeng/source/outliner/outlvw.cxx
index 19bcfe31688f..26a8f6ca2f3d 100644
--- a/editeng/source/outliner/outlvw.cxx
+++ b/editeng/source/outliner/outlvw.cxx
@@ -1266,7 +1266,7 @@ void OutlinerView::TransliterateText( TransliterationFlags nTransliterationMode
     pEditView->TransliterateText( nTransliterationMode );
 }
 
-ESelection OutlinerView::GetSelection()
+ESelection OutlinerView::GetSelection() const
 {
     return pEditView->GetSelection();
 }
@@ -1317,7 +1317,7 @@ const SvxFieldItem* OutlinerView::GetFieldAtSelection() const
     return pEditView->GetFieldAtSelection();
 }
 
-const SvxFieldData* OutlinerView::GetFieldAtCursor()
+const SvxFieldData* OutlinerView::GetFieldAtCursor() const
 {
     return pEditView->GetFieldAtCursor();
 }
@@ -1386,7 +1386,7 @@ void OutlinerView::RegisterViewShell(OutlinerViewShell* pViewShell)
     pEditView->RegisterViewShell(pViewShell);
 }
 
-Color const & OutlinerView::GetBackgroundColor()
+Color const & OutlinerView::GetBackgroundColor() const
 {
     return pEditView->GetBackgroundColor();
 }
diff --git a/include/editeng/AccessibleContextBase.hxx b/include/editeng/AccessibleContextBase.hxx
index 23a91f817d1c..9c5027f4d9c3 100644
--- a/include/editeng/AccessibleContextBase.hxx
+++ b/include/editeng/AccessibleContextBase.hxx
@@ -288,7 +288,7 @@ protected:
         @return TRUE, if the object is disposed or in the course
         of being disposed. Otherwise, FALSE is returned.
     */
-    bool IsDisposed();
+    bool IsDisposed() const;
 
     /** sets the role as returned by XaccessibleContext::getAccessibleRole
 
diff --git a/include/editeng/editeng.hxx b/include/editeng/editeng.hxx
index 64581f930aab..73a2b5eba5f6 100644
--- a/include/editeng/editeng.hxx
+++ b/include/editeng/editeng.hxx
@@ -205,7 +205,7 @@ public:
     OutputDevice*   GetRefDevice() const;
 
     void            SetRefMapMode( const MapMode& rMapMode );
-    MapMode const & GetRefMapMode();
+    MapMode const & GetRefMapMode() const;
 
     void            SetUpdateMode( bool bUpdate );
     bool            GetUpdateMode() const;
@@ -334,10 +334,10 @@ public:
     void            UndoActionStart( sal_uInt16 nId );
     void            UndoActionStart(sal_uInt16 nId, const ESelection& rSel);
     void            UndoActionEnd();
-    bool            IsInUndo();
+    bool            IsInUndo() const;
 
     void            EnableUndo( bool bEnable );
-    bool            IsUndoEnabled();
+    bool            IsUndoEnabled() const;
 
     /** returns the value last used for bTryMerge while calling ImpEditEngine::InsertUndo
         This is currently used in a bad but needed hack to get undo actions merged in the
diff --git a/include/editeng/editobj.hxx b/include/editeng/editobj.hxx
index 46a05372b3dd..360c3ce0d48b 100644
--- a/include/editeng/editobj.hxx
+++ b/include/editeng/editobj.hxx
@@ -123,7 +123,7 @@ public:
         const OUString& rOldName, SfxStyleFamily eOldFamily, const OUString& rNewName, SfxStyleFamily eNewFamily);
     void ChangeStyleSheetName(SfxStyleFamily eFamily, const OUString& rOldName, const OUString& rNewName);
 
-    editeng::FieldUpdater GetFieldUpdater();
+    editeng::FieldUpdater GetFieldUpdater() const;
 
     bool operator==( const EditTextObject& rCompare ) const;
 
diff --git a/include/editeng/editview.hxx b/include/editeng/editview.hxx
index a47da81cb8a4..6fb972182357 100644
--- a/include/editeng/editview.hxx
+++ b/include/editeng/editview.hxx
@@ -177,7 +177,7 @@ public:
     bool            IsInsertMode() const;
     void            SetInsertMode( bool bInsert );
 
-    OUString        GetSelected();
+    OUString        GetSelected() const;
     void            DeleteSelected();
 
     SvtScriptType       GetSelectedScriptType() const;
@@ -244,7 +244,7 @@ public:
     void            InsertText( const EditTextObject& rTextObject );
     void            InsertText( css::uno::Reference< css::datatransfer::XTransferable > const & xDataObj, const OUString& rBaseURL, bool bUseSpecial );
 
-    css::uno::Reference< css::datatransfer::XTransferable > GetTransferable();
+    css::uno::Reference< css::datatransfer::XTransferable > GetTransferable() const;
 
     // An EditView, so that when TRUE the update will be free from flickering:
     void            SetEditEngineUpdateMode( bool bUpdate );
@@ -278,7 +278,7 @@ public:
 
     const SvxFieldItem* GetFieldAtSelection() const;
     /// Select and return the field at the current cursor position
-    const SvxFieldData* GetFieldAtCursor();
+    const SvxFieldData* GetFieldAtCursor() const;
     void SelectFieldAtCursor();
 
     void            SetInvalidateMore( sal_uInt16 nPixel );
diff --git a/include/editeng/outliner.hxx b/include/editeng/outliner.hxx
index 787434031b33..f62f3e0fde15 100644
--- a/include/editeng/outliner.hxx
+++ b/include/editeng/outliner.hxx
@@ -253,7 +253,7 @@ public:
     void        CollapseAll();
 
     void        SetBackgroundColor( const Color& rColor );
-    Color const & GetBackgroundColor();
+    Color const & GetBackgroundColor() const;
 
     /// Informs this edit view about which view shell contains it.
     void RegisterViewShell(OutlinerViewShell* pViewShell);
@@ -286,7 +286,7 @@ public:
 
     void            TransliterateText( TransliterationFlags nTransliterationMode );
 
-    ESelection      GetSelection();
+    ESelection      GetSelection() const;
 
     SvtScriptType   GetSelectedScriptType() const;
 
@@ -302,7 +302,7 @@ public:
     const SvxFieldItem* GetFieldUnderMousePointer() const;
     const SvxFieldItem* GetFieldAtSelection() const;
     /// Return the field at the current cursor position or nullptr if no field found
-    const SvxFieldData* GetFieldAtCursor();
+    const SvxFieldData* GetFieldAtCursor() const;
     /// Select the field at the current cursor position
     void SelectFieldAtCursor();
 
@@ -721,7 +721,7 @@ public:
     void            UndoActionStart( sal_uInt16 nId );
     void            UndoActionEnd();
     void            InsertUndo( std::unique_ptr<EditUndo> pUndo );
-    bool            IsInUndo();
+    bool            IsInUndo() const;
 
     void            ClearModifyFlag();
     bool            IsModified() const;
diff --git a/include/editeng/splwrap.hxx b/include/editeng/splwrap.hxx
index 8443b9bb437b..705fedd8ea33 100644
--- a/include/editeng/splwrap.hxx
+++ b/include/editeng/splwrap.hxx
@@ -90,15 +90,15 @@ public:
     static void         ShowLanguageErrors();
 
     void            SpellDocument();        // Perform Spell Checking
-    bool     IsStartDone(){ return bStartDone; }
-    bool     IsEndDone(){ return bEndDone; }
-    bool     IsHyphen(){ return bHyphen; } // Split instead of Spell check
+    bool     IsStartDone() const { return bStartDone; }
+    bool     IsEndDone() const { return bEndDone; }
+    bool     IsHyphen() const { return bHyphen; } // Split instead of Spell check
     void     SetHyphen() { bHyphen = true; }
-    bool     IsAllRight()        { return bAllRight; }
+    bool     IsAllRight() const { return bAllRight; }
 
 protected:
     const css::uno::Reference< css::uno::XInterface >&
-                     GetLast()      { return xLast; }
+                     GetLast() const { return xLast; }
     void             SetLast(const css::uno::Reference< css::uno::XInterface >  &xNewLast)
                             { xLast = xNewLast; }
     virtual bool SpellMore();               // examine further documents?
diff --git a/include/editeng/urlfieldhelper.hxx b/include/editeng/urlfieldhelper.hxx
index a2f20b560065..547e2654ea9b 100644
--- a/include/editeng/urlfieldhelper.hxx
+++ b/include/editeng/urlfieldhelper.hxx
@@ -16,8 +16,8 @@
 class EDITENG_DLLPUBLIC URLFieldHelper
 {
 public:
-    static void RemoveURLField(Outliner* pOutl, OutlinerView* pOLV);
-    static bool IsCursorAtURLField(OutlinerView* pOLV);
+    static void RemoveURLField(Outliner* pOutl, const OutlinerView* pOLV);
+    static bool IsCursorAtURLField(const OutlinerView* pOLV);
 };
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */
diff --git a/svx/source/unodraw/unoshtxt.cxx b/svx/source/unodraw/unoshtxt.cxx
index 0e8acc23db42..64e13012ac86 100644
--- a/svx/source/unodraw/unoshtxt.cxx
+++ b/svx/source/unodraw/unoshtxt.cxx
@@ -504,7 +504,7 @@ SvxTextForwarder* SvxTextEditSourceImpl::GetBackgroundTextForwarder()
             if( mbIsLocked )
             {
                 const_cast<EditEngine*>(&(mpOutliner->GetEditEngine()))->SetUpdateMode( false );
-                mbOldUndoMode = const_cast<EditEngine*>(&(mpOutliner->GetEditEngine()))->IsUndoEnabled();
+                mbOldUndoMode = mpOutliner->GetEditEngine().IsUndoEnabled();
                 const_cast<EditEngine*>(&(mpOutliner->GetEditEngine()))->EnableUndo( false );
             }
 
@@ -809,7 +809,7 @@ void SvxTextEditSourceImpl::lock()
     if( mpOutliner )
     {
         const_cast<EditEngine*>(&(mpOutliner->GetEditEngine()))->SetUpdateMode( false );
-        mbOldUndoMode = const_cast<EditEngine*>(&(mpOutliner->GetEditEngine()))->IsUndoEnabled();
+        mbOldUndoMode = mpOutliner->GetEditEngine().IsUndoEnabled();
         const_cast<EditEngine*>(&(mpOutliner->GetEditEngine()))->EnableUndo( false );
     }
 }