diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-05-25 11:29:44 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-05-25 13:56:03 +0200 |
| commit | 080fa092f466d5ba457852736a3fd6c6cb0dc4b8 (patch) | |
| tree | 48694c48fec2624940eb9f325c6a6e64bbb49b1f | |
| parent | 726d7e7b8b50dca9914329dbfd9491f7c8961f68 (diff) | |
improve some logging
if we're going to write "unhandled" messages, at least what is being
unhandled
Change-Id: I570183c92876d553f4344b979def653cbd5bb55d
Reviewed-on: https://gerrit.libreoffice.org/54793
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
| -rw-r--r-- | oox/source/export/chartexport.cxx | 2 | ||||
| -rw-r--r-- | oox/source/export/drawingml.cxx | 2 | ||||
| -rw-r--r-- | sc/source/filter/lotus/lotform.cxx | 4 | ||||
| -rw-r--r-- | svx/source/accessibility/AccessibleTextHelper.cxx | 5 |
4 files changed, 7 insertions, 6 deletions
diff --git a/oox/source/export/chartexport.cxx b/oox/source/export/chartexport.cxx index bd91390d5f3c..9f170eaa53e8 100644 --- a/oox/source/export/chartexport.cxx +++ b/oox/source/export/chartexport.cxx @@ -1239,7 +1239,7 @@ void ChartExport::exportManualLayout(const css::chart2::RelativePosition& rPos, x -= w; break; default: - SAL_WARN("oox", "unhandled alignment case for manual layout export"); + SAL_WARN("oox", "unhandled alignment case for manual layout export " << static_cast<sal_uInt16>(rPos.Anchor)); } pFS->singleElement(FSNS(XML_c, XML_x), diff --git a/oox/source/export/drawingml.cxx b/oox/source/export/drawingml.cxx index 1c0be28fdaf9..25ea475b2ac4 100644 --- a/oox/source/export/drawingml.cxx +++ b/oox/source/export/drawingml.cxx @@ -891,7 +891,7 @@ OUString DrawingML::WriteImage( const Graphic& rGraphic , bool bRelPathToMedia ) } else { - SAL_WARN("oox.shape", "unhandled graphic type" ); + SAL_WARN("oox.shape", "unhandled graphic type " << static_cast<int>(aType) ); /*Earlier, even in case of unhandled graphic types we were proceeding to write the image, which would eventually write an empty image with a zero size, and return a valid diff --git a/sc/source/filter/lotus/lotform.cxx b/sc/source/filter/lotus/lotform.cxx index 4000b3c1a4ea..cbf29f667bb7 100644 --- a/sc/source/filter/lotus/lotform.cxx +++ b/sc/source/filter/lotus/lotform.cxx @@ -287,7 +287,7 @@ void LotusToSc::LotusRelToScRel( sal_uInt16 nCol, sal_uInt16 nRow, ScSingleRefDa nRow &= 0x1FFF; break; default: - SAL_WARN( "sc.filter", "*LotusToSc::LotusRelToScRel(): unhandled case?" ); + SAL_WARN( "sc.filter", "*LotusToSc::LotusRelToScRel(): unhandled case? " << m_rContext.eTyp ); } } else @@ -307,7 +307,7 @@ void LotusToSc::LotusRelToScRel( sal_uInt16 nCol, sal_uInt16 nRow, ScSingleRefDa nRow &= 0x3FFF; break; default: - SAL_WARN( "sc.filter", "*LotusToSc::LotusRelToScRel(): unhandled case?" ); + SAL_WARN( "sc.filter", "*LotusToSc::LotusRelToScRel(): unhandled case? " << m_rContext.eTyp ); } } diff --git a/svx/source/accessibility/AccessibleTextHelper.cxx b/svx/source/accessibility/AccessibleTextHelper.cxx index 2707d768c273..f19e3a518c47 100644 --- a/svx/source/accessibility/AccessibleTextHelper.cxx +++ b/svx/source/accessibility/AccessibleTextHelper.cxx @@ -66,6 +66,7 @@ #include <editeng/editdata.hxx> #include <editeng/editeng.hxx> #include <editeng/editview.hxx> +#include <tools/diagnose_ex.h> using namespace ::com::sun::star; using namespace ::com::sun::star::accessibility; @@ -1285,7 +1286,7 @@ namespace accessibility } catch( const uno::Exception& ) { - SAL_WARN("svx", "Unhandled exception."); + DBG_UNHANDLED_EXCEPTION("svx"); } } } @@ -1399,7 +1400,7 @@ namespace accessibility } catch( const uno::Exception& ) { - SAL_WARN("svx", "Unhandled exception."); + DBG_UNHANDLED_EXCEPTION("svx"); mbInNotify = false; } |