cppcheck: noExplicitConstructor

Change-Id: I68310e2abc8f0ca114adb2b52f82157a0f455202

21 files changed, 43 insertions, 36 deletions

diff --git a/cui/source/customize/cfg.cxx b/cui/source/customize/cfg.cxx
index ed88815bc6f2..d89f288a1dcf 100644
--- a/cui/source/customize/cfg.cxx
+++ b/cui/source/customize/cfg.cxx
@@ -1555,9 +1555,10 @@ void ContextMenuSaveInData::Reset()
 class PopupPainter : public SvLBoxString
 {
 public:
-    PopupPainter( const OUString& rStr )
-        : SvLBoxString( rStr )
-    { }
+    explicit PopupPainter(const OUString& rStr)
+        : SvLBoxString(rStr)
+    {
+    }
 
     virtual ~PopupPainter() { }
 
diff --git a/cui/source/options/optHeaderTabListbox.cxx b/cui/source/options/optHeaderTabListbox.cxx
index 5a6039b42ac2..15ea670b8fc7 100644
--- a/cui/source/options/optHeaderTabListbox.cxx
+++ b/cui/source/options/optHeaderTabListbox.cxx
@@ -31,8 +31,10 @@ namespace svx
 class OptLBoxString_Impl : public SvLBoxString
 {
 public:
-    OptLBoxString_Impl( const OUString& rTxt ) :
-        SvLBoxString( rTxt ) {}
+    explicit OptLBoxString_Impl(const OUString& rTxt)
+        : SvLBoxString(rTxt)
+    {
+    }
 
     virtual void Paint(const Point& rPos, SvTreeListBox& rDev, vcl::RenderContext& rRenderContext,
                        const SvViewDataEntry* pView, const SvTreeListEntry& rEntry) override;
diff --git a/cui/source/options/optlingu.cxx b/cui/source/options/optlingu.cxx
index 450f0eca0526..fd1cdd5dcdb8 100644
--- a/cui/source/options/optlingu.cxx
+++ b/cui/source/options/optlingu.cxx
@@ -260,7 +260,7 @@ class BrwStringDic_Impl : public SvLBoxString
 {
 public:
 
-    BrwStringDic_Impl( const OUString& rStr ) : SvLBoxString( rStr ) {}
+    explicit BrwStringDic_Impl( const OUString& rStr ) : SvLBoxString( rStr ) {}
 
     virtual void Paint(const Point& rPos, SvTreeListBox& rOutDev, vcl::RenderContext& rRenderContext,
                        const SvViewDataEntry* pView, const SvTreeListEntry& rEntry) override;
@@ -436,7 +436,7 @@ class BrwString_Impl : public SvLBoxString
 {
 public:
 
-    BrwString_Impl( const OUString& rStr ) : SvLBoxString( rStr ) {}
+    explicit BrwString_Impl( const OUString& rStr ) : SvLBoxString( rStr ) {}
 
     virtual void Paint(const Point& rPos, SvTreeListBox& rOutDev, vcl::RenderContext& rRenderContext,
                        const SvViewDataEntry* pView, const SvTreeListEntry& rEntry) override;
diff --git a/cui/source/tabpages/autocdlg.cxx b/cui/source/tabpages/autocdlg.cxx
index 3122aaeec818..4dccaf5238b5 100644
--- a/cui/source/tabpages/autocdlg.cxx
+++ b/cui/source/tabpages/autocdlg.cxx
@@ -330,7 +330,7 @@ class OfaImpBrwString : public SvLBoxString
 {
 public:
 
-    OfaImpBrwString( const OUString& rStr ) : SvLBoxString(rStr){}
+    explicit OfaImpBrwString( const OUString& rStr ) : SvLBoxString(rStr){}
 
     virtual void Paint(const Point& rPos, SvTreeListBox& rDev, vcl::RenderContext& rRenderContext,
                        const SvViewDataEntry* pView, const SvTreeListEntry& rEntry) override;
diff --git a/dbaccess/source/core/api/RowSet.cxx b/dbaccess/source/core/api/RowSet.cxx
index 0e058ac78b0e..1016977dfea9 100644
--- a/dbaccess/source/core/api/RowSet.cxx
+++ b/dbaccess/source/core/api/RowSet.cxx
@@ -868,7 +868,7 @@ namespace
     {
         bool& m_rInsertingRow;
     public:
-        ProtectFlag(bool& rInsertingRow)
+        explicit ProtectFlag(bool& rInsertingRow)
             : m_rInsertingRow(rInsertingRow)
         {
             if (m_rInsertingRow)
diff --git a/desktop/source/deployment/manager/dp_activepackages.hxx b/desktop/source/deployment/manager/dp_activepackages.hxx
index 70770bad2cc7..93b593041fbd 100644
--- a/desktop/source/deployment/manager/dp_activepackages.hxx
+++ b/desktop/source/deployment/manager/dp_activepackages.hxx
@@ -65,7 +65,7 @@ public:
 
     ActivePackages();
 
-    ActivePackages(OUString const & url);
+    explicit ActivePackages(OUString const & url);
 
     ~ActivePackages();
 
diff --git a/extensions/source/bibliography/loadlisteneradapter.hxx b/extensions/source/bibliography/loadlisteneradapter.hxx
index 5e7f4e4c4c76..28e3e39ec999 100644
--- a/extensions/source/bibliography/loadlisteneradapter.hxx
+++ b/extensions/source/bibliography/loadlisteneradapter.hxx
@@ -132,7 +132,7 @@ namespace bib
         virtual void    startComponentListening() override;
 
     public:
-        OLoadListenerAdapter(
+        explicit OLoadListenerAdapter(
             const css::uno::Reference< css::form::XLoadable >& _rxLoadable
         );
 
diff --git a/sc/source/ui/miscdlgs/solveroptions.cxx b/sc/source/ui/miscdlgs/solveroptions.cxx
index b222be3ff0b8..9f9481dc5ab5 100644
--- a/sc/source/ui/miscdlgs/solveroptions.cxx
+++ b/sc/source/ui/miscdlgs/solveroptions.cxx
@@ -60,11 +60,13 @@ class ScSolverOptionsString : public SvLBoxString
     sal_Int32   mnIntValue;
 
 public:
-    ScSolverOptionsString( const OUString& rStr ) :
-        SvLBoxString( rStr ),
-        mbIsDouble( false ),
-        mfDoubleValue( 0.0 ),
-        mnIntValue( 0 ) {}
+    explicit ScSolverOptionsString(const OUString& rStr)
+        : SvLBoxString(rStr)
+        , mbIsDouble(false)
+        , mfDoubleValue(0.0)
+        , mnIntValue(0)
+    {
+    }
 
     bool      IsDouble() const        { return mbIsDouble; }
     double    GetDoubleValue() const  { return mfDoubleValue; }
diff --git a/sd/source/ui/animations/CustomAnimationList.cxx b/sd/source/ui/animations/CustomAnimationList.cxx
index 07138faa9c04..0c64fededbdf 100644
--- a/sd/source/ui/animations/CustomAnimationList.cxx
+++ b/sd/source/ui/animations/CustomAnimationList.cxx
@@ -377,7 +377,7 @@ CustomAnimationListEntry::~CustomAnimationListEntry()
 class CustomAnimationTriggerEntryItem : public SvLBoxString
 {
 public:
-                    CustomAnimationTriggerEntryItem( const OUString& aDescription );
+    explicit        CustomAnimationTriggerEntryItem( const OUString& aDescription );
     virtual         ~CustomAnimationTriggerEntryItem();
     void            InitViewData( SvTreeListBox*,SvTreeListEntry*,SvViewDataItem* ) override;
     SvLBoxItem*     Create() const override;
diff --git a/sd/source/ui/animations/STLPropertySet.hxx b/sd/source/ui/animations/STLPropertySet.hxx
index 058e36ef8e3e..34050c087c57 100644
--- a/sd/source/ui/animations/STLPropertySet.hxx
+++ b/sd/source/ui/animations/STLPropertySet.hxx
@@ -39,7 +39,7 @@ struct STLPropertyMapEntry
 
     STLPropertyMapEntry()
         : mnState( STLPropertyState_AMBIGUOUS ) {}
-    STLPropertyMapEntry( css::uno::Any aValue )
+    explicit STLPropertyMapEntry(css::uno::Any aValue)
         : maValue( aValue ), mnState( STLPropertyState_DEFAULT ) {}
 
 };
diff --git a/sd/source/ui/dlg/filedlg.cxx b/sd/source/ui/dlg/filedlg.cxx
index 3b05fa2f4cd8..6dce79eb5468 100644
--- a/sd/source/ui/dlg/filedlg.cxx
+++ b/sd/source/ui/dlg/filedlg.cxx
@@ -64,7 +64,7 @@ private:
                                 DECL_LINK_TYPED( IsMusicStoppedHdl, Idle *, void );
 
 public:
-                                SdFileDialog_Imp( const short nDialogType );
+                       explicit SdFileDialog_Imp( const short nDialogType );
                        virtual ~SdFileDialog_Imp();
 
     ErrCode                     Execute();
diff --git a/sd/source/ui/inc/optsitem.hxx b/sd/source/ui/inc/optsitem.hxx
index c0bf17a9f9d9..88cf3e8874b2 100644
--- a/sd/source/ui/inc/optsitem.hxx
+++ b/sd/source/ui/inc/optsitem.hxx
@@ -420,8 +420,8 @@ protected:
 
 public:
 
-            SdOptionsZoom( sal_uInt16 nConfigId );
-            virtual ~SdOptionsZoom() {}
+    explicit SdOptionsZoom(sal_uInt16 nConfigId);
+    virtual ~SdOptionsZoom() {}
 
     void    GetScale( sal_Int32& rX, sal_Int32& rY ) const { Init(); rX = nX; rY = nY; }
     void    SetScale( sal_Int32 nInX, sal_Int32 nInY ) { if( nX != nInX || nY != nInY ) { OptionsChanged(); nX = nInX; nY = nInY; } }
@@ -437,8 +437,8 @@ protected:
 
 public:
 
-            SdOptionsGrid( sal_uInt16 nConfigId );
-            virtual ~SdOptionsGrid();
+    explicit SdOptionsGrid(sal_uInt16 nConfigId);
+    virtual ~SdOptionsGrid();
 
     void    SetDefaults();
 
diff --git a/sfx2/source/view/ipclient.cxx b/sfx2/source/view/ipclient.cxx
index 807b5c98ac68..cd3f783fc9dd 100644
--- a/sfx2/source/view/ipclient.cxx
+++ b/sfx2/source/view/ipclient.cxx
@@ -73,9 +73,9 @@ class SfxBooleanFlagGuard
     bool& m_rFlag;
     bool  m_bLifeValue;
 public:
-    SfxBooleanFlagGuard( bool& bFlag )
-    : m_rFlag( bFlag )
-    , m_bLifeValue( true )
+    explicit SfxBooleanFlagGuard(bool& bFlag)
+        : m_rFlag( bFlag )
+        , m_bLifeValue( true )
     {
         m_rFlag = m_bLifeValue;
     }
diff --git a/slideshow/source/engine/screenupdater.cxx b/slideshow/source/engine/screenupdater.cxx
index c4fb585c9d2e..43d483015568 100644
--- a/slideshow/source/engine/screenupdater.cxx
+++ b/slideshow/source/engine/screenupdater.cxx
@@ -31,7 +31,7 @@ namespace {
     class UpdateLock : public ::slideshow::internal::ScreenUpdater::UpdateLock
     {
     public:
-        UpdateLock (::slideshow::internal::ScreenUpdater& rUpdater);
+        explicit UpdateLock (::slideshow::internal::ScreenUpdater& rUpdater);
         virtual ~UpdateLock();
         virtual void Activate() override;
     private:
diff --git a/svx/source/form/filtnav.cxx b/svx/source/form/filtnav.cxx
index f24ca92c7616..da326d724022 100644
--- a/svx/source/form/filtnav.cxx
+++ b/svx/source/form/filtnav.cxx
@@ -984,8 +984,10 @@ void FmFilterModel::EnsureEmptyFilterRows( FmParentData& _rItem )
 class FmFilterItemsString : public SvLBoxString
 {
 public:
-    FmFilterItemsString( const OUString& rStr )
-        :SvLBoxString(rStr) {}
+    explicit FmFilterItemsString(const OUString& rStr)
+        : SvLBoxString(rStr)
+    {
+    }
 
     virtual void Paint(const Point& rPos, SvTreeListBox& rDev, vcl::RenderContext& rRenderContext,
                        const SvViewDataEntry* pView, const SvTreeListEntry& rEntry) override;
diff --git a/sw/source/ui/dbui/addresslistdialog.cxx b/sw/source/ui/dbui/addresslistdialog.cxx
index db528db9ec0c..ad7797d877af 100644
--- a/sw/source/ui/dbui/addresslistdialog.cxx
+++ b/sw/source/ui/dbui/addresslistdialog.cxx
@@ -135,7 +135,7 @@ static OUString lcl_getFlatURL( uno::Reference<beans::XPropertySet>& xSourceProp
 class SwAddrSourceLB : public SvSimpleTable
 {
 public:
-    SwAddrSourceLB(SvSimpleTableContainer& rParent)
+    explicit SwAddrSourceLB(SvSimpleTableContainer& rParent)
         : SvSimpleTable(rParent, 0)
     {
     }
diff --git a/sw/source/ui/dbui/selectdbtabledialog.cxx b/sw/source/ui/dbui/selectdbtabledialog.cxx
index 549af3928a47..5c02c694bcb8 100644
--- a/sw/source/ui/dbui/selectdbtabledialog.cxx
+++ b/sw/source/ui/dbui/selectdbtabledialog.cxx
@@ -45,7 +45,7 @@ using namespace ::com::sun::star::beans;
 class SwAddressTable : public SvSimpleTable
 {
 public:
-    SwAddressTable(SvSimpleTableContainer& rParent);
+    explicit SwAddressTable(SvSimpleTableContainer& rParent);
     void InsertHeaderItem(sal_uInt16 nColumn, const OUString& rText, HeaderBarItemBits nBits);
     virtual void Resize() override;
     void setColSizes();
diff --git a/sw/source/ui/index/cnttab.cxx b/sw/source/ui/index/cnttab.cxx
index 9bd36380fd02..d6cdcd918376 100644
--- a/sw/source/ui/index/cnttab.cxx
+++ b/sw/source/ui/index/cnttab.cxx
@@ -539,7 +539,7 @@ bool SwMultiTOXTabDialog::IsNoNum(SwWrtShell& rSh, const OUString& rName)
 class SwIndexTreeLB : public SvSimpleTable
 {
 public:
-    SwIndexTreeLB(SvSimpleTableContainer& rParent);
+    explicit SwIndexTreeLB(SvSimpleTableContainer& rParent);
     virtual void KeyInput( const KeyEvent& rKEvt ) override;
     virtual void Resize() override;
     virtual sal_IntPtr GetTabPos( SvTreeListEntry*, SvLBoxTab* ) override;
diff --git a/sw/source/uibase/dbui/mailmergetoolbarcontrols.cxx b/sw/source/uibase/dbui/mailmergetoolbarcontrols.cxx
index 1ad588b2991a..3a23913d288d 100644
--- a/sw/source/uibase/dbui/mailmergetoolbarcontrols.cxx
+++ b/sw/source/uibase/dbui/mailmergetoolbarcontrols.cxx
@@ -44,7 +44,7 @@ class MMCurrentEntryController : public svt::ToolboxController, public lang::XSe
     DECL_LINK_TYPED(CurrentEditUpdatedHdl, Edit&, void);
 
 public:
-    MMCurrentEntryController(const uno::Reference<uno::XComponentContext>& rContext)
+    explicit MMCurrentEntryController(const uno::Reference<uno::XComponentContext>& rContext)
         : svt::ToolboxController(rContext, uno::Reference<frame::XFrame>(), OUString(".uno:MailMergeCurrentEntry"))
         , m_pCurrentEdit(nullptr)
     {
@@ -112,7 +112,7 @@ class MMExcludeEntryController : public svt::ToolboxController, public lang::XSe
     DECL_STATIC_LINK_TYPED(MMExcludeEntryController, ExcludeHdl, CheckBox&, void);
 
 public:
-    MMExcludeEntryController(const uno::Reference<uno::XComponentContext>& rContext)
+    explicit MMExcludeEntryController(const uno::Reference<uno::XComponentContext>& rContext)
         : svt::ToolboxController(rContext, uno::Reference<frame::XFrame>(), OUString(".uno:MailMergeExcludeEntry"))
         , m_pExcludeCheckbox(nullptr)
     {
diff --git a/sw/source/uibase/utlui/content.cxx b/sw/source/uibase/utlui/content.cxx
index b1668522694d..5ad5c931aa18 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -3407,7 +3407,7 @@ bool NaviContentBookmark::Paste( TransferableDataHelper& rData )
 class SwContentLBoxString : public SvLBoxString
 {
 public:
-    SwContentLBoxString( const OUString& rStr ) : SvLBoxString(rStr) {}
+    explicit SwContentLBoxString(const OUString& rStr) : SvLBoxString(rStr) {}
 
     virtual void Paint(const Point& rPos, SvTreeListBox& rDev, vcl::RenderContext& rRenderContext,
                        const SvViewDataEntry* pView, const SvTreeListEntry& rEntry) override;
diff --git a/vcl/source/window/menubarwindow.hxx b/vcl/source/window/menubarwindow.hxx
index 79147edf9344..8565eb03b7bf 100644
--- a/vcl/source/window/menubarwindow.hxx
+++ b/vcl/source/window/menubarwindow.hxx
@@ -41,7 +41,7 @@ class DecoToolBox : public ToolBox
 
     using Window::ImplInit;
 public:
-             DecoToolBox( vcl::Window* pParent );
+    explicit DecoToolBox(vcl::Window* pParent);
     virtual ~DecoToolBox() {}
 
     void    ImplInit();