diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2016-12-15 14:11:16 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2016-12-15 14:11:16 +0200 |
commit | bd6723fd539bb63d230a2f985ac98ff7daafcbff (patch) | |
tree | d29f63c91a021d39b90e74ff66476a29f9e42997 | |
parent | 8ad521d9147df325b7aee27d8e5c670a02e6afcf (diff) |
disable the 'two different log areas in the same file' loplugin check
too many false+ to leave it alive by default
Change-Id: I6d8f92b630c351c1ac788fad79f8d7c435ba4963
-rw-r--r-- | compilerplugins/clang/sallogareas.cxx | 3 | ||||
-rw-r--r-- | compilerplugins/clang/sallogareas.hxx | 2 |
2 files changed, 5 insertions, 0 deletions
diff --git a/compilerplugins/clang/sallogareas.cxx b/compilerplugins/clang/sallogareas.cxx index 85f90e39d25d..d54918755624 100644 --- a/compilerplugins/clang/sallogareas.cxx +++ b/compilerplugins/clang/sallogareas.cxx @@ -110,6 +110,8 @@ void SalLogAreas::checkArea( StringRef area, SourceLocation location ) checkAreaSyntax(area, location); return; } +// don't leave this alive by default, generates too many false+ +#if 0 if (compiler.getSourceManager().isInMainFile(location)) { auto matchpair = [this,area](StringRef p1, StringRef p2) { @@ -166,6 +168,7 @@ void SalLogAreas::checkArea( StringRef area, SourceLocation location ) firstSeenLocation ); } } +#endif } void SalLogAreas::checkAreaSyntax(StringRef area, SourceLocation location) { diff --git a/compilerplugins/clang/sallogareas.hxx b/compilerplugins/clang/sallogareas.hxx index a689ce9ec9ca..9133ed69a111 100644 --- a/compilerplugins/clang/sallogareas.hxx +++ b/compilerplugins/clang/sallogareas.hxx @@ -35,8 +35,10 @@ class SalLogAreas const FunctionDecl* inFunction; SourceLocation lastSalDetailLogStreamMacro; set< string > logAreas; +#if 0 string firstSeenLogArea; SourceLocation firstSeenLocation; +#endif }; } // namespace |