diff options
author | Eike Rathke <erack@redhat.com> | 2016-10-20 00:58:06 +0200 |
---|---|---|
committer | Eike Rathke <erack@redhat.com> | 2016-10-20 00:59:14 +0200 |
commit | 0d2797fdb06f504e7213b3859a53c363f4f56bc9 (patch) | |
tree | f8d652d717c11f1226551646eea2ddb376d84e3a | |
parent | 8c4fdffb2029acf9219633627fa37e5ee4028f5a (diff) |
Resolves: tdf#85553 intern SharedString of cached external references result
Change-Id: I13f19b5bd5f2897eb48af69742be885803cca066
-rw-r--r-- | sc/source/filter/excel/xilink.cxx | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/sc/source/filter/excel/xilink.cxx b/sc/source/filter/excel/xilink.cxx index ebc9b8b4a020..df8f5e3d6e2f 100644 --- a/sc/source/filter/excel/xilink.cxx +++ b/sc/source/filter/excel/xilink.cxx @@ -71,7 +71,8 @@ public: /** Reads a CRN record (external referenced cell) at the specified address. */ void ReadCrn( XclImpStream& rStrm, const XclAddress& rXclPos ); - void LoadCachedValues(const ScExternalRefCache::TableTypeRef& pCacheTable); + void LoadCachedValues( const ScExternalRefCache::TableTypeRef& pCacheTable, + svl::SharedStringPool& rPool ); private: typedef std::shared_ptr< XclImpCrn > XclImpCrnRef; @@ -574,7 +575,8 @@ void XclImpSupbookTab::ReadCrn( XclImpStream& rStrm, const XclAddress& rXclPos ) maCrnList.push_back( crnRef ); } -void XclImpSupbookTab::LoadCachedValues(const ScExternalRefCache::TableTypeRef& pCacheTable) +void XclImpSupbookTab::LoadCachedValues( const ScExternalRefCache::TableTypeRef& pCacheTable, + svl::SharedStringPool& rPool ) { if (maCrnList.empty()) return; @@ -608,8 +610,8 @@ void XclImpSupbookTab::LoadCachedValues(const ScExternalRefCache::TableTypeRef& break; case EXC_CACHEDVAL_STRING: { - const OUString& rStr = pCrn->GetString(); - ScExternalRefCache::TokenRef pToken(new formula::FormulaStringToken( svl::SharedString( rStr))); // string not interned + svl::SharedString aSS( rPool.intern( pCrn->GetString())); + ScExternalRefCache::TokenRef pToken(new formula::FormulaStringToken( aSS)); pCacheTable->setCell(rAddr.mnCol, rAddr.mnRow, pToken, 0, false); } break; @@ -753,7 +755,7 @@ void XclImpSupbook::LoadCachedValues() { const OUString& rTabName = (*itTab)->GetTabName(); ScExternalRefCache::TableTypeRef pCacheTable = pRefMgr->getCacheTable(nFileId, rTabName, true); - (*itTab)->LoadCachedValues(pCacheTable); + (*itTab)->LoadCachedValues( pCacheTable, GetSharedStringPool()); pCacheTable->setWholeTableCached(); } } |