loplugin:unusedmethods

Change-Id: I5fa2bbeff17a9933ff55afb0c3544d025d096a63
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100085
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

5 files changed, 80 insertions, 91 deletions

diff --git a/compilerplugins/clang/unusedmethods.results b/compilerplugins/clang/unusedmethods.results
index ab0940766b3f..6a24160930b2 100644
--- a/compilerplugins/clang/unusedmethods.results
+++ b/compilerplugins/clang/unusedmethods.results
@@ -400,8 +400,6 @@ include/comphelper/basicio.hxx:52
     const class com::sun::star::uno::Reference<class com::sun::star::io::XObjectInputStream> & comphelper::operator>>(const class com::sun::star::uno::Reference<class com::sun::star::io::XObjectInputStream> &,unsigned int &)
 include/comphelper/basicio.hxx:53
     const class com::sun::star::uno::Reference<class com::sun::star::io::XObjectOutputStream> & comphelper::operator<<(const class com::sun::star::uno::Reference<class com::sun::star::io::XObjectOutputStream> &,unsigned int)
-include/comphelper/componentmodule.hxx:49
-     comphelper::OModule::OModule()
 include/comphelper/configuration.hxx:248
     type-parameter-?-? comphelper::ConfigurationLocalizedProperty::get(const class com::sun::star::uno::Reference<class com::sun::star::uno::XComponentContext> &)
 include/comphelper/configuration.hxx:264
@@ -750,21 +748,21 @@ include/tools/datetime.hxx:92
     class DateTime operator+(const class DateTime &,const class tools::Time &)
 include/tools/datetime.hxx:93
     class DateTime operator-(const class DateTime &,const class tools::Time &)
-include/tools/fract.hxx:69
+include/tools/fract.hxx:68
     class Fraction & Fraction::operator+=(double)
-include/tools/fract.hxx:70
+include/tools/fract.hxx:69
     class Fraction & Fraction::operator-=(double)
-include/tools/fract.hxx:86
+include/tools/fract.hxx:85
     _Bool operator>=(const class Fraction &,const class Fraction &)
-include/tools/fract.hxx:105
+include/tools/fract.hxx:104
     class Fraction operator+(const class Fraction &,double)
-include/tools/fract.hxx:106
+include/tools/fract.hxx:105
     class Fraction operator-(const class Fraction &,double)
-include/tools/fract.hxx:108
+include/tools/fract.hxx:107
     class Fraction operator/(const class Fraction &,double)
-include/tools/gen.hxx:259
+include/tools/gen.hxx:258
     class Pair & Range::toPair()
-include/tools/gen.hxx:326
+include/tools/gen.hxx:325
     class Pair & Selection::toPair()
 include/tools/link.hxx:134
     const char * Link::getSourceFilename() const
@@ -780,7 +778,7 @@ include/tools/simd.hxx:21
     type-parameter-?-? simd::roundDown(type-parameter-?-?,unsigned int)
 include/tools/stream.hxx:507
     class rtl::OString read_uInt32_lenPrefixed_uInt8s_ToOString(class SvStream &)
-include/tools/UnitConversion.hxx:30
+include/tools/UnitConversion.hxx:32
     double convertPointToTwip(double)
 include/tools/urlobj.hxx:448
     _Bool INetURLObject::SetHost(const class rtl::OUString &)
@@ -806,15 +804,15 @@ include/vcl/alpha.hxx:48
     _Bool AlphaMask::operator!=(const class AlphaMask &) const
 include/vcl/animate/Animation.hxx:40
     _Bool Animation::operator!=(const class Animation &) const
-include/vcl/animate/AnimationBitmap.hxx:69
+include/vcl/animate/AnimationBitmap.hxx:68
     _Bool AnimationBitmap::operator!=(const struct AnimationBitmap &) const
 include/vcl/BitmapBasicMorphologyFilter.hxx:63
      BitmapDilateFilter::BitmapDilateFilter(int,unsigned char)
 include/vcl/BitmapColor.hxx:39
     void BitmapColor::SetAlpha(unsigned char)
-include/vcl/builder.hxx:338
+include/vcl/builder.hxx:337
     void VclBuilder::connectNumericFormatterAdjustment(const class rtl::OString &,const class rtl::OUString &)
-include/vcl/builder.hxx:480
+include/vcl/builder.hxx:479
     class rtl::OString VclBuilderContainer::getUIFile() const
 include/vcl/builderpage.hxx:36
     void BuilderPage::SetHelpId(const class rtl::OString &)
@@ -870,7 +868,7 @@ include/vcl/lok.hxx:22
     void vcl::lok::unregisterPollCallbacks()
 include/vcl/menu.hxx:517
     void PopupMenu::SetSelectedEntry(unsigned short)
-include/vcl/NotebookBarAddonsMerger.hxx:64
+include/vcl/NotebookBarAddonsMerger.hxx:63
      NotebookBarAddonsMerger::NotebookBarAddonsMerger()
 include/vcl/opengl/OpenGLHelper.hxx:67
     void OpenGLHelper::renderToFile(long,long,const class rtl::OUString &)
@@ -900,11 +898,11 @@ include/vcl/settings.hxx:722
     _Bool AllSettings::operator!=(const class AllSettings &) const
 include/vcl/split.hxx:92
     void Splitter::SetHorizontal(_Bool)
-include/vcl/svapp.hxx:163
+include/vcl/svapp.hxx:162
      ApplicationEvent::ApplicationEvent(enum ApplicationEvent::Type,const class std::__debug::vector<class rtl::OUString, class std::allocator<class rtl::OUString> > &)
-include/vcl/svapp.hxx:796
+include/vcl/svapp.hxx:795
     void Application::AppEvent(const class ApplicationEvent &)
-include/vcl/syswin.hxx:117
+include/vcl/syswin.hxx:116
     void SystemWindow::SetIdleDebugName(const char *)
 include/vcl/TaskStopwatch.hxx:97
     void TaskStopwatch::reset()
@@ -920,113 +918,115 @@ include/vcl/textrectinfo.hxx:45
     _Bool TextRectInfo::operator!=(const class TextRectInfo &) const
 include/vcl/toolkit/longcurr.hxx:49
     class BigInt LongCurrencyFormatter::GetValue() const
-include/vcl/treelist.hxx:171
+include/vcl/treelist.hxx:170
     const class SvTreeListEntry * SvTreeList::GetParent(const class SvTreeListEntry *) const
-include/vcl/treelistbox.hxx:368
+include/vcl/treelistbox.hxx:298
+    _Bool SvTreeListBox::EditingCanceled() const
+include/vcl/treelistbox.hxx:366
     void SvTreeListBox::RemoveSelection()
 include/vcl/txtattr.hxx:56
     _Bool TextAttrib::operator!=(const class TextAttrib &) const
-include/vcl/uitest/uiobject.hxx:280
+include/vcl/uitest/uiobject.hxx:281
      TabPageUIObject::TabPageUIObject(const class VclPtr<class TabPage> &)
-include/vcl/uitest/uiobject.hxx:288
+include/vcl/uitest/uiobject.hxx:289
     class std::unique_ptr<class UIObject, struct std::default_delete<class UIObject> > TabPageUIObject::create(class vcl::Window *)
-include/vcl/uitest/uiobject.hxx:351
+include/vcl/uitest/uiobject.hxx:352
      SpinUIObject::SpinUIObject(const class VclPtr<class SpinButton> &)
-include/vcl/uitest/uiobject.hxx:359
+include/vcl/uitest/uiobject.hxx:360
     class std::unique_ptr<class UIObject, struct std::default_delete<class UIObject> > SpinUIObject::create(class vcl::Window *)
-include/vcl/weld.hxx:128
+include/vcl/weld.hxx:127
     _Bool weld::Widget::get_hexpand() const
-include/vcl/weld.hxx:130
+include/vcl/weld.hxx:129
     _Bool weld::Widget::get_vexpand() const
-include/vcl/weld.hxx:132
+include/vcl/weld.hxx:131
     void weld::Widget::set_secondary(_Bool)
-include/vcl/weld.hxx:137
+include/vcl/weld.hxx:136
     void weld::Widget::set_margin_right(int)
-include/vcl/weld.hxx:139
+include/vcl/weld.hxx:138
     int weld::Widget::get_margin_top() const
-include/vcl/weld.hxx:140
+include/vcl/weld.hxx:139
     int weld::Widget::get_margin_bottom() const
-include/vcl/weld.hxx:142
+include/vcl/weld.hxx:141
     int weld::Widget::get_margin_right() const
-include/vcl/weld.hxx:318
+include/vcl/weld.hxx:317
     void weld::ScrolledWindow::hadjustment_set_step_increment(int)
-include/vcl/weld.hxx:320
+include/vcl/weld.hxx:319
     enum VclPolicyType weld::ScrolledWindow::get_hpolicy() const
-include/vcl/weld.hxx:325
+include/vcl/weld.hxx:324
     int weld::ScrolledWindow::get_hscroll_height() const
-include/vcl/weld.hxx:451
+include/vcl/weld.hxx:450
     struct SystemEnvData weld::Window::get_system_data() const
-include/vcl/weld.hxx:527
+include/vcl/weld.hxx:526
     void weld::AboutDialog::set_version(const class rtl::OUString &)
-include/vcl/weld.hxx:528
+include/vcl/weld.hxx:527
     void weld::AboutDialog::set_copyright(const class rtl::OUString &)
-include/vcl/weld.hxx:529
+include/vcl/weld.hxx:528
     void weld::AboutDialog::set_website(const class rtl::OUString &)
-include/vcl/weld.hxx:530
+include/vcl/weld.hxx:529
     void weld::AboutDialog::set_website_label(const class rtl::OUString &)
-include/vcl/weld.hxx:531
+include/vcl/weld.hxx:530
     class rtl::OUString weld::AboutDialog::get_website_label() const
-include/vcl/weld.hxx:532
+include/vcl/weld.hxx:531
     void weld::AboutDialog::set_logo(const class com::sun::star::uno::Reference<class com::sun::star::graphic::XGraphic> &)
-include/vcl/weld.hxx:533
+include/vcl/weld.hxx:532
     void weld::AboutDialog::set_background(const class com::sun::star::uno::Reference<class com::sun::star::graphic::XGraphic> &)
-include/vcl/weld.hxx:547
+include/vcl/weld.hxx:546
     class rtl::OString weld::Assistant::get_current_page_ident() const
-include/vcl/weld.hxx:553
+include/vcl/weld.hxx:552
     class rtl::OUString weld::Assistant::get_page_title(const class rtl::OString &) const
-include/vcl/weld.hxx:883
+include/vcl/weld.hxx:882
     void weld::TreeView::append(const class weld::TreeIter *,const class rtl::OUString &,const class rtl::OUString &,const class rtl::OUString &)
-include/vcl/weld.hxx:892
+include/vcl/weld.hxx:891
     void weld::TreeView::append(const class rtl::OUString &,const class rtl::OUString &,class VirtualDevice &)
-include/vcl/weld.hxx:998
+include/vcl/weld.hxx:997
     _Bool weld::TreeView::iter_next_visible(class weld::TreeIter &) const
-include/vcl/weld.hxx:1041
+include/vcl/weld.hxx:1040
     void weld::TreeView::set_text_align(const class weld::TreeIter &,double,int)
-include/vcl/weld.hxx:1120
+include/vcl/weld.hxx:1119
     void weld::TreeView::select_all()
-include/vcl/weld.hxx:1167
+include/vcl/weld.hxx:1166
     const class rtl::OUString & weld::TreeView::get_saved_value() const
-include/vcl/weld.hxx:1231
+include/vcl/weld.hxx:1233
     class rtl::OUString weld::IconView::get_selected_id() const
-include/vcl/weld.hxx:1246
+include/vcl/weld.hxx:1248
     _Bool weld::IconView::get_cursor(class weld::TreeIter *) const
-include/vcl/weld.hxx:1256
+include/vcl/weld.hxx:1258
     void weld::IconView::select_all()
-include/vcl/weld.hxx:1262
+include/vcl/weld.hxx:1264
     void weld::IconView::save_value()
-include/vcl/weld.hxx:1263
+include/vcl/weld.hxx:1265
     const class rtl::OUString & weld::IconView::get_saved_value() const
-include/vcl/weld.hxx:1264
+include/vcl/weld.hxx:1266
     _Bool weld::IconView::get_value_changed_from_saved() const
-include/vcl/weld.hxx:1362
+include/vcl/weld.hxx:1364
     void weld::MenuButton::append_item(const class rtl::OUString &,const class rtl::OUString &)
-include/vcl/weld.hxx:1370
+include/vcl/weld.hxx:1372
     void weld::MenuButton::append_item_radio(const class rtl::OUString &,const class rtl::OUString &)
-include/vcl/weld.hxx:1378
+include/vcl/weld.hxx:1380
     void weld::MenuButton::append_item(const class rtl::OUString &,const class rtl::OUString &,class VirtualDevice &)
-include/vcl/weld.hxx:1383
+include/vcl/weld.hxx:1385
     void weld::MenuButton::append_separator(const class rtl::OUString &)
-include/vcl/weld.hxx:1434
+include/vcl/weld.hxx:1436
     void weld::Scale::get_increments(int &,int &) const
-include/vcl/weld.hxx:1451
+include/vcl/weld.hxx:1453
     class rtl::OUString weld::ProgressBar::get_text() const
-include/vcl/weld.hxx:1470
+include/vcl/weld.hxx:1472
     void weld::Entry::signal_insert_text(class rtl::OUString &)
-include/vcl/weld.hxx:1486
+include/vcl/weld.hxx:1488
     int weld::Entry::get_position() const
-include/vcl/weld.hxx:1660
+include/vcl/weld.hxx:1662
     void weld::EntryTreeView::EntryModifyHdl(const class weld::Entry &)
-include/vcl/weld.hxx:1896
+include/vcl/weld.hxx:1898
     class Size weld::MetricSpinButton::get_size_request() const
-include/vcl/weld.hxx:1908
+include/vcl/weld.hxx:1910
     void weld::MetricSpinButton::set_position(int)
-include/vcl/weld.hxx:1989
+include/vcl/weld.hxx:1991
     int weld::TextView::vadjustment_get_lower() const
-include/vcl/weld.hxx:2146
+include/vcl/weld.hxx:2148
     class rtl::OUString weld::Toolbar::get_item_label(const class rtl::OString &) const
-include/vcl/weld.hxx:2156
+include/vcl/weld.hxx:2158
     void weld::Toolbar::append_separator(const class rtl::OUString &)
-include/vcl/weld.hxx:2199
+include/vcl/weld.hxx:2201
     class std::unique_ptr<class weld::Window, struct std::default_delete<class weld::Window> > weld::Builder::weld_window(const class rtl::OString &,_Bool)
 include/vcl/weldutils.hxx:304
     void weld::DateFormatter::CursorChangedHdl(class weld::Entry &)
@@ -1042,7 +1042,7 @@ include/xmloff/txtimp.hxx:386
     class XMLPropertyBackpatcher<short> & XMLTextImportHelper::GetFootnoteBP()
 include/xmloff/txtimp.hxx:387
     class XMLPropertyBackpatcher<short> & XMLTextImportHelper::GetSequenceIdBP()
-include/xmloff/txtimp.hxx:570
+include/xmloff/txtimp.hxx:572
     class rtl::OUString XMLTextImportHelper::FindActiveBookmarkName()
 include/xmloff/xmlnumi.hxx:60
      SvxXMLListStyleContext::SvxXMLListStyleContext(class SvXMLImport &,int,const class com::sun::star::uno::Reference<class com::sun::star::xml::sax::XFastAttributeList> &,_Bool)
@@ -1092,8 +1092,6 @@ oox/source/drawingml/diagram/diagramlayoutatoms.hxx:278
     const class std::__debug::vector<class std::shared_ptr<class oox::drawingml::Shape>, class std::allocator<class std::shared_ptr<class oox::drawingml::Shape> > > & oox::drawingml::LayoutNode::getNodeShapes() const
 oox/source/drawingml/diagram/diagramlayoutatoms.hxx:287
     const class oox::drawingml::LayoutNode * oox::drawingml::LayoutNode::getParentLayoutNode() const
-reportdesign/qa/unit/reportdesign-dialogs-test.cxx:61
-    int main()
 sal/osl/unx/uunxapi.hxx:35
     int mkdir_c(const class rtl::OString &,unsigned int)
 sal/osl/unx/uunxapi.hxx:70
@@ -1188,6 +1186,8 @@ sc/inc/userlist.hxx:88
     class __gnu_debug::_Safe_iterator<class __gnu_cxx::__normal_iterator<const class std::unique_ptr<class ScUserListData, struct std::default_delete<class ScUserListData> > *, class std::__cxx1998::vector<class std::unique_ptr<class ScUserListData, struct std::default_delete<class ScUserListData> >, class std::allocator<class std::unique_ptr<class ScUserListData, struct std::default_delete<class ScUserListData> > > > >, class std::__debug::vector<class std::unique_ptr<class ScUserListData, struct std::default_delete<class ScUserListData> >, class std::allocator<class std::unique_ptr<class ScUserListData, struct std::default_delete<class ScUserListData> > > >, struct std::random_access_iterator_tag> ScUserList::begin() const
 sc/qa/unit/helper/qahelper.hxx:155
     class std::__cxx11::basic_string<char, struct std::char_traits<char>, class std::allocator<char> > print(const class ScAddress &)
+sc/qa/unit/screenshots/screenshots.cxx:326
+    int main()
 sc/qa/unit/ucalc.hxx:150
     void Test::testFormulaHashAndTag()
 sc/qa/unit/ucalc.hxx:189
@@ -1296,8 +1296,6 @@ sccomp/source/solver/DifferentialEvolution.hxx:67
     int DifferentialEvolutionAlgorithm::getLastChange()
 sccomp/source/solver/ParticelSwarmOptimization.hxx:85
     int ParticleSwarmOptimizationAlgorithm::getLastChange()
-sd/inc/sdabstdlg.hxx:185
-    class VclPtr<class SfxAbstractTabDialog> SdAbstractDialogFactory::CreateSdOutlineBulletTabDlg(class weld::Window *,const class SfxItemSet *,class sd::View *)
 sd/inc/sddll.hxx:48
      SdDLL::SdDLL()
 sd/source/filter/ppt/pptinanimations.hxx:108
@@ -1444,7 +1442,9 @@ svl/source/misc/gridprinter.cxx:47
     void rtl::mdds_mtv_append_values(struct mdds::mtv::base_element_block &,const class rtl::OUString &,const type-parameter-?-? &,const type-parameter-?-? &)
 svx/inc/sdr/contact/viewcontactofgraphic.hxx:52
     class SdrGrafObj & sdr::contact::ViewContactOfGraphic::GetGrafObject()
-svx/source/tbxctrls/tbcontrl.cxx:150
+svx/source/inc/fmexch.hxx:102
+    void svxform::OLocalExchangeHelper::startDrag(class vcl::Window *,signed char)
+svx/source/tbxctrls/tbcontrl.cxx:151
     void (anonymous namespace)::SvxStyleBox_Base::set_sensitive(_Bool)
 sw/inc/calbck.hxx:307
     class sw::WriterListener * sw::ClientIteratorBase::GetLeftOfPos()
@@ -1598,7 +1598,7 @@ sw/inc/viscrs.hxx:206
     class SwShellTableCursor * SwShellTableCursor::GetPrev()
 sw/inc/viscrs.hxx:207
     const class SwShellTableCursor * SwShellTableCursor::GetPrev() const
-sw/qa/inc/swmodeltestbase.hxx:640
+sw/qa/inc/swmodeltestbase.hxx:341
     class com::sun::star::uno::Reference<class com::sun::star::beans::XPropertySet> SwModelTestBase::getParagraphAnchoredObject(const int,const class com::sun::star::uno::Reference<class com::sun::star::text::XTextRange> &) const
 sw/source/core/access/accportions.cxx:56
     unsigned long FindBreak(const vector<type-parameter-?-?, allocator<type-parameter-?-?> > &,type-parameter-?-?)
@@ -1772,6 +1772,8 @@ vcl/inc/skia/zone.hxx:22
     void SkiaZone::relaxWatchdogTimings()
 vcl/inc/unx/gtk/gtkframe.hxx:217
     void ensure_dbus_setup(struct _GdkWindow *,class GtkSalFrame *)
+vcl/inc/unx/printergfx.hxx:94
+    _Bool psp::PrinterColor::operator!=(const class psp::PrinterColor &) const
 vcl/inc/unx/saldisp.hxx:377
     class SalXLib * SalDisplay::GetXLib() const
 vcl/inc/unx/salframe.h:184
diff --git a/include/vcl/treelistbox.hxx b/include/vcl/treelistbox.hxx
index b7b5a4daa11d..16f2227f5d4c 100644
--- a/include/vcl/treelistbox.hxx
+++ b/include/vcl/treelistbox.hxx
@@ -295,7 +295,6 @@ protected:
     std::unique_ptr<SvInplaceEdit2>  pEdCtrl;
     void            EditText( const OUString&, const tools::Rectangle&,const Selection&);
     void            CancelTextEditing();
-    bool            EditingCanceled() const;
 
     // InitViewData is called right after CreateViewData
     // The Entry is has not yet been added to the View in InitViewData!
diff --git a/svx/source/form/fmexch.cxx b/svx/source/form/fmexch.cxx
index 8d4ddc3647f8..39ef077b1ec1 100644
--- a/svx/source/form/fmexch.cxx
+++ b/svx/source/form/fmexch.cxx
@@ -327,12 +327,6 @@ namespace svxform
         implReset();
     }
 
-    void OLocalExchangeHelper::startDrag(vcl::Window* pDragSource, sal_Int8 nDragSourceActions)
-    {
-        DBG_ASSERT(m_xTransferable.is(), "OLocalExchangeHelper::startDrag: not prepared!");
-        m_xTransferable->startDrag( pDragSource, nDragSourceActions, OLocalExchange::GrantAccess() );
-    }
-
     void OLocalExchangeHelper::copyToClipboard( ) const
     {
         DBG_ASSERT( m_xTransferable.is(), "OLocalExchangeHelper::copyToClipboard: not prepared!" );
diff --git a/svx/source/inc/fmexch.hxx b/svx/source/inc/fmexch.hxx
index 9916abc32efc..8eb65854e564 100644
--- a/svx/source/inc/fmexch.hxx
+++ b/svx/source/inc/fmexch.hxx
@@ -99,7 +99,6 @@ namespace svxform
 
         void        prepareDrag( );
 
-        void        startDrag(vcl::Window* pDragSource, sal_Int8 nDragSourceActions);
         void        copyToClipboard( ) const;
 
         bool    isDragSource() const { return m_xTransferable.is() && m_xTransferable->isDragging(); }
diff --git a/vcl/source/treelist/treelistbox.cxx b/vcl/source/treelist/treelistbox.cxx
index ef3176e08162..4776f6b3634b 100644
--- a/vcl/source/treelist/treelistbox.cxx
+++ b/vcl/source/treelist/treelistbox.cxx
@@ -1059,11 +1059,6 @@ bool SvTreeListBox::HandleKeyInput( const KeyEvent& _rKEvt )
     return false;
 }
 
-bool SvTreeListBox::EditingCanceled() const
-{
-    return pEdCtrl && pEdCtrl->EditingCanceled();
-}
-
 
 //JP 28.3.2001: new Drag & Drop API
 sal_Int8 SvTreeListBox::AcceptDrop( const AcceptDropEvent& rEvt )