diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2020-10-27 15:59:56 +0000 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2020-10-27 20:46:18 +0100 |
| commit | 9f2daed124829717b9350b78ac301a0b9fceacf8 (patch) | |
| tree | cf458009ee59517da840e61e6a96f1220cc306b8 | |
| parent | 71f6e3862afc460536085582d3f9e9401096c24a (diff) | |
tdf#137726 hide pivot table dlg so its not a candidate as error dlg parent
because this pivot table dialog is going to disappear on response and the error
dialog is not run in its own event loop but instead async so will end up as a
parent of a dialog that doesn't exist
Change-Id: I78302428a246612e3107d2907ffffb97a2d25ea2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104895
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
| -rw-r--r-- | sc/source/ui/dbgui/PivotLayoutDialog.cxx | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/sc/source/ui/dbgui/PivotLayoutDialog.cxx b/sc/source/ui/dbgui/PivotLayoutDialog.cxx index 8c92e8378172..2263370a2eec 100644 --- a/sc/source/ui/dbgui/PivotLayoutDialog.cxx +++ b/sc/source/ui/dbgui/PivotLayoutDialog.cxx @@ -628,6 +628,12 @@ void ScPivotLayoutDialog::Close() IMPL_LINK_NOARG( ScPivotLayoutDialog, OKClicked, weld::Button&, void ) { + /* tdf#137726 hide so its not a candidate to be parent of any error + messages that may appear because this dialog is going to disappear on + response(RET_OK) and the error dialog is not run in its own event loop + but instead async */ + m_xDialog->hide(); + ApplyChanges(); m_xDialog->response(RET_OK); } |