diff options
author | Armin Le Grand <Armin.Le.Grand@cib.de (CIB)> | 2018-03-17 23:11:46 +0100 |
---|---|---|
committer | Armin Le Grand <Armin.Le.Grand@cib.de> | 2018-04-06 18:06:31 +0200 |
commit | c509bee411dc2a3ed7ca17183e7fa203962a7d6d (patch) | |
tree | 9977af5350ee396a8d7c924d684a5e8289a9e84d | |
parent | 3580a2732e45504d25c0d1e22410212c2d7c8669 (diff) |
SOSAW080: Adapted some comments to make more readable
Change-Id: I446685a49a6d67aedd01cfbbd5e87b07f97a4d7b
-rw-r--r-- | filter/source/svg/svgexport.cxx | 2 | ||||
-rw-r--r-- | sc/source/ui/app/drwtrans.cxx | 4 | ||||
-rw-r--r-- | sc/source/ui/drawfunc/fuconrec.cxx | 2 | ||||
-rw-r--r-- | sc/source/ui/drawfunc/fuins2.cxx | 6 | ||||
-rw-r--r-- | sd/source/core/sdpage2.cxx | 2 | ||||
-rw-r--r-- | sd/source/ui/func/fuconrec.cxx | 2 | ||||
-rw-r--r-- | sd/source/ui/table/tablefunction.cxx | 2 | ||||
-rw-r--r-- | sd/source/ui/view/drviews2.cxx | 2 | ||||
-rw-r--r-- | sd/source/ui/view/frmview.cxx | 2 | ||||
-rw-r--r-- | svx/source/inc/tablemodel.hxx | 2 | ||||
-rw-r--r-- | svx/source/unodraw/unopage.cxx | 2 | ||||
-rw-r--r-- | svx/source/unodraw/unoshtxt.cxx | 4 | ||||
-rw-r--r-- | sw/source/core/frmedt/fecopy.cxx | 2 |
13 files changed, 17 insertions, 17 deletions
diff --git a/filter/source/svg/svgexport.cxx b/filter/source/svg/svgexport.cxx index e13b162876c7..056c1c7fa5c9 100644 --- a/filter/source/svg/svgexport.cxx +++ b/filter/source/svg/svgexport.cxx @@ -562,7 +562,7 @@ bool SVGFilter::implExport( const Sequence< PropertyValue >& rDescriptor ) mpDefaultSdrPage = pSvxDrawPage->GetSdrPage(); mpSdrModel = &mpDefaultSdrPage->getSdrModelFromSdrPage(); - if( mpSdrModel ) // TTTT shbe ref + if( mpSdrModel ) // TTTT should be reference { SdrOutliner& rOutl = mpSdrModel->GetDrawOutliner(); diff --git a/sc/source/ui/app/drwtrans.cxx b/sc/source/ui/app/drwtrans.cxx index 0a7789540aa5..12cfa00f3bca 100644 --- a/sc/source/ui/app/drwtrans.cxx +++ b/sc/source/ui/app/drwtrans.cxx @@ -632,7 +632,7 @@ static void lcl_InitMarks( SdrMarkView& rDest, const SdrMarkView& rSource, SCTAB void ScDrawTransferObj::SetDragSource( const ScDrawView* pView ) { DELETEZ( pDragSourceView ); - pDragSourceView = new SdrView(pView->getSdrModelFromSdrView()); // TTTT pView shbe ref + pDragSourceView = new SdrView(pView->getSdrModelFromSdrView()); // TTTT pView should be reference lcl_InitMarks( *pDragSourceView, *pView, pView->GetTab() ); //! add as listener with document, delete pDragSourceView if document gone @@ -641,7 +641,7 @@ void ScDrawTransferObj::SetDragSource( const ScDrawView* pView ) void ScDrawTransferObj::SetDragSourceObj( SdrObject* pObj, SCTAB nTab ) { DELETEZ( pDragSourceView ); - pDragSourceView = new SdrView(pObj->getSdrModelFromSdrObject()); // TTTT pObj shbe ref + pDragSourceView = new SdrView(pObj->getSdrModelFromSdrObject()); // TTTT pObj should be reference pDragSourceView->ShowSdrPage(pDragSourceView->GetModel()->GetPage(nTab)); SdrPageView* pPV = pDragSourceView->GetSdrPageView(); pDragSourceView->MarkObj(pObj, pPV); diff --git a/sc/source/ui/drawfunc/fuconrec.cxx b/sc/source/ui/drawfunc/fuconrec.cxx index 79ccb4868160..6aba5faad5fc 100644 --- a/sc/source/ui/drawfunc/fuconrec.cxx +++ b/sc/source/ui/drawfunc/fuconrec.cxx @@ -216,7 +216,7 @@ void FuConstRectangle::Activate() void FuConstRectangle::SetLineEnds(SfxItemSet& rAttr, const SdrObject* pObj, sal_uInt16 nSlotId) { - SdrModel& rModel(pObj->getSdrModelFromSdrObject()); // TTTT pObj shbe ref + SdrModel& rModel(pObj->getSdrModelFromSdrObject()); // TTTT pObj should be reference if ( nSlotId == SID_LINE_ARROW_START || nSlotId == SID_LINE_ARROW_END || diff --git a/sc/source/ui/drawfunc/fuins2.cxx b/sc/source/ui/drawfunc/fuins2.cxx index ee3ab21f9194..bcee011d6637 100644 --- a/sc/source/ui/drawfunc/fuins2.cxx +++ b/sc/source/ui/drawfunc/fuins2.cxx @@ -351,7 +351,7 @@ FuInsertOLE::FuInsertOLE(ScTabViewShell* pViewSh, vcl::Window* pWin, ScDrawView* aPnt.AdjustX( -(aSize.Width()) ); // move position to left edge tools::Rectangle aRect (aPnt, aSize); SdrOle2Obj* pObj = new SdrOle2Obj( - *pDoc, // TTTT shbe ref + *pDoc, // TTTT should be reference aObjRef, aName, aRect); @@ -593,7 +593,7 @@ FuInsertChart::FuInsertChart(ScTabViewShell* pViewSh, vcl::Window* pWin, ScDrawV tools::Rectangle aRect (aStart, aSize); SdrOle2Obj* pObj = new SdrOle2Obj( - *pDoc, // TTTT shbe ref + *pDoc, // TTTT should be reference svt::EmbeddedObjectRef(xObj, nAspect), aName, aRect); @@ -756,7 +756,7 @@ FuInsertChartFromFile::FuInsertChartFromFile( ScTabViewShell* pViewSh, vcl::Wind Point aStart = pViewSh->GetChartInsertPos( aSize, aPositionRange ); tools::Rectangle aRect (aStart, aSize); SdrOle2Obj* pObj = new SdrOle2Obj( - *pDoc, // TTTT shbe ref + *pDoc, // TTTT should be reference svt::EmbeddedObjectRef(xObj, nAspect), aName, aRect); diff --git a/sd/source/core/sdpage2.cxx b/sd/source/core/sdpage2.cxx index e77a2ccf5f07..3b6e42fd7b95 100644 --- a/sd/source/core/sdpage2.cxx +++ b/sd/source/core/sdpage2.cxx @@ -578,7 +578,7 @@ void SdPage::addAnnotation( const Reference< XAnnotation >& xAnnotation, int nIn SetChanged(); getSdrModelFromSdrPage().SetChanged(); - // TTTT NotifyDocumentEvent shbe ref? + // TTTT NotifyDocumentEvent should be reference NotifyDocumentEvent( static_cast< SdDrawDocument* >(&getSdrModelFromSdrPage()), "OnAnnotationInserted", diff --git a/sd/source/ui/func/fuconrec.cxx b/sd/source/ui/func/fuconrec.cxx index 471a1eeb2608..d78fd866755d 100644 --- a/sd/source/ui/func/fuconrec.cxx +++ b/sd/source/ui/func/fuconrec.cxx @@ -541,7 +541,7 @@ void FuConstructRectangle::SetLineEnds(SfxItemSet& rAttr, SdrObject const * pObj nSlotId == SID_LINE_SQUARE_ARROW ) { // set attributes of line start and ends - SdrModel& rModel(pObj->getSdrModelFromSdrObject()); // TTTT pObj shbe ref + SdrModel& rModel(pObj->getSdrModelFromSdrObject()); // TTTT pObj should be reference // arrowhead ::basegfx::B2DPolyPolygon aArrow( getPolygon( RID_SVXSTR_ARROW, rModel ) ); diff --git a/sd/source/ui/table/tablefunction.cxx b/sd/source/ui/table/tablefunction.cxx index c41bd5d4e693..e85d27a810fb 100644 --- a/sd/source/ui/table/tablefunction.cxx +++ b/sd/source/ui/table/tablefunction.cxx @@ -184,7 +184,7 @@ void DrawViewShell::FuTable(SfxRequest& rReq) } sdr::table::SdrTableObj* pObj = new sdr::table::SdrTableObj( - *GetDoc(), // TTTT reference? + *GetDoc(), // TTTT should be reference aRect, nColumns, nRows); diff --git a/sd/source/ui/view/drviews2.cxx b/sd/source/ui/view/drviews2.cxx index 46b1b381c919..6713c0dc4d51 100644 --- a/sd/source/ui/view/drviews2.cxx +++ b/sd/source/ui/view/drviews2.cxx @@ -521,7 +521,7 @@ public: continue; SdrRectObj* pObject = new SdrRectObj( - *m_rDrawViewShell.GetDoc(), // TTTT shbe ref + *m_rDrawViewShell.GetDoc(), // TTTT should be reference OBJ_TEXT); pObject->SetMergedItem(makeSdrTextAutoGrowWidthItem(true)); pObject->SetOutlinerParaObject(pOutliner->CreateParaObject()); diff --git a/sd/source/ui/view/frmview.cxx b/sd/source/ui/view/frmview.cxx index 3ac368ce2673..b08896abf358 100644 --- a/sd/source/ui/view/frmview.cxx +++ b/sd/source/ui/view/frmview.cxx @@ -51,7 +51,7 @@ using namespace ::std; namespace sd { FrameView::FrameView(SdDrawDocument* pDrawDoc, FrameView* pFrameView /* = NULK */) -: SdrView(*pDrawDoc, nullptr), // TTTT SdDrawDocument* -> reference? +: SdrView(*pDrawDoc, nullptr), // TTTT SdDrawDocument* -> should be reference mnRefCount(0), mnPresViewShellId(SID_VIEWSHELL0), mbIsNavigatorShowingAllShapes(false) diff --git a/svx/source/inc/tablemodel.hxx b/svx/source/inc/tablemodel.hxx index af8f6b445f1e..791a4310f190 100644 --- a/svx/source/inc/tablemodel.hxx +++ b/svx/source/inc/tablemodel.hxx @@ -176,7 +176,7 @@ private: rtl::Reference< TableColumns > mxTableColumns; rtl::Reference< TableRows > mxTableRows; - SdrTableObj* mpTableObj; // TTTT should be ref? + SdrTableObj* mpTableObj; // TTTT should be reference bool mbModified; bool mbNotifyPending; diff --git a/svx/source/unodraw/unopage.cxx b/svx/source/unodraw/unopage.cxx index b63e3416ad10..f35a104f6da5 100644 --- a/svx/source/unodraw/unopage.cxx +++ b/svx/source/unodraw/unopage.cxx @@ -61,7 +61,7 @@ using namespace ::com::sun::star::drawing; UNO3_GETIMPLEMENTATION_IMPL( SvxDrawPage ); -SvxDrawPage::SvxDrawPage(SdrPage* pInPage) // TTTT shbe ref +SvxDrawPage::SvxDrawPage(SdrPage* pInPage) // TTTT should be reference : mrBHelper(getMutex()) ,mpPage(pInPage) ,mpModel(&pInPage->getSdrModelFromSdrPage()) // register at broadcaster diff --git a/svx/source/unodraw/unoshtxt.cxx b/svx/source/unodraw/unoshtxt.cxx index 852d945607a7..f09305dd9939 100644 --- a/svx/source/unodraw/unoshtxt.cxx +++ b/svx/source/unodraw/unoshtxt.cxx @@ -157,7 +157,7 @@ SvxTextEditSourceImpl::SvxTextEditSourceImpl( SdrObject* pObject, SdrText* pText mpText ( pText ), mpView ( nullptr ), mpWindow ( nullptr ), - mpModel ( pObject ? &pObject->getSdrModelFromSdrObject() : nullptr ), // TTTT shbe ref + mpModel ( pObject ? &pObject->getSdrModelFromSdrObject() : nullptr ), // TTTT should be reference mpOutliner ( nullptr ), mpTextForwarder ( nullptr ), mpViewForwarder ( nullptr ), @@ -193,7 +193,7 @@ SvxTextEditSourceImpl::SvxTextEditSourceImpl( SdrObject& rObject, SdrText* pText mpText ( pText ), mpView ( &rView ), mpWindow ( &rWindow ), - mpModel ( &rObject.getSdrModelFromSdrObject() ), // TTTT shbe ref + mpModel ( &rObject.getSdrModelFromSdrObject() ), // TTTT should be reference mpOutliner ( nullptr ), mpTextForwarder ( nullptr ), mpViewForwarder ( nullptr ), diff --git a/sw/source/core/frmedt/fecopy.cxx b/sw/source/core/frmedt/fecopy.cxx index ece29f920435..385f8dacc8d5 100644 --- a/sw/source/core/frmedt/fecopy.cxx +++ b/sw/source/core/frmedt/fecopy.cxx @@ -1288,7 +1288,7 @@ static void lcl_ConvertSdrOle2ObjsToSdrGrafObjs( SdrModel* _pModel ) // create new graphic shape with the ole graphic and shape size SdrGrafObj* pGraphicObj = new SdrGrafObj( - *_pModel, // TTTT why ptr? + *_pModel, // TTTT should be reference aGraphic, pOle2Obj->GetCurrentBoundRect()); // apply layer of ole2 shape at graphic shape |