diff options
| author | Tor Lillqvist <tml@collabora.com> | 2015-09-17 08:42:20 +0300 |
|---|---|---|
| committer | Jan Holesovsky <kendy@collabora.com> | 2016-05-16 14:56:56 +0200 |
| commit | 989592293474448af8458f924fa7f74d34955b60 (patch) | |
| tree | 775e9125992adb8cfb82bb04410a92ea07920b2c | |
| parent | 0850b4dbbb2e1590f3e8ede1eea71d83d7f99e51 (diff) | |
WaE: this method can be declared static ColorMaskElement::CalcMaskShift
[loplugin:staticmethods].
And then 'const' makes no sense.
Also, fix fallout warning: calling static member function through
member call syntax, use 'ColorMaskElement::CalcMaskShift' instead
[loplugin:staticcall].
But actually I wonder if this should be a non-static member function
that operates on 'this' (and takes no parameter) instead? Also, the
return value is unused.
Change-Id: I24949b74bd43eb90499e3c881941b102a3622f92
| -rw-r--r-- | include/vcl/salbtype.hxx | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/include/vcl/salbtype.hxx b/include/vcl/salbtype.hxx index 6de6e5e92f94..ed6e5e06dce7 100644 --- a/include/vcl/salbtype.hxx +++ b/include/vcl/salbtype.hxx @@ -202,7 +202,7 @@ struct VCL_DLLPUBLIC ColorMaskElement , mnOr(0) { } - bool CalcMaskShift(ColorMaskElement &rElem) const + static bool CalcMaskShift(ColorMaskElement &rElem) { if (rElem.mnMask == 0) return true; @@ -655,9 +655,9 @@ inline ColorMask::ColorMask( sal_uInt32 nRedMask, , maB(nBlueMask) , mnAlphaChannel(nAlphaChannel) { - maR.CalcMaskShift(maR); - maG.CalcMaskShift(maG); - maB.CalcMaskShift(maB); + ColorMaskElement::CalcMaskShift(maR); + ColorMaskElement::CalcMaskShift(maG); + ColorMaskElement::CalcMaskShift(maB); } inline sal_uLong ColorMask::GetRedMask() const |