diff options
| author | Luboš Luňák <l.lunak@collabora.com> | 2022-04-27 13:07:51 +0200 |
|---|---|---|
| committer | Luboš Luňák <l.lunak@collabora.com> | 2022-04-27 22:46:25 +0200 |
| commit | bb07fb341f9d9398a3723df2a5ccf3a025a7d361 (patch) | |
| tree | 3b583f233f2f9e6fb275897ded60bf6efe3de967 | |
| parent | 3a407fc49490a348a8147a59dae242aa21708c31 (diff) | |
todo note about SalLayoutGlyphsCache possibly reusing different mapmode
Change-Id: I68f23addb834b5c59564dda66f5bce1bb9a541bc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133506
Tested-by: Luboš Luňák <l.lunak@collabora.com>
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
| -rw-r--r-- | vcl/source/gdi/impglyphitem.cxx | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/vcl/source/gdi/impglyphitem.cxx b/vcl/source/gdi/impglyphitem.cxx index 5c4acbc6859c..92703432d8bb 100644 --- a/vcl/source/gdi/impglyphitem.cxx +++ b/vcl/source/gdi/impglyphitem.cxx @@ -319,6 +319,10 @@ SalLayoutGlyphsCache::CachedGlyphsKey::CachedGlyphsKey(const VclPtr<const Output // TODO there is still something missing, otherwise it wouldn't be necessary to compare // also the OutputDevice pointers , font(outputDevice->GetFont()) + // TODO It would be possible to get a better hit ratio if mapMode wasn't part of the key + // and results that differ only in mapmode would have coordinates adjusted based on that. + // That would occassionally lead to rounding errors (at least differences that would + // make checkGlyphsEqual() fail). , mapMode(outputDevice->GetMapMode()) , rtl(outputDevice->IsRTLEnabled()) , layoutMode(outputDevice->GetLayoutMode()) |