diff options
| author | Luboš Luňák <l.lunak@collabora.com> | 2021-11-23 12:44:20 +0100 |
|---|---|---|
| committer | Luboš Luňák <l.lunak@collabora.com> | 2021-11-24 08:21:54 +0100 |
| commit | 071a3894013ea2281c157ba0a786e205c1119bba (patch) | |
| tree | 38eda4c091098e003c8ce5b4f580be2e35ce25d3 | |
| parent | b7a46259eba35257291fe00851252c18ffb4fc90 (diff) | |
remove superfluous code that has a TODO note about it
The commits introducing this part of code have tests attached,
so it's fairly easy to check that this part of code is in fact
not necessary, but if in doubt there's the option of simply asking
the author of the code.
Change-Id: I3b754090ac462d3ae8e4676fc1643570ec53aac1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125695
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
| -rw-r--r-- | sc/source/core/data/table3.cxx | 14 |
1 files changed, 0 insertions, 14 deletions
diff --git a/sc/source/core/data/table3.cxx b/sc/source/core/data/table3.cxx index 0fe6b10b0ba3..42d74aece6b5 100644 --- a/sc/source/core/data/table3.cxx +++ b/sc/source/core/data/table3.cxx @@ -2527,20 +2527,6 @@ public: } } } - else if (rItem.mbRoundForFilter && fQueryVal != 0.0) - { - /* TODO: shouldn't rItem.mfVal (which fQueryVal is) already had - * been stored as rounded in all cases if needed so this extra - * rounding is superfluous? Or rather, if not, then rounding it - * here may produce different roundings for different cell number - * formats, which is odd. This all looks suspicious and the - * intention of tdf#142910 commit - * f6b143a57d9bd8f5d7b29febcb4e01ee1eb2ff1d isn't quite clear. */ - if (nNumFmt == NUMBERFORMAT_ENTRY_NOT_FOUND) - nNumFmt = getNumFmt( nCol, nRow, pContext); - if (nNumFmt) - fQueryVal = mrDoc.RoundValueAsShown(fQueryVal, nNumFmt, pContext); - } switch (rEntry.eOp) { |