diff options
author | Tamás Zolnai <tamas.zolnai@collabora.com> | 2017-07-20 16:39:07 +0200 |
---|---|---|
committer | Miklos Vajna <vmiklos@collabora.co.uk> | 2017-08-01 15:41:37 +0200 |
commit | de5afba4c116792d795339f7e773e302259d8bf0 (patch) | |
tree | 6361b7544b917838b05841d63b74d03684aae8f2 | |
parent | 8cfb5788cc602e0a81ae47832c65cf2402471034 (diff) |
tdf#109228: FILESAVE: ODT: Anchor changed to 'to character' after RT
Ignore frames without names, becuase the code does not handle
them well. It does not affect those use case for which the
deduplication code was added.
Reviewed-on: https://gerrit.libreoffice.org/40222
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
(cherry picked from commit 615c2a2c54d3e7aefb4986ae7d8de81a42022988)
Change-Id: I08ad062b8b11cc06323467329d8c4e97bc4932dd
Reviewed-on: https://gerrit.libreoffice.org/40236
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
-rwxr-xr-x | sw/qa/extras/odfimport/data/tdf109228.odt | bin | 0 -> 13753 bytes | |||
-rw-r--r-- | sw/qa/extras/odfimport/odfimport.cxx | 7 | ||||
-rw-r--r-- | xmloff/source/text/XMLTextFrameContext.cxx | 1 |
3 files changed, 8 insertions, 0 deletions
diff --git a/sw/qa/extras/odfimport/data/tdf109228.odt b/sw/qa/extras/odfimport/data/tdf109228.odt Binary files differnew file mode 100755 index 000000000000..0f3368e1b201 --- /dev/null +++ b/sw/qa/extras/odfimport/data/tdf109228.odt diff --git a/sw/qa/extras/odfimport/odfimport.cxx b/sw/qa/extras/odfimport/odfimport.cxx index 8911e8067107..af20b422505e 100644 --- a/sw/qa/extras/odfimport/odfimport.cxx +++ b/sw/qa/extras/odfimport/odfimport.cxx @@ -20,6 +20,7 @@ #include <com/sun/star/text/XTextSection.hpp> #include <com/sun/star/text/XTextTable.hpp> #include <com/sun/star/text/PageNumberType.hpp> +#include <com/sun/star/text/TextContentAnchorType.hpp> #include <wrtsh.hxx> #include <ndtxt.hxx> @@ -808,5 +809,11 @@ DECLARE_ODFIMPORT_TEST(testTdf109080_style_ns, "tdf109080_style_ns.odt") parseDump("/root/page[2]/footer/txt/text()")); } +DECLARE_ODFIMPORT_TEST(testTdf109228, "tdf109228.odt") +{ + // Embedded object with no frame name was imported incorrectly, it was achored 'to character' instead of 'as character' + CPPUNIT_ASSERT_EQUAL(text::TextContentAnchorType_AS_CHARACTER, getProperty<text::TextContentAnchorType>(getShape(1), "AnchorType")); +} + CPPUNIT_PLUGIN_IMPLEMENT(); /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/xmloff/source/text/XMLTextFrameContext.cxx b/xmloff/source/text/XMLTextFrameContext.cxx index 136ed2db8998..ed75d6cafca9 100644 --- a/xmloff/source/text/XMLTextFrameContext.cxx +++ b/xmloff/source/text/XMLTextFrameContext.cxx @@ -569,6 +569,7 @@ void XMLTextFrameContext_Impl::Create( bool /*bHRefOrBase64*/ ) // Skip duplicated frames if(!mbMultipleContent && // It's allowed to have multiple image for the same frame + !sName.isEmpty() && xTextImportHelper->IsDuplicateFrame(sName, nX, nY, nWidth, nHeight)) { bCreateFailed = true; |