summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2019-04-12 09:51:32 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2019-04-12 11:36:06 +0200
commit0342562261beede5d3bb2e43c08f6d0f216ff97c (patch)
tree77155eea73ebd8381496bb1a787058a1dc11fdf3
parent03b3562a91c54e0c1b77982e1ca391b1131ac3c2 (diff)
loplugin:unnecessaryvirtual
Change-Id: Ic63efdb720c29bede43e39ee498f63fe1f17fb07 Reviewed-on: https://gerrit.libreoffice.org/70647 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-rw-r--r--compilerplugins/clang/unnecessaryvirtual.results20
-rw-r--r--include/sfx2/templatelocalview.hxx4
-rw-r--r--include/sfx2/thumbnailview.hxx2
3 files changed, 15 insertions, 11 deletions
diff --git a/compilerplugins/clang/unnecessaryvirtual.results b/compilerplugins/clang/unnecessaryvirtual.results
index a092dc88030c..fc9f10ad6e12 100644
--- a/compilerplugins/clang/unnecessaryvirtual.results
+++ b/compilerplugins/clang/unnecessaryvirtual.results
@@ -72,12 +72,12 @@ include/comphelper/unique_disposing_ptr.hxx:169
void comphelper::unique_disposing_solar_mutex_reset_ptr::reset(type-parameter-0-0 *,)
include/comphelper/weakeventlistener.hxx:120
void comphelper::OWeakListenerAdapter::disposing(const struct com::sun::star::lang::EventObject &,)
-include/oox/helper/graphichelper.hxx:77
- int oox::GraphicHelper::getDefaultChartAreaLineStyle()const
-include/oox/helper/graphichelper.hxx:80
- short oox::GraphicHelper::getDefaultChartAreaLineWidth()const
-include/sfx2/tabdlg.hxx:103
- class SfxItemSet * SfxTabDialog::CreateInputItemSet(unsigned short,)
+include/sfx2/templatelocalview.hxx:205
+ void SfxTemplateLocalView::reload()
+include/sfx2/templatelocalview.hxx:207
+ void SfxTemplateLocalView::showAllTemplates()
+include/sfx2/thumbnailview.hxx:338
+ void SfxThumbnailView::Clear()
include/svl/svdde.hxx:237
class DdeData * DdeTopic::Get(enum SotClipboardFormatId,)
include/svl/svdde.hxx:238
@@ -114,6 +114,8 @@ include/vbahelper/vbareturntypes.hxx:40
void ooo::vba::DefaultReturnHelper::setValue(type-parameter-0-0,)
include/vbahelper/vbareturntypes.hxx:41
type-parameter-0-0 ooo::vba::DefaultReturnHelper::getValue()
+include/vcl/customweld.hxx:41
+ class rtl::OUString weld::CustomWidgetController::GetHelpText()const
include/vcl/weld.hxx:95
void weld::Widget::set_visible(_Bool,)
sc/source/core/opencl/formulagroupcl.cxx:1053
@@ -126,8 +128,10 @@ sc/source/core/opencl/formulagroupcl.cxx:1520
class std::__cxx11::basic_string<char, struct std::char_traits<char>, class std::allocator<char> > sc::opencl::ParallelReductionVectorRef::GenSlidingWindowDeclRef(_Bool,)const
sc/source/core/opencl/formulagroupcl.cxx:1555
unsigned long sc::opencl::ParallelReductionVectorRef::Marshal(struct _cl_kernel *,int,int,struct _cl_program *,)
-sc/source/ui/inc/anyrefdg.hxx:208
+sc/source/ui/inc/anyrefdg.hxx:222
void ScRefHdlrImpl::dispose()
+sc/source/ui/inc/namemgrtable.hxx:42
+ void ScRangeManagerTable::InitListener::~InitListener()
sc/source/ui/vba/vbacondition.hxx:41
class rtl::OUString ScVbaCondition::Formula1()
sc/source/ui/vba/vbacondition.hxx:42
@@ -218,7 +222,7 @@ vcl/inc/salframe.hxx:144
void SalFrame::SetRepresentedURL(const class rtl::OUString &,)
vcl/inc/salframe.hxx:189
void SalFrame::Flush(const class tools::Rectangle &,)
-vcl/inc/salinst.hxx:92
+vcl/inc/salinst.hxx:94
_Bool SalInstance::SVMainHook(int *,)
vcl/inc/salmenu.hxx:71
void SalMenu::SetItemBits(unsigned int,enum MenuItemBits,)
diff --git a/include/sfx2/templatelocalview.hxx b/include/sfx2/templatelocalview.hxx
index 123e7f04e1e1..329988c455fd 100644
--- a/include/sfx2/templatelocalview.hxx
+++ b/include/sfx2/templatelocalview.hxx
@@ -202,9 +202,9 @@ public:
// Fill view with template folders thumbnails
void Populate ();
- virtual void reload ();
+ void reload ();
- virtual void showAllTemplates ();
+ void showAllTemplates ();
void showRegion (TemplateContainerItem const *pItem);
diff --git a/include/sfx2/thumbnailview.hxx b/include/sfx2/thumbnailview.hxx
index ab19ba460363..1bc476a47fa5 100644
--- a/include/sfx2/thumbnailview.hxx
+++ b/include/sfx2/thumbnailview.hxx
@@ -335,7 +335,7 @@ public:
void RemoveItem(sal_uInt16 nItemId);
- virtual void Clear();
+ void Clear();
// Change current thumbnail item list with new one (invalidates all pointers to a thumbnail item)
void updateItems(std::vector<std::unique_ptr<ThumbnailViewItem>> items);