diff options
| author | Michael Stahl <michael.stahl@allotropia.de> | 2022-05-22 12:26:48 +0200 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2022-05-24 09:57:04 +0200 |
| commit | 27ff58ddd6e48d9247f8befb16d1ca8ddddcb750 (patch) | |
| tree | 0737fef32668cac701110ff72515c6f76e78b4ba | |
| parent | 6d1b32befcaaa1f61a4879a5dcd04289f6b95f96 (diff) | |
svl: spurious GCC12 -Werror=maybe-uninitialized
In file included from svl/source/misc/sharedstringpool.cxx:11:
In constructor ‘svl::SharedString::SharedString(rtl_uString*, rtl_uString*)’,
inlined from ‘svl::SharedString svl::SharedStringPool::intern(const rtl::OUString&)’ at svl/source/misc/sharedstringpool.cxx:129:51:
include/svl/sharedstring.hxx:56:20: error: ‘pResultUpper’ may be used uninitialized [-Werror=maybe-uninitialized]
56 | mpData(pData), mpDataIgnoreCase(pDataIgnoreCase)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
svl/source/misc/sharedstringpool.cxx: In member function ‘svl::SharedString svl::SharedStringPool::intern(const rtl::OUString&)’:
svl/source/misc/sharedstringpool.cxx:93:33: note: ‘pResultUpper’ was declared here
93 | rtl_uString *pResultLower, *pResultUpper;
| ^~~~~~~~~~~~
Change-Id: I2171855844c76ad3b2a72c1eca737691ca96fc46
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134736
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
(cherry picked from commit 694db7d3e7be0caf81dd52dba1a865db206ac145)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134629
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
| -rw-r--r-- | svl/source/misc/sharedstringpool.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/svl/source/misc/sharedstringpool.cxx b/svl/source/misc/sharedstringpool.cxx index 7abe3ea77507..d88b0a2c22ef 100644 --- a/svl/source/misc/sharedstringpool.cxx +++ b/svl/source/misc/sharedstringpool.cxx @@ -92,7 +92,7 @@ SharedString SharedStringPool::intern(const OUString& rStr) { auto& rMap = mpImpl->maStrMap; - rtl_uString *pResultLower, *pResultUpper; + rtl_uString *pResultLower = {}, *pResultUpper = {}; // bogus GCC 12 -Werror=maybe-uninitialized if (rMap.find_fn(rStr.pData, [&](const Mapped& rMapped) { pResultLower = rMapped.first.pData; pResultUpper = rMapped.second.pData; |