summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2022-04-19 12:53:43 +0200
committerChristian Lohmaier <lohmaier+LibreOffice@googlemail.com>2022-04-27 12:24:39 +0200
commit54c5ee4b87514a40425b15a583813cdfd60c95ab (patch)
tree30ea6acbe849c2adc25695124d67fd8c839eedbe
parent46b316ee61657ab44e5dcb56ed66626d97f3c04a (diff)
tdf#148313 Basic IDE crashing while resizing dialog
Change-Id: Ic68b78f26626f346f3ef8b54a584de64165d9eb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133170 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit d40c6601330b70c3cb9c1be0fa9e9775ad51113c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133140 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit a1820d4c62e8f38faa6360f1de168622d296d049) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133144 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
-rw-r--r--svx/source/svdraw/sdrhittesthelper.cxx7
1 files changed, 4 insertions, 3 deletions
diff --git a/svx/source/svdraw/sdrhittesthelper.cxx b/svx/source/svdraw/sdrhittesthelper.cxx
index 2a93dc372555..eb5116e584a7 100644
--- a/svx/source/svdraw/sdrhittesthelper.cxx
+++ b/svx/source/svdraw/sdrhittesthelper.cxx
@@ -136,9 +136,10 @@ bool ViewObjectContactPrimitiveHit(
{
// get primitive sequence
sdr::contact::DisplayInfo aDisplayInfo;
- const drawinglayer::primitive2d::Primitive2DContainer& rSequence(rVOC.getPrimitive2DSequence(aDisplayInfo));
+ // have to make a copy of this container here, because it might be changed underneath us
+ const drawinglayer::primitive2d::Primitive2DContainer aSequence(rVOC.getPrimitive2DSequence(aDisplayInfo));
- if(!rSequence.empty())
+ if(!aSequence.empty())
{
// create a HitTest processor
const drawinglayer::geometry::ViewInformation2D& rViewInformation2D = rVOC.GetObjectContact().getViewInformation2D();
@@ -152,7 +153,7 @@ bool ViewObjectContactPrimitiveHit(
aHitTestProcessor2D.collectHitStack(true);
// feed it with the primitives
- aHitTestProcessor2D.process(rSequence);
+ aHitTestProcessor2D.process(aSequence);
// deliver result
if (aHitTestProcessor2D.getHit())