diff options
| author | Kevin Suo <suokunlong@126.com> | 2023-11-22 16:11:33 +0800 |
|---|---|---|
| committer | Xisco Fauli <xiscofauli@libreoffice.org> | 2023-11-28 09:46:57 +0100 |
| commit | f52d8f004f7d70f89ee805c6f71f1791cac70c0f (patch) | |
| tree | 68890068de1d20f580fae7db56437df68ca286fe | |
| parent | b9645ac5b97c0c61514cfe484f770626e61d58a0 (diff) | |
tdf#157589 tdf#153969: Revert "sdext.pdfimport Writer: Do not visit...
... DrawElement twice in WriterXmlEmitter"
This reverts commit 9ea9d3ccc0f8e4833e745d9655b61d42d6d8fe83.
The reason for the revert:
It causes regressions as indicated in tdf#157589 and tdf#153969.
That commit may be my misunderstanding of the code.
Change-Id: Idd188bf83721d309623a7f8484d064327a3a23af
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159811
Tested-by: Jenkins
Reviewed-by: Kevin Suo <suokunlong@126.com>
(cherry picked from commit 5589659829f8a1cef8ca1c8a468732105bbe231b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159906
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
| -rw-r--r-- | sdext/source/pdfimport/tree/writertreevisiting.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sdext/source/pdfimport/tree/writertreevisiting.cxx b/sdext/source/pdfimport/tree/writertreevisiting.cxx index a8331b87bfd2..ce8845447e7f 100644 --- a/sdext/source/pdfimport/tree/writertreevisiting.cxx +++ b/sdext/source/pdfimport/tree/writertreevisiting.cxx @@ -413,7 +413,7 @@ void WriterXmlEmitter::visit( DocumentElement& elem, const std::list< std::uniqu // only DrawElement types for( auto it = elem.Children.begin(); it != elem.Children.end(); ++it ) { - if( dynamic_cast<DrawElement*>(it->get()) != nullptr ) + if( dynamic_cast<DrawElement*>(it->get()) == nullptr ) (*it)->visitedBy( *this, it ); } |