tdf#97087 Give comprehensible, unique names to idles

Timers and idles should have programmer comprehensible, unique names

Change-Id: Id0f2c0a77cd28c3ec5473e8432569739b58d2101
Reviewed-on: https://gerrit.libreoffice.org/24388
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

17 files changed, 26 insertions, 7 deletions

diff --git a/avmedia/source/framework/mediacontrol.cxx b/avmedia/source/framework/mediacontrol.cxx
index 78ef5fbf040f..cf04846fdacb 100644
--- a/avmedia/source/framework/mediacontrol.cxx
+++ b/avmedia/source/framework/mediacontrol.cxx
@@ -60,6 +60,7 @@ namespace avmedia
 MediaControl::MediaControl( vcl::Window* pParent, MediaControlStyle eControlStyle ) :
     Control( pParent ),
     maImageList( SvtMiscOptions().AreCurrentSymbolsLarge() ? AVMEDIA_RESID( AVMEDIA_IMGLST_L ) : AVMEDIA_RESID( AVMEDIA_IMGLST ) ),
+    maIdle( "avmedia MediaControl Idle" ),
     maItem( 0, AVMediaSetMask::ALL ),
     maPlayToolBox( VclPtr<ToolBox>::Create(this, WB_3DLOOK) ),
     maTimeSlider( VclPtr<Slider>::Create(this, WB_HORZ | WB_DRAG | WB_3DLOOK | WB_SLIDERSET) ),
diff --git a/cui/source/dialogs/linkdlg.cxx b/cui/source/dialogs/linkdlg.cxx
index b5a840f1f028..1d4e1fbc379f 100644
--- a/cui/source/dialogs/linkdlg.cxx
+++ b/cui/source/dialogs/linkdlg.cxx
@@ -95,7 +95,8 @@ SvBaseLinksDlg::SvBaseLinksDlg( vcl::Window * pParent, LinkManager* pMgr, bool b
     aStrCloselinkmsgMulti( CUI_RES( STR_CLOSELINKMSG_MULTI ) ),
     aStrWaitinglink( CUI_RES( STR_WAITINGLINK ) ),
     pLinkMgr( nullptr ),
-    bHtmlMode(bHtml)
+    bHtmlMode(bHtml),
+    aUpdateIdle("cui SvBaseLinksDlg UpdateIdle")
 {
     get(m_pTbLinks, "TB_LINKS");
     Size aSize(LogicToPixel(Size(257, 87), MAP_APPFONT));
diff --git a/extensions/source/bibliography/bibcont.cxx b/extensions/source/bibliography/bibcont.cxx
index 5b27a5773efe..212b601d1a7b 100644
--- a/extensions/source/bibliography/bibcont.cxx
+++ b/extensions/source/bibliography/bibcont.cxx
@@ -121,7 +121,8 @@ bool BibWindowContainer::HandleShortCutKey( const KeyEvent& rKeyEvent )
 BibBookContainer::BibBookContainer(vcl::Window* pParent, WinBits nStyle):
     BibSplitWindow(pParent,nStyle),
     pTopWin(nullptr),
-    pBottomWin(nullptr)
+    pBottomWin(nullptr),
+    aIdle("extensions BibBookContainer Split Idle")
 {
     pBibMod = OpenBibModul();
     aIdle.SetIdleHdl(LINK( this, BibBookContainer, SplitHdl));
diff --git a/formula/source/ui/dlg/funcutl.cxx b/formula/source/ui/dlg/funcutl.cxx
index 2d49d982b0f5..9052d7c6f19e 100644
--- a/formula/source/ui/dlg/funcutl.cxx
+++ b/formula/source/ui/dlg/funcutl.cxx
@@ -429,6 +429,7 @@ void EditBox::UpdateOldSel()
 
 RefEdit::RefEdit( vcl::Window* _pParent, vcl::Window* pShrinkModeLabel, WinBits nStyle )
     : Edit( _pParent, nStyle )
+    , aIdle("formula RefEdit Idle")
     , pAnyRefDlg( nullptr )
     , pLabelWidget(pShrinkModeLabel)
 {
@@ -439,6 +440,7 @@ RefEdit::RefEdit( vcl::Window* _pParent, vcl::Window* pShrinkModeLabel, WinBits
 RefEdit::RefEdit( vcl::Window* _pParent,IControlReferenceHandler* pParent,
     vcl::Window* pShrinkModeLabel, const ResId& rResId )
     : Edit( _pParent, rResId )
+    , aIdle("formula RefEdit Idle")
     , pAnyRefDlg( pParent )
     , pLabelWidget(pShrinkModeLabel)
 {
diff --git a/sc/source/ui/docshell/autostyl.cxx b/sc/source/ui/docshell/autostyl.cxx
index 1e099613e34b..463b88bcd314 100644
--- a/sc/source/ui/docshell/autostyl.cxx
+++ b/sc/source/ui/docshell/autostyl.cxx
@@ -59,6 +59,8 @@ struct FindNonZeroTimeout : public ::std::unary_function<ScAutoStyleData, bool>
 
 ScAutoStyleList::ScAutoStyleList(ScDocShell* pShell)
     : pDocSh(pShell)
+    , aTimer("ScAutoStyleList Timer")
+    , aInitIdle("ScAutoStyleList InitIdle")
     , nTimerStart(0)
 {
     aTimer.SetTimeoutHdl( LINK( this, ScAutoStyleList, TimerHdl ) );
diff --git a/sc/source/ui/miscdlgs/acredlin.cxx b/sc/source/ui/miscdlgs/acredlin.cxx
index 6abac7366c61..696b01cc9c26 100644
--- a/sc/source/ui/miscdlgs/acredlin.cxx
+++ b/sc/source/ui/miscdlgs/acredlin.cxx
@@ -77,6 +77,8 @@ ScAcceptChgDlg::ScAcceptChgDlg(SfxBindings* pB, SfxChildWindow* pCW, vcl::Window
     ScViewData* ptrViewData)
     : SfxModelessDialog(pB, pCW, pParent,
         "AcceptRejectChangesDialog", "svx/ui/acceptrejectchangesdialog.ui"),
+        aSelectionIdle("ScAcceptChgDlg SelectionIdle"),
+        aReOpenIdle("ScAcceptChgDlg ReOpenIdle"),
         pViewData       ( ptrViewData ),
         pDoc            ( ptrViewData->GetDocument() ),
         aStrInsertCols       (SC_RESSTR(STR_CHG_INSERT_COLS)),
diff --git a/sc/source/ui/miscdlgs/conflictsdlg.cxx b/sc/source/ui/miscdlgs/conflictsdlg.cxx
index 2d828dbeef9f..7b17d7693ae6 100644
--- a/sc/source/ui/miscdlgs/conflictsdlg.cxx
+++ b/sc/source/ui/miscdlgs/conflictsdlg.cxx
@@ -386,6 +386,7 @@ ScConflictsDlg::ScConflictsDlg( vcl::Window* pParent, ScViewData* pViewData, ScD
     ,mpSharedTrack      ( nullptr )
     ,mrConflictsList    ( rConflictsList )
     ,maDialogSize       ( GetSizePixel() )
+    ,maSelectionIdle    ( "ScConflictsDlg SelectionIdle" )
     ,mbInSelectHdl      ( false )
     ,mbInDeselectHdl    ( false )
 {
diff --git a/sd/source/ui/dlg/brkdlg.cxx b/sd/source/ui/dlg/brkdlg.cxx
index 15e65ae8723b..bf8709923872 100644
--- a/sd/source/ui/dlg/brkdlg.cxx
+++ b/sd/source/ui/dlg/brkdlg.cxx
@@ -45,6 +45,7 @@ BreakDlg::BreakDlg(
     sal_uLong nSumActionCount,
     sal_uLong nObjCount )
     : SfxModalDialog(pWindow, "BreakDialog", "modules/sdraw/ui/breakdialog.ui")
+    , aIdle("sd BreakDlg Idle")
     , mpProgress( nullptr )
 {
     get(m_pFiObjInfo, "metafiles");
diff --git a/sd/source/ui/framework/module/ShellStackGuard.cxx b/sd/source/ui/framework/module/ShellStackGuard.cxx
index 9e64562c1d57..a37cf5faafb2 100644
--- a/sd/source/ui/framework/module/ShellStackGuard.cxx
+++ b/sd/source/ui/framework/module/ShellStackGuard.cxx
@@ -43,7 +43,7 @@ ShellStackGuard::ShellStackGuard (Reference<frame::XController>& rxController)
       mxConfigurationController(),
       mpBase(nullptr),
       mpUpdateLock(),
-      maPrinterPollingIdle()
+      maPrinterPollingIdle("sd ShellStackGuard PrinterPollingIdle")
 {
     Reference<XControllerManager> xControllerManager (rxController, UNO_QUERY);
     if (xControllerManager.is())
diff --git a/starmath/source/edit.cxx b/starmath/source/edit.cxx
index c1d06c8111e7..2186e997cd80 100644
--- a/starmath/source/edit.cxx
+++ b/starmath/source/edit.cxx
@@ -84,7 +84,9 @@ bool SmEditWindow::IsInlineEditEnabled()
 SmEditWindow::SmEditWindow( SmCmdBoxWindow &rMyCmdBoxWin ) :
     Window              (&rMyCmdBoxWin),
     DropTargetHelper    ( this ),
-    rCmdBox             (rMyCmdBoxWin)
+    rCmdBox             (rMyCmdBoxWin),
+    aModifyIdle         ("SmEditWindow ModifyIdle"),
+    aCursorMoveIdle     ("SmEditWindow CursorMoveIdle")
 {
     SetHelpId(HID_SMA_COMMAND_WIN_EDIT);
     SetMapMode(MAP_PIXEL);
diff --git a/svtools/source/misc/filechangedchecker.cxx b/svtools/source/misc/filechangedchecker.cxx
index 2f2434d8b459..85f9a630db8d 100644
--- a/svtools/source/misc/filechangedchecker.cxx
+++ b/svtools/source/misc/filechangedchecker.cxx
@@ -13,7 +13,7 @@
 
 FileChangedChecker::FileChangedChecker(const OUString& rFilename,
         const ::std::function<void ()>& rCallback)
-    : mIdle()
+    : mIdle("SVTools FileChangedChecker Idle")
     , mFileName(rFilename)
     , mLastModTime()
     , mpCallback(rCallback)
diff --git a/svx/source/dialog/_contdlg.cxx b/svx/source/dialog/_contdlg.cxx
index 630550f3f1f5..2b177474e265 100644
--- a/svx/source/dialog/_contdlg.cxx
+++ b/svx/source/dialog/_contdlg.cxx
@@ -212,6 +212,8 @@ void SvxContourDlg::Update( const Graphic& rGraphic, bool bGraphicLinked,
 SvxSuperContourDlg::SvxSuperContourDlg(SfxBindings *_pBindings, SfxChildWindow *pCW,
                                        vcl::Window* _pParent) :
         SvxContourDlg       ( _pBindings, pCW, _pParent ),
+        aUpdateIdle         ( "SvxSuperContourDlg UpdateIdle" ),
+        aCreateIdle         ( "SvxSuperContourDlg CreateIdle" ),
         pUpdateEditingObject( nullptr ),
         pCheckObj           ( nullptr ),
         aContourItem        ( SID_CONTOUR_EXEC, *this, *_pBindings ),
diff --git a/svx/source/dialog/svxbmpnumvalueset.cxx b/svx/source/dialog/svxbmpnumvalueset.cxx
index e4d48afbcf6b..86f692089a11 100644
--- a/svx/source/dialog/svxbmpnumvalueset.cxx
+++ b/svx/source/dialog/svxbmpnumvalueset.cxx
@@ -461,6 +461,7 @@ void SvxNumValueSet::SetOutlineNumberingSettings(
 
 SvxBmpNumValueSet::SvxBmpNumValueSet(vcl::Window* pParent, WinBits nWinBits)
     : SvxNumValueSet(pParent, nWinBits)
+    , aFormatIdle("SvxBmpNumValueSet FormatIdle")
 {
     init();
 }
diff --git a/svx/source/sdr/overlay/overlaymanagerbuffered.cxx b/svx/source/sdr/overlay/overlaymanagerbuffered.cxx
index 6fe69de9636a..d5bb135a4c7a 100644
--- a/svx/source/sdr/overlay/overlaymanagerbuffered.cxx
+++ b/svx/source/sdr/overlay/overlaymanagerbuffered.cxx
@@ -379,6 +379,7 @@ namespace sdr
         :   OverlayManager(rOutputDevice),
             mpBufferDevice(VclPtr<VirtualDevice>::Create()),
             mpOutputBufferDevice(VclPtr<VirtualDevice>::Create()),
+            maBufferIdle("sdr overlay OverlayManagerBuffered Idle"),
             mbRefreshWithPreRendering(bRefreshWithPreRendering)
         {
             // Init timer
diff --git a/svx/source/sidebar/PanelLayout.cxx b/svx/source/sidebar/PanelLayout.cxx
index 0e04605de235..62ffa61e1250 100644
--- a/svx/source/sidebar/PanelLayout.cxx
+++ b/svx/source/sidebar/PanelLayout.cxx
@@ -20,6 +20,7 @@ using namespace sfx2::sidebar;
 
 PanelLayout::PanelLayout(vcl::Window* pParent, const OString& rID, const OUString& rUIXMLDescription, const css::uno::Reference<css::frame::XFrame> &rFrame)
     : Control(pParent)
+    , m_aPanelLayoutIdle("svx sidebar PanelLayoutIdle")
     , m_bInClose(false)
 {
     SetStyle(GetStyle() | WB_DIALOGCONTROL);
diff --git a/sw/source/core/doc/DocumentTimerManager.cxx b/sw/source/core/doc/DocumentTimerManager.cxx
index 2840e9b381f9..1a0fa08353e9 100644
--- a/sw/source/core/doc/DocumentTimerManager.cxx
+++ b/sw/source/core/doc/DocumentTimerManager.cxx
@@ -39,7 +39,8 @@ namespace sw
 
 DocumentTimerManager::DocumentTimerManager( SwDoc& i_rSwdoc ) : m_rDoc( i_rSwdoc ),
                                                                 mbStartIdleTimer( false ),
-                                                                mIdleBlockCount( 0 )
+                                                                mIdleBlockCount( 0 ),
+                                                                maIdle("DocumentTimerManagerIdleTimer")
 {
     maIdle.SetPriority( SchedulerPriority::LOWEST );
     maIdle.SetIdleHdl( LINK( this, DocumentTimerManager, DoIdleJobs) );
diff --git a/sw/source/core/docnode/threadmanager.cxx b/sw/source/core/docnode/threadmanager.cxx
index 46e58dab9f7c..750ff2090888 100644
--- a/sw/source/core/docnode/threadmanager.cxx
+++ b/sw/source/core/docnode/threadmanager.cxx
@@ -37,7 +37,7 @@ ThreadManager::ThreadManager( uno::Reference< util::XJobManager >& rThreadJoiner
       mnThreadIDCounter( 0 ),
       maWaitingForStartThreads(),
       maStartedThreads(),
-      maStartNewThreadIdle(),
+      maStartNewThreadIdle("SW ThreadManager StartNewThreadIdle"),
       mbStartingOfThreadsSuspended( false )
 {
 }