diff options
author | Noel Grandin <noel@peralex.com> | 2016-04-11 15:11:42 +0200 |
---|---|---|
committer | Noel Grandin <noel@peralex.com> | 2016-04-11 15:12:11 +0200 |
commit | 2c93d340ae4e854b5c9d3aa8c38a8bba0ae6b74b (patch) | |
tree | fbacc0fb655c0f2eb71c737f316024a1b3274630 | |
parent | fb42d03b5a404ac73e24d90e094885c14c3b7584 (diff) |
clang-tidy performance-unnecessary-value-param in vbahelper
Change-Id: Ifbe78c4a43b9d77d6ecf481bb1a9aaac6bcd01a6
-rw-r--r-- | include/vbahelper/vbashapes.hxx | 4 | ||||
-rw-r--r-- | vbahelper/source/vbahelper/vbafillformat.cxx | 2 | ||||
-rw-r--r-- | vbahelper/source/vbahelper/vbafillformat.hxx | 2 | ||||
-rw-r--r-- | vbahelper/source/vbahelper/vbashapes.cxx | 4 |
4 files changed, 6 insertions, 6 deletions
diff --git a/include/vbahelper/vbashapes.hxx b/include/vbahelper/vbashapes.hxx index 22ba0aaa77f1..78bdc3391870 100644 --- a/include/vbahelper/vbashapes.hxx +++ b/include/vbahelper/vbashapes.hxx @@ -52,8 +52,8 @@ protected: public: ScVbaShapes( const css::uno::Reference< ov::XHelperInterface >& xParent, const css::uno::Reference< css::uno::XComponentContext >& xContext, const css::uno::Reference< css::container::XIndexAccess >& xShapes, const css::uno::Reference< css::frame::XModel >& xModel ); - static void setDefaultShapeProperties( css::uno::Reference< css::drawing::XShape > xShape ) throw (css::uno::RuntimeException); - static void setShape_NameProperty( css::uno::Reference< css::drawing::XShape > xShape, const OUString& sName ); + static void setDefaultShapeProperties( const css::uno::Reference< css::drawing::XShape >& xShape ) throw (css::uno::RuntimeException); + static void setShape_NameProperty( const css::uno::Reference< css::drawing::XShape >& xShape, const OUString& sName ); //XEnumerationAccess virtual css::uno::Type SAL_CALL getElementType() throw (css::uno::RuntimeException) override; virtual css::uno::Reference< css::container::XEnumeration > SAL_CALL createEnumeration() throw (css::uno::RuntimeException) override; diff --git a/vbahelper/source/vbahelper/vbafillformat.cxx b/vbahelper/source/vbahelper/vbafillformat.cxx index 0313dd8d49dd..31f77ddee679 100644 --- a/vbahelper/source/vbahelper/vbafillformat.cxx +++ b/vbahelper/source/vbahelper/vbafillformat.cxx @@ -26,7 +26,7 @@ using namespace ooo::vba; using namespace com::sun::star; -ScVbaFillFormat::ScVbaFillFormat( const uno::Reference< XHelperInterface >& xParent, const uno::Reference< uno::XComponentContext >& xContext, const uno::Reference< drawing::XShape > xShape ) : ScVbaFillFormat_BASE( xParent, xContext ), m_xShape( xShape ) +ScVbaFillFormat::ScVbaFillFormat( const uno::Reference< XHelperInterface >& xParent, const uno::Reference< uno::XComponentContext >& xContext, const uno::Reference< drawing::XShape >& xShape ) : ScVbaFillFormat_BASE( xParent, xContext ), m_xShape( xShape ) { m_xPropertySet.set( xShape, uno::UNO_QUERY_THROW ); m_nFillStyle = drawing::FillStyle_SOLID; diff --git a/vbahelper/source/vbahelper/vbafillformat.hxx b/vbahelper/source/vbahelper/vbafillformat.hxx index fd19d74abe33..80a3e793eb98 100644 --- a/vbahelper/source/vbahelper/vbafillformat.hxx +++ b/vbahelper/source/vbahelper/vbafillformat.hxx @@ -43,7 +43,7 @@ protected: virtual css::uno::Sequence<OUString> getServiceNames() override; public: - ScVbaFillFormat( const css::uno::Reference< ov::XHelperInterface >& xParent, const css::uno::Reference< css::uno::XComponentContext >& xContext, const css::uno::Reference< css::drawing::XShape > xShape ); + ScVbaFillFormat( const css::uno::Reference< ov::XHelperInterface >& xParent, const css::uno::Reference< css::uno::XComponentContext >& xContext, const css::uno::Reference< css::drawing::XShape >& xShape ); void setForeColorAndInternalStyle( sal_Int32 nForeColor ) throw (css::uno::RuntimeException); // Attributes diff --git a/vbahelper/source/vbahelper/vbashapes.cxx b/vbahelper/source/vbahelper/vbashapes.cxx index 9e3346d516a6..0126bfebabd4 100644 --- a/vbahelper/source/vbahelper/vbashapes.cxx +++ b/vbahelper/source/vbahelper/vbashapes.cxx @@ -409,7 +409,7 @@ ScVbaShapes::AddTextboxInWriter( sal_Int32 /*_nOrientation*/, sal_Int32 _nLeft, } void -ScVbaShapes::setDefaultShapeProperties( uno::Reference< drawing::XShape > xShape ) throw (uno::RuntimeException) +ScVbaShapes::setDefaultShapeProperties( const uno::Reference< drawing::XShape >& xShape ) throw (uno::RuntimeException) { uno::Reference< beans::XPropertySet > xPropertySet( xShape, uno::UNO_QUERY_THROW ); xPropertySet->setPropertyValue( "FillStyle", uno::makeAny( OUString("SOLID") ) ); @@ -420,7 +420,7 @@ ScVbaShapes::setDefaultShapeProperties( uno::Reference< drawing::XShape > xShape } void -ScVbaShapes::setShape_NameProperty( uno::Reference< css::drawing::XShape > xShape, const OUString& sName ) +ScVbaShapes::setShape_NameProperty( const uno::Reference< css::drawing::XShape >& xShape, const OUString& sName ) { uno::Reference< beans::XPropertySet > xPropertySet( xShape, uno::UNO_QUERY_THROW ); try |