diff options
| author | Miklos Vajna <vmiklos@collabora.com> | 2019-05-30 21:20:25 +0200 |
|---|---|---|
| committer | Miklos Vajna <vmiklos@collabora.com> | 2019-05-31 08:35:04 +0200 |
| commit | 62a9df7473f4213d6ac63faa0a7c0555212bfdee (patch) | |
| tree | 43ac0eca34e79fe54033e790feca5a6f6763e5ee | |
| parent | 4ede42d9d435ba309b0e6c2df05688a35ecb568e (diff) | |
find-unneded-includes: avoid replacing includes with forward-declarations
Verified that e.g. writerfilter/source/dmapper/DomainMapper.cxx used to
trigger advices to replace includes with forward-declarations, and now
that's gone.
See https://gerrit.libreoffice.org/#/c/72972/ for motivation, there are
cases where a forward-declaration depends on the version of the
external, while the include does not, so such changes have to be done
with more care.
Change-Id: I86d396ac743b3fc425868ffda26c0c9e85a00d0e
Reviewed-on: https://gerrit.libreoffice.org/73221
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
| -rwxr-xr-x | bin/find-unneeded-includes | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/bin/find-unneeded-includes b/bin/find-unneeded-includes index aaa2b251434b..35784c0083e8 100755 --- a/bin/find-unneeded-includes +++ b/bin/find-unneeded-includes @@ -276,7 +276,7 @@ def tidy(compileCommands, paths): if assume: args = args.replace(assumeAbs, "-x c++ " + pathAbs) - invocation = "include-what-you-use " + args + invocation = "include-what-you-use -Xiwyu --no_fwd_decls " + args task_queue.put((invocation, moduleRules)) task_queue.join() |