diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2016-11-23 10:28:46 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2016-11-23 11:55:09 +0200 |
commit | 84e3e6ee04c2be0f8fa3a43c8c55bad6b6504f65 (patch) | |
tree | 1b766dfd05eab5ca9fdf5b8066de2a64e0759bcb | |
parent | ba9b0fb78ab7492839c6127607f9d5a9b3927ed2 (diff) |
convert DELMODE to scoped enum
Change-Id: Idd3f45adb43930358420dba464dbdb88fe27b91d
-rw-r--r-- | editeng/source/editeng/editdoc.hxx | 6 | ||||
-rw-r--r-- | editeng/source/editeng/editeng.cxx | 17 | ||||
-rw-r--r-- | editeng/source/editeng/impedit.hxx | 2 | ||||
-rw-r--r-- | editeng/source/editeng/impedit2.cxx | 16 |
4 files changed, 21 insertions, 20 deletions
diff --git a/editeng/source/editeng/editdoc.hxx b/editeng/source/editeng/editdoc.hxx index 51b9ac293194..fb1eb188efd2 100644 --- a/editeng/source/editeng/editdoc.hxx +++ b/editeng/source/editeng/editdoc.hxx @@ -338,9 +338,9 @@ enum class PortionKind HYPHENATOR = 4 }; -#define DELMODE_SIMPLE 0 -#define DELMODE_RESTOFWORD 1 -#define DELMODE_RESTOFCONTENT 2 +enum class DeleteMode { + Simple, RestOfWord, RestOfContent +}; #define CHAR_NORMAL 0x00 #define CHAR_KANA 0x01 diff --git a/editeng/source/editeng/editeng.cxx b/editeng/source/editeng/editeng.cxx index 11912f671343..e4b0fb0afe4c 100644 --- a/editeng/source/editeng/editeng.cxx +++ b/editeng/source/editeng/editeng.cxx @@ -1140,30 +1140,31 @@ bool EditEngine::PostKeyEvent( const KeyEvent& rKeyEvent, EditView* pEditView, v break; } - sal_uInt8 nDel = 0, nMode = 0; + sal_uInt8 nDel = 0; + DeleteMode nMode = DeleteMode::Simple; switch( nCode ) { case css::awt::Key::DELETE_WORD_BACKWARD: - nMode = DELMODE_RESTOFWORD; + nMode = DeleteMode::RestOfWord; nDel = DEL_LEFT; break; case css::awt::Key::DELETE_WORD_FORWARD: - nMode = DELMODE_RESTOFWORD; + nMode = DeleteMode::RestOfWord; nDel = DEL_RIGHT; break; case css::awt::Key::DELETE_TO_BEGIN_OF_PARAGRAPH: - nMode = DELMODE_RESTOFCONTENT; + nMode = DeleteMode::RestOfContent; nDel = DEL_LEFT; break; case css::awt::Key::DELETE_TO_END_OF_PARAGRAPH: - nMode = DELMODE_RESTOFCONTENT; + nMode = DeleteMode::RestOfContent; nDel = DEL_RIGHT; break; default: nDel = ( nCode == KEY_DELETE ) ? DEL_RIGHT : DEL_LEFT; - nMode = rKeyEvent.GetKeyCode().IsMod1() ? DELMODE_RESTOFWORD : DELMODE_SIMPLE; - if ( ( nMode == DELMODE_RESTOFWORD ) && rKeyEvent.GetKeyCode().IsShift() ) - nMode = DELMODE_RESTOFCONTENT; + nMode = rKeyEvent.GetKeyCode().IsMod1() ? DeleteMode::RestOfWord : DeleteMode::Simple; + if ( ( nMode == DeleteMode::RestOfWord ) && rKeyEvent.GetKeyCode().IsShift() ) + nMode = DeleteMode::RestOfContent; break; } diff --git a/editeng/source/editeng/impedit.hxx b/editeng/source/editeng/impedit.hxx index 2909167a8f0f..45216e536f90 100644 --- a/editeng/source/editeng/impedit.hxx +++ b/editeng/source/editeng/impedit.hxx @@ -795,7 +795,7 @@ public: EditPaM InsertTextUserInput( const EditSelection& rCurEditSelection, sal_Unicode c, bool bOverwrite ); EditPaM InsertText(const EditSelection& aCurEditSelection, const OUString& rStr); EditPaM AutoCorrect( const EditSelection& rCurEditSelection, sal_Unicode c, bool bOverwrite, vcl::Window* pFrameWin = nullptr ); - EditPaM DeleteLeftOrRight( const EditSelection& rEditSelection, sal_uInt8 nMode, sal_uInt8 nDelMode ); + EditPaM DeleteLeftOrRight( const EditSelection& rEditSelection, sal_uInt8 nMode, DeleteMode nDelMode ); EditPaM InsertParaBreak(const EditSelection& rEditSelection); EditPaM InsertLineBreak(const EditSelection& aEditSelection); EditPaM InsertTab(const EditSelection& rEditSelection); diff --git a/editeng/source/editeng/impedit2.cxx b/editeng/source/editeng/impedit2.cxx index 43934f21000e..4bfb92c2f2fd 100644 --- a/editeng/source/editeng/impedit2.cxx +++ b/editeng/source/editeng/impedit2.cxx @@ -2267,7 +2267,7 @@ EditPaM ImpEditEngine::ImpConnectParagraphs( ContentNode* pLeft, ContentNode* pR return aPaM; } -EditPaM ImpEditEngine::DeleteLeftOrRight( const EditSelection& rSel, sal_uInt8 nMode, sal_uInt8 nDelMode ) +EditPaM ImpEditEngine::DeleteLeftOrRight( const EditSelection& rSel, sal_uInt8 nMode, DeleteMode nDelMode ) { OSL_ENSURE( !EditSelection( rSel ).DbgIsBuggy( aEditDoc ), "Index out of range in DeleteLeftOrRight" ); @@ -2279,11 +2279,11 @@ EditPaM ImpEditEngine::DeleteLeftOrRight( const EditSelection& rSel, sal_uInt8 n EditPaM aDelEnd( aCurPos ); if ( nMode == DEL_LEFT ) { - if ( nDelMode == DELMODE_SIMPLE ) + if ( nDelMode == DeleteMode::Simple ) { aDelStart = CursorLeft( aCurPos, i18n::CharacterIteratorMode::SKIPCHARACTER ); } - else if ( nDelMode == DELMODE_RESTOFWORD ) + else if ( nDelMode == DeleteMode::RestOfWord ) { aDelStart = StartOfWord( aCurPos ); if ( aDelStart.GetIndex() == aCurPos.GetIndex() ) @@ -2303,11 +2303,11 @@ EditPaM ImpEditEngine::DeleteLeftOrRight( const EditSelection& rSel, sal_uInt8 n } else { - if ( nDelMode == DELMODE_SIMPLE ) + if ( nDelMode == DeleteMode::Simple ) { aDelEnd = CursorRight( aCurPos ); } - else if ( nDelMode == DELMODE_RESTOFWORD ) + else if ( nDelMode == DeleteMode::RestOfWord ) { aDelEnd = EndOfWord( aCurPos ); @@ -2355,12 +2355,12 @@ EditPaM ImpEditEngine::DeleteLeftOrRight( const EditSelection& rSel, sal_uInt8 n } // ConnectParagraphs not enough for different Nodes when - // DELMODE_RESTOFCONTENT. - if ( ( nDelMode == DELMODE_RESTOFCONTENT ) || ( aDelStart.GetNode() == aDelEnd.GetNode() ) ) + // DeleteMode::RestOfContent. + if ( ( nDelMode == DeleteMode::RestOfContent ) || ( aDelStart.GetNode() == aDelEnd.GetNode() ) ) return ImpDeleteSelection( EditSelection( aDelStart, aDelEnd ) ); // Decide now if to delete selection (RESTOFCONTENTS) - bool bSpecialBackward = ( nMode == DEL_LEFT ) && ( nDelMode == DELMODE_SIMPLE ); + bool bSpecialBackward = ( nMode == DEL_LEFT ) && ( nDelMode == DeleteMode::Simple ); if ( aStatus.IsAnyOutliner() ) bSpecialBackward = false; |