summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2014-06-10 15:30:02 +0100
committerCaolán McNamara <caolanm@redhat.com>2014-06-10 16:08:06 +0100
commit6e57eb3aebb41b504d51ddb8f5cfd2d44ca7434e (patch)
treec42f0e485436ab83526097799e6d4b766a4d6d82
parent8371ef9e31aeb0a9ba712f7eaa9296b02a269500 (diff)
coverity#1169822 Unchecked dynamic_cast
Change-Id: If68af1250b285c82539ecf08c713753dc5e74217
-rw-r--r--chart2/source/view/main/DummyXShape.cxx7
1 files changed, 3 insertions, 4 deletions
diff --git a/chart2/source/view/main/DummyXShape.cxx b/chart2/source/view/main/DummyXShape.cxx
index a90ef5810833..12d93678db3a 100644
--- a/chart2/source/view/main/DummyXShape.cxx
+++ b/chart2/source/view/main/DummyXShape.cxx
@@ -1081,11 +1081,10 @@ void DummyXShapes::release()
void SAL_CALL DummyXShapes::add( const uno::Reference< drawing::XShape>& xShape )
throw(uno::RuntimeException, std::exception)
{
- DummyXShape* pChild = dynamic_cast<DummyXShape*>(xShape.get());
- assert(pChild);
+ DummyXShape& rChild = dynamic_cast<DummyXShape&>(*xShape.get());
maUNOShapes.push_back(xShape);
- pChild->setParent(static_cast< ::cppu::OWeakObject* >( this ));
- maShapes.push_back(pChild);
+ rChild.setParent(static_cast< ::cppu::OWeakObject* >( this ));
+ maShapes.push_back(&rChild);
}
void SAL_CALL DummyXShapes::remove( const uno::Reference< drawing::XShape>& xShape )