summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2015-10-23 11:38:43 +0100
committerCaolán McNamara <caolanm@redhat.com>2015-10-23 11:57:36 +0100
commitf8b975995c5d0dc6a9fc8febba0667fe24542ad2 (patch)
tree07b01deea491b63e8dde27cf2cbb67f2c3275bdb
parent63cec254e7ce54c7f919442002187638ff5dfed1 (diff)
afl-eventtesting: crash on undoing insert new page in impress
this is an intermittent crash in the real world but under event testing we can see that the PaintView is informed that the page has been deleted, but doesn't clear its use of the page if it so happens that there was earlier modification events that caused the fire-modification-timer to be launched If there happens to be no such events then the page is correctly cleared If the timer is active, then the page is not cleared, but eventually the timer will fire and access the deleted page and fall over and die minimal change for backporting ease, follow ups now Change-Id: I090ad62cc175545902574c93dec7082225d97ab7
-rw-r--r--svx/source/svdraw/svdpntv.cxx4
-rw-r--r--vcl/qa/afl-eventtesting/eventtesting.impress.crash-3bin0 -> 196 bytes
2 files changed, 2 insertions, 2 deletions
diff --git a/svx/source/svdraw/svdpntv.cxx b/svx/source/svdraw/svdpntv.cxx
index 9ca6864e92fe..542af57d081b 100644
--- a/svx/source/svdraw/svdpntv.cxx
+++ b/svx/source/svdraw/svdpntv.cxx
@@ -259,12 +259,12 @@ void SdrPaintView::Notify(SfxBroadcaster& rBC, const SfxHint& rHint)
return;
}
- bool bObjChg=!mbSomeObjChgdFlag; // if true, evaluate for ComeBack timer
- if (bObjChg) {
+ {
const SdrHint* pSdrHint = dynamic_cast<const SdrHint*>(&rHint);
if (pSdrHint) {
SdrHintKind eKind=pSdrHint->GetKind();
if (eKind==HINT_OBJCHG || eKind==HINT_OBJINSERTED || eKind==HINT_OBJREMOVED) {
+ bool bObjChg=!mbSomeObjChgdFlag; // if true, evaluate for ComeBack timer
if (bObjChg) {
mbSomeObjChgdFlag=true;
maComeBackIdle.Start();
diff --git a/vcl/qa/afl-eventtesting/eventtesting.impress.crash-3 b/vcl/qa/afl-eventtesting/eventtesting.impress.crash-3
new file mode 100644
index 000000000000..e6639bab1b85
--- /dev/null
+++ b/vcl/qa/afl-eventtesting/eventtesting.impress.crash-3
Binary files differ