summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2019-10-16 20:20:26 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2019-10-17 09:55:21 +0200
commit01d28b0b85f99590c0581e4bbf636bc9281e0571 (patch)
tree8e8bf20ebc235354110da86b826d93c09730ae4a
parentd51db77c8d87f210785a8a8c6dd875f7bacddb3c (diff)
loplugin:stringadd fix condition
Change-Id: I7752c281b1b6dd0d26bd7d6c4a6896c663f4cbc3 Reviewed-on: https://gerrit.libreoffice.org/80921 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-rw-r--r--compilerplugins/clang/stringadd.cxx3
1 files changed, 2 insertions, 1 deletions
diff --git a/compilerplugins/clang/stringadd.cxx b/compilerplugins/clang/stringadd.cxx
index 986b2f938c7d..1a9c7c90d152 100644
--- a/compilerplugins/clang/stringadd.cxx
+++ b/compilerplugins/clang/stringadd.cxx
@@ -264,7 +264,8 @@ bool StringAdd::isSideEffectFree(Expr const* expr)
{
auto name = calleeMethodDecl->getName();
if (callExpr->getNumArgs() > 0
- && (name == "number" || name == "unacquired" || "boolean"))
+ && (name == "number" || name == "unacquired" || name == "boolean"
+ || name == "copy"))
{
auto tc = loplugin::TypeCheck(calleeMethodDecl->getParent());
if (tc.Class("OUString") || tc.Class("OString"))